From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59628: 29.0.50; treesit-beginning/end-of-defun problems in C/C++ Date: Mon, 28 Nov 2022 14:08:18 -0800 Message-ID: <10635EBA-B74E-49BD-BDD6-34B0C901A335@gmail.com> References: <83v8n0puxi.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20036"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 59628@debbugs.gnu.org To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 28 23:09:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozmJQ-00052W-0u for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Nov 2022 23:09:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozmJD-0008Dl-Pn; Mon, 28 Nov 2022 17:09:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozmJC-0008CC-F1 for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 17:09:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozmJC-0002y0-6Z for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 17:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ozmJB-00032c-TF for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 17:09:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <83v8n0puxi.fsf@gnu.org> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Nov 2022 22:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59628 X-GNU-PR-Package: emacs Original-Received: via spool by 59628-submit@debbugs.gnu.org id=B59628.166967330911681 (code B ref 59628); Mon, 28 Nov 2022 22:09:01 +0000 Original-Received: (at 59628) by debbugs.gnu.org; 28 Nov 2022 22:08:29 +0000 Original-Received: from localhost ([127.0.0.1]:51191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozmIe-00032L-Qn for submit@debbugs.gnu.org; Mon, 28 Nov 2022 17:08:29 -0500 Original-Received: from mail-pl1-f170.google.com ([209.85.214.170]:33538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozmIc-00032F-53 for 59628@debbugs.gnu.org; Mon, 28 Nov 2022 17:08:26 -0500 Original-Received: by mail-pl1-f170.google.com with SMTP id 4so11589562pli.0 for <59628@debbugs.gnu.org>; Mon, 28 Nov 2022 14:08:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=XIjoXYeNesjPqq/m/y523voYf+k12HOUz4IMxYsuVOU=; b=CopZ8ROYVODQJoGe0ohmD23ZVmDszkaT6SSqnSmbxtPWQNgp3t41CJXIyPAPqOnkW3 9PrsWKwYS1YxZqA2SIvaysLU/f9dpFvjuT1AHKf5EVUgkKjBlwQqjQQOh0afkfSaro8F D/JzMNN8ws2Gze+EWNZEJiJqfjK5RQp75yAjei5u5pThE8dCuN1o1LkqsxXjHyCLfc1D Os76J+7PveVmNEiVQPyD1EqBz6PcRmXZTdtzglIIQuolA6pQHY0qUnPf4dlA3beCDmdP CXgRLT2LjNqIfo0ApcrAuOVODU3UJM21Y3hmzUMefCyViwcQHVdulyiCT2GOUDY10sjY x33Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XIjoXYeNesjPqq/m/y523voYf+k12HOUz4IMxYsuVOU=; b=gDooozPcI7EmlA+wkU+npLVh5JqkFaaUSx3hUGH65bHqtoGlRyNPvy50yEX8Y8wuGK Nw+Zu4Y8qeoMvR4EssJCJfloLGj/+e74win7xFO/554opR6YzrlpABDiXfDLCTvYtLGo Fmn5QVaqxytjIu5cKGLtsMS4dDe3xlaSGHPhoqxdTIfyHWYqfG9/cbEvyEznPuI79cV5 0ksy58kvcKAFQ/YKiz8wTeLiZZHBumTaKRvs9q4ju0PX8oePSc1UnSOe+/kZMNAmbvTJ +luUZL/mirWJFrscoMhWFDym9vVo8vKb7hDWbF5Oh0Q3AqXotEFNrJtWo2009eLco2a+ iCUg== X-Gm-Message-State: ANoB5pmb8eCxO0oAvxRQ5sshSzPGqSpfgqnCjNFZwbLiioOewv5CvsaR XjiWRw8DBInSLI/OLHy/2Os= X-Google-Smtp-Source: AA0mqf4TmvfiCdwVqE9XrxYdT3Z//B1Xs9hIBkYml6JADSYoRDPswnDpLOoKOjEW8arDg/M4/ynB3w== X-Received: by 2002:a17:90a:307:b0:213:dce7:e1fe with SMTP id 7-20020a17090a030700b00213dce7e1femr63480024pje.110.1669673300213; Mon, 28 Nov 2022 14:08:20 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id b13-20020a170903228d00b00186b7443082sm9348910plh.195.2022.11.28.14.08.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Nov 2022 14:08:19 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249344 Archived-At: Daniel Mart=C3=ADn writes: > Eli Zaretskii writes: > >> To reproduce, visit any C source file in the Emacs tree, turn on = c-ts-mode >> or c++-ts-mode, go to the middle of some function, and type >> >> M-: (treesit-beginning-of-defun) RET >> or >> M-: (treesit-end-of-defun) RET >> >> This will move point to very strange places, which generally are = neither the >> beginning nor the end of the function. In very simple functions, = like this >> one: >> >> void >> __executable_start (void) >> { >> emacs_abort (); >> } >> >> the result is correct. But once the function is even slightly more >> complicated, for example, like this: >> >> static int >> margin_glyphs_to_reserve (struct window *w, int total_glyphs, int = margin) >> { >> if (margin > 0) >> { >> int width =3D w->total_cols; >> double d =3D max (0, margin); >> d =3D min (width / 2 - 1, d); >> /* Since MARGIN is positive, we cannot possibly have less than >> one glyph for the marginal area. */ >> return max (1, (int) ((double) total_glyphs / width * d)); >> } >> return 0; >> } >> >> the results are very far off the mark. >> >> These two functions are the only ones to move by defuns in = treesit-based >> modes, right? So they should be improved, IMO. Yeah, I=E2=80=99ll need to look at C grammar and fix = treesit-defun-type-regexp. > > If I type > > M-: (setq treesit-defun-type-regexp "function_definition") RET > > treesit-beginning-of-defun and treesit-end-of-defun do the right = thing. > That begs the question: Is it really necessary to have a Tree-sitter > regexp variable to match defun nodes? If yes, should it already have = a > sensible default value so things work out of the box in most major > modes? Different languages have different grammars that give different names to function definitions and class definitions. So it is necessary to have a regexp variable. Finding such a regexp isn=E2=80=99t too hard, so I = don=E2=80=99t think we need a default value. If we do have a default, it would be often = wrong, given differences between language grammars.