From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#7850: 23.2.91; emacs runs svn status -v after every file save Date: Sun, 04 Nov 2012 00:22:01 -0400 Message-ID: <0lhap6atg6.fsf@fencepost.gnu.org> References: <20110116164820.GD4949@srevilak.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1352002989 19592 80.91.229.3 (4 Nov 2012 04:23:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 4 Nov 2012 04:23:09 +0000 (UTC) To: 7850-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 04 05:23:18 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TUrjx-0000zi-QS for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Nov 2012 05:23:17 +0100 Original-Received: from localhost ([::1]:58807 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUrjo-0003C3-S6 for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Nov 2012 00:23:08 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48681) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUrjm-0003Bv-1u for bug-gnu-emacs@gnu.org; Sun, 04 Nov 2012 00:23:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TUrjk-0001pn-NG for bug-gnu-emacs@gnu.org; Sun, 04 Nov 2012 00:23:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37669) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUrjk-0001pg-Jz for bug-gnu-emacs@gnu.org; Sun, 04 Nov 2012 00:23:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TUrmb-0008VW-W4 for bug-gnu-emacs@gnu.org; Sun, 04 Nov 2012 00:26:01 -0400 Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Nov 2012 04:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 7850 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 7850@debbugs.gnu.org, rgm@gnu.org Original-Received: via spool by 7850-done@debbugs.gnu.org id=D7850.135200310532633 (code D ref 7850); Sun, 04 Nov 2012 04:26:01 +0000 Original-Received: (at 7850-done) by debbugs.gnu.org; 4 Nov 2012 04:25:05 +0000 Original-Received: from localhost ([127.0.0.1]:47919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUrlg-0008UI-5q for submit@debbugs.gnu.org; Sun, 04 Nov 2012 00:25:04 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:46703) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUrlc-0008Ts-Tb for 7850-done@debbugs.gnu.org; Sun, 04 Nov 2012 00:25:02 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TUrij-0003xo-Ph; Sun, 04 Nov 2012 00:22:01 -0400 X-Spook: SAPO Osama insurgency USCODE World Trade Center SEAL Team X-Ran: pH0G$L90%GQX(QyCdl_|QJ^$q"Iyl@eRN?Trfow)?.d:S8=d+yAe+MJm`R$uGpxO[d8&!E X-Hue: cyan X-Attribution: GM In-Reply-To: (Glenn Morris's message of "Thu, 20 Jan 2011 21:39:25 -0500") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:66423 Archived-At: Version: 24.4 Glenn Morris wrote: > This can be changed by altering the definition of vc-svn-state-heuristic. > Simply copying the CVS one seems fine (?). I don't think this is an > appropriate change for the coming Emacs 23.3 though. > > > *** lisp/vc-svn.el 2011-01-02 23:50:46 +0000 > --- lisp/vc-svn.el 2011-01-21 02:28:37 +0000 > *************** > *** 156,162 **** > > (defun vc-svn-state-heuristic (file) > "SVN-specific state heuristic." > ! (vc-svn-state file 'local)) > > ;; FIXME it would be better not to have the "remote" argument, > ;; but to distinguish the two output formats based on content. > --- 156,170 ---- > > (defun vc-svn-state-heuristic (file) > "SVN-specific state heuristic." > ! ;; If the file has not changed since checkout, consider it `up-to-date'. > ! ;; Otherwise consider it `edited'. Copied from vc-cvs-state-heuristic. > ! (let ((checkout-time (vc-file-getprop file 'vc-checkout-time)) > ! (lastmod (nth 5 (file-attributes file)))) > ! (cond > ! ((equal checkout-time lastmod) 'up-to-date) > ! ((string= (vc-working-revision file) "0") 'added) > ! ((null checkout-time) 'unregistered) > ! (t 'edited)))) > > ;; FIXME it would be better not to have the "remote" argument, > ;; but to distinguish the two output formats based on content. I was asked to commit this, so I looked at it again and concluded that the fact that it does not handle svn properties is irrelevant. AFAICS (I find vc.el rather opaque), it is _only_ called from vc-state-refresh in vc-after-save. When a file is first visited, vc-svn-registered is called, which explicitly calls "svn status". I think that the only consequence of this change is that eg adding a character, deleting it, and then saving the file will now mark the buffer as VC modified. Previously, it did not. Presumably CVS has always behaved like this, and I don't recall seeing any complaints about that.