From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#24714: delete-directory race condition Date: Tue, 18 Oct 2016 09:44:56 -0700 Organization: UCLA Computer Science Department Message-ID: <0fef1f0c-3730-9962-5dbd-a114d465a7b2@cs.ucla.edu> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------99926CA45558F620211FEA5D" X-Trace: blaine.gmane.org 1476809271 25565 195.159.176.226 (18 Oct 2016 16:47:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Oct 2016 16:47:51 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 Cc: 24714@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 18 18:47:48 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwXXs-0002zQ-QY for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Oct 2016 18:47:21 +0200 Original-Received: from localhost ([::1]:42847 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwXXv-0000Ce-1g for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Oct 2016 12:47:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwXWg-0007k0-PU for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2016 12:46:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwXWc-0008HT-Nm for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2016 12:46:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60350) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bwXWc-0008Gw-Kf for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2016 12:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bwXWc-0006nR-C9 for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2016 12:46:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Oct 2016 16:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24714-submit@debbugs.gnu.org id=B24714.147680910626056 (code B ref 24714); Tue, 18 Oct 2016 16:46:02 +0000 Original-Received: (at 24714) by debbugs.gnu.org; 18 Oct 2016 16:45:06 +0000 Original-Received: from localhost ([127.0.0.1]:38307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwXVi-0006mC-JE for submit@debbugs.gnu.org; Tue, 18 Oct 2016 12:45:06 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:52222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwXVg-0006lS-VM for 24714@debbugs.gnu.org; Tue, 18 Oct 2016 12:45:05 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A865D160508; Tue, 18 Oct 2016 09:44:57 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id WwiR2V2MKzER; Tue, 18 Oct 2016 09:44:57 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0C8FC16104A; Tue, 18 Oct 2016 09:44:57 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id RynpL1CRLK53; Tue, 18 Oct 2016 09:44:56 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id E3F53160508; Tue, 18 Oct 2016 09:44:56 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124642 Archived-At: This is a multi-part message in MIME format. --------------99926CA45558F620211FEA5D Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Although I didn't reproduce the bug, I changed delete-directory according to Eli's suggestion by installing the attached patch into master. Glenn, can you please try it in your environment? --------------99926CA45558F620211FEA5D Content-Type: application/x-patch; name="0001-delete-directory-no-longer-errors-when-racing.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-delete-directory-no-longer-errors-when-racing.patch" RnJvbSBjZjgwZmNjMmI2ZDMyYmVkNDg0YzIzMDE1MmUwMTcyMGJhMTZiYzE1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUdWUsIDE4IE9jdCAyMDE2IDA5OjM2OjAzIC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gZGVsZXRlLWRpcmVjdG9yeSBubyBsb25nZXIgZXJyb3JzIHdoZW4gcmFjaW5nCgpQcm9i bGVtIHJlcG9ydGVkIGJ5IEdsZW5uIE1vcnJpcyBmb3IgcGFja2FnZS10ZXN0LmVsIChCdWcj MjQ3MTQpLgoqIGRvYy9saXNwcmVmL2ZpbGVzLnRleGkgKENyZWF0ZS9EZWxldGUgRGlycyks IGV0Yy9ORVdTOiBEb2N1bWVudCB0aGlzLgoqIGxpc3AvZmlsZXMuZWwgKGZpbGVzLS1mb3Jj ZSk6IE5ldyBmdW5jdGlvbi4KKGRlbGV0ZS1kaXJlY3RvcnkpOiBVc2UgaXQgdG8gYXZvaWQg ZXJyb3IgaW4gdGhpcyBjYXNlLgotLS0KIGRvYy9saXNwcmVmL2ZpbGVzLnRleGkgfCAgMyAr KysKIGV0Yy9ORVdTICAgICAgICAgICAgICAgfCAgNSArKysrKwogbGlzcC9maWxlcy5lbCAg ICAgICAgICB8IDQ2ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0t LS0tLS0KIDMgZmlsZXMgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2xpc3ByZWYvZmlsZXMudGV4aSBiL2RvYy9saXNwcmVm L2ZpbGVzLnRleGkKaW5kZXggOWFmNWNlOS4uNjJlMDE5OSAxMDA2NDQKLS0tIGEvZG9jL2xp c3ByZWYvZmlsZXMudGV4aQorKysgYi9kb2MvbGlzcHJlZi9maWxlcy50ZXhpCkBAIC0yODU1 LDYgKzI4NTUsOSBAQCBDcmVhdGUvRGVsZXRlIERpcnMKIG11c3QgdXNlIEBjb2Rle2RlbGV0 ZS1kaXJlY3Rvcnl9IGZvciB0aGVtLiAgSWYgQHZhcntyZWN1cnNpdmV9IGlzCiBAY29kZXtu aWx9LCBhbmQgdGhlIGRpcmVjdG9yeSBjb250YWlucyBhbnkgZmlsZXMsCiBAY29kZXtkZWxl dGUtZGlyZWN0b3J5fSBzaWduYWxzIGFuIGVycm9yLgorSWYgcmVjdXJzaXZlIGlzIG5vbi1A Y29kZXtuaWx9LCB0aGVyZSBpcyBubyBlcnJvciBtZXJlbHkgYmVjYXVzZSB0aGUKK2RpcmVj dG9yeSBvciBpdHMgZmlsZXMgYXJlIGRlbGV0ZWQgYnkgc29tZSBvdGhlciBwcm9jZXNzIGJl Zm9yZQorQGNvZGV7ZGVsZXRlLWRpcmVjdG9yeX0gZ2V0cyB0byB0aGVtLgogCiBAY29kZXtk ZWxldGUtZGlyZWN0b3J5fSBvbmx5IGZvbGxvd3Mgc3ltYm9saWMgbGlua3MgYXQgdGhlIGxl dmVsIG9mCiBwYXJlbnQgZGlyZWN0b3JpZXMuCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0 Yy9ORVdTCmluZGV4IDFmZDJhMDAuLmM1MjQ1YmMgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisr KyBiL2V0Yy9ORVdTCkBAIC02MTksNiArNjE5LDExIEBAIGNvbGxlY3Rpb24pLgogKiogVGhl IG5ldyBmdW5jdGlvbnMgJ21ha2UtbmVhcmJ5LXRlbXAtZmlsZScgYW5kICd0ZW1wb3Jhcnkt ZmlsZS1kaXJlY3RvcnknCiBjYW4gYmUgdXNlZCBmb3IgY3JlYXRpb24gb2YgdGVtcG9yYXJ5 IGZpbGVzIG9mIHJlbW90ZSBvciBtb3VudGVkIGRpcmVjdG9yaWVzLgogCisrKysKKyoqIFRo ZSBmdW5jdGlvbiAnZGVsZXRlLWRpcmVjdG9yeScgbm8gbG9uZ2VyIHNpZ25hbHMgYW4gZXJy b3Igd2hlbgorb3BlcmF0aW5nIHJlY3Vyc2l2ZWx5IGFuZCB3aGVuIHNvbWUgb3RoZXIgcHJv Y2VzcyBkZWxldGVzIHRoZSBkaXJlY3RvcnkKK29yIGl0cyBmaWxlcyBiZWZvcmUgJ2RlbGV0 ZS1kaXJlY3RvcnknIGdldHMgdG8gdGhlbS4KKwogKiogQ2hhbmdlcyBpbiBGcmFtZS0gYW5k IFdpbmRvdy0gSGFuZGxpbmcKIAogKysrCmRpZmYgLS1naXQgYS9saXNwL2ZpbGVzLmVsIGIv bGlzcC9maWxlcy5lbAppbmRleCBmNDgxYjk5Li4xMmM2YzE0IDEwMDY0NAotLS0gYS9saXNw L2ZpbGVzLmVsCisrKyBiL2xpc3AvZmlsZXMuZWwKQEAgLTUzMzYsMTQgKzUzMzYsMjYgQEAg ZGlyZWN0b3J5LWZpbGVzLW5vLWRvdC1maWxlcy1yZWdleHAKICAgIl5cXChbXi5dXFx8XFwu XFwoW14uXVxcfFxcLi5cXClcXCkuKiIKICAgIlJlZ2V4cCBtYXRjaGluZyBhbnkgZmlsZSBu YW1lIGV4Y2VwdCBcIi5cIiBhbmQgXCIuLlwiLiIpCiAKKyhkZWZ1biBmaWxlcy0tZm9yY2Ug KG5vLXN1Y2ggZm4gJnJlc3QgYXJncykKKyAgIlVzZSBOTy1TVUNIIHRvIGFmZmVjdCBiZWhh dmlvciBvZiBmdW5jdGlvbiBGTiBhcHBsaWVkIHRvIGxpc3QgQVJHUy4KK1RoaXMgYWN0cyBs aWtlIChhcHBseSBGTiBBUkdTKSBleGNlcHQgaXQgcmV0dXJucyBOTy1TVUNIIGlmIGl0IGlz Citub24tbmlsIGFuZCBpZiBGTiBmYWlscyBkdWUgdG8gYSBtaXNzaW5nIGZpbGUgb3IgZGly ZWN0b3J5LiIKKyAgKGNvbmRpdGlvbi1jYXNlIGVycgorICAgICAgKGFwcGx5IGZuIGFyZ3Mp CisgICAgKGZpbGUtZXJyb3IKKyAgICAgKG9yIChwY2FzZSBlcnIgKGAoLF8gLF8gIk5vIHN1 Y2ggZmlsZSBvciBkaXJlY3RvcnkiIC4gLF8pIG5vLXN1Y2gpKQorCSAoc2lnbmFsIChjYXIg ZXJyKSAoY2RyIGVycikpKSkpKQorCiAoZGVmdW4gZGVsZXRlLWRpcmVjdG9yeSAoZGlyZWN0 b3J5ICZvcHRpb25hbCByZWN1cnNpdmUgdHJhc2gpCiAgICJEZWxldGUgdGhlIGRpcmVjdG9y eSBuYW1lZCBESVJFQ1RPUlkuICBEb2VzIG5vdCBmb2xsb3cgc3ltbGlua3MuCi1JZiBSRUNV UlNJVkUgaXMgbm9uLW5pbCwgYWxsIGZpbGVzIGluIERJUkVDVE9SWSBhcmUgZGVsZXRlZCBh cyB3ZWxsLgorSWYgUkVDVVJTSVZFIGlzIG5vbi1uaWwsIGRlbGV0ZSBmaWxlcyBpbiBESVJF Q1RPUlkgYXMgd2VsbCwgd2l0aAorbm8gZXJyb3IgaWYgc29tZXRoaW5nIGVsc2UgaXMgc2lt dWx0YW5lb3VzbHkgZGVsZXRpbmcgdGhlbS4KIFRSQVNIIG5vbi1uaWwgbWVhbnMgdG8gdHJh c2ggdGhlIGRpcmVjdG9yeSBpbnN0ZWFkLCBwcm92aWRlZAogYGRlbGV0ZS1ieS1tb3Zpbmct dG8tdHJhc2gnIGlzIG5vbi1uaWwuCiAKLVdoZW4gY2FsbGVkIGludGVyYWN0aXZlbHksIFRS QVNIIGlzIHQgaWYgbm8gcHJlZml4IGFyZ3VtZW50IGlzCi1naXZlbi4gIFdpdGggYSBwcmVm aXggYXJndW1lbnQsIFRSQVNIIGlzIG5pbC4iCitXaGVuIGNhbGxlZCBpbnRlcmFjdGl2ZWx5 LCBUUkFTSCBpcyBuaWwgaWYgYW5kIG9ubHkgaWYgYSBwcmVmaXgKK2FyZ3VtZW50IGlzIGdp dmVuLCBhbmQgYSBmdXJ0aGVyIHByb21wdCBhc2tzIHRoZSB1c2VyIGZvcgorUkVDVVJTSVZF IGlmIERJUkVDVE9SWSBpcyBub25lbXB0eS4iCiAgIChpbnRlcmFjdGl2ZQogICAgKGxldCog KCh0cmFzaGluZyAoYW5kIGRlbGV0ZS1ieS1tb3ZpbmctdG8tdHJhc2gKIAkJCSAobnVsbCBj dXJyZW50LXByZWZpeC1hcmcpKSkKQEAgLTUzODEsMTggKzUzOTMsMjIgQEAgZGVsZXRlLWRp cmVjdG9yeQogCShtb3ZlLWZpbGUtdG8tdHJhc2ggZGlyZWN0b3J5KSkpCiAgICAgIDs7IE90 aGVyd2lzZSwgY2FsbCBvdXJzZWx2ZXMgcmVjdXJzaXZlbHkgaWYgbmVlZGVkLgogICAgICAo dAotICAgICAgKGlmIChhbmQgcmVjdXJzaXZlIChub3QgKGZpbGUtc3ltbGluay1wIGRpcmVj dG9yeSkpKQotCSAgKG1hcGMgKGxhbWJkYSAoZmlsZSkKLQkJICA7OyBUaGlzIHRlc3QgaXMg ZXF1aXZhbGVudCB0bwotCQkgIDs7IChhbmQgKGZpbGUtZGlyZWN0b3J5LXAgZm4pIChub3Qg KGZpbGUtc3ltbGluay1wIGZuKSkpCi0JCSAgOzsgYnV0IG1vcmUgZWZmaWNpZW50Ci0JCSAg KGlmIChlcSB0IChjYXIgKGZpbGUtYXR0cmlidXRlcyBmaWxlKSkpCi0JCSAgICAgIChkZWxl dGUtZGlyZWN0b3J5IGZpbGUgcmVjdXJzaXZlIG5pbCkKLQkJICAgIChkZWxldGUtZmlsZSBm aWxlIG5pbCkpKQotCQk7OyBXZSBkbyBub3Qgd2FudCB0byBkZWxldGUgIi4iIGFuZCAiLi4i LgotCQkoZGlyZWN0b3J5LWZpbGVzCi0JCSBkaXJlY3RvcnkgJ2Z1bGwgZGlyZWN0b3J5LWZp bGVzLW5vLWRvdC1maWxlcy1yZWdleHApKSkKLSAgICAgIChkZWxldGUtZGlyZWN0b3J5LWlu dGVybmFsIGRpcmVjdG9yeSkpKSkpCisgICAgICAod2hlbiAob3IgKG5vdCByZWN1cnNpdmUp IChmaWxlLXN5bWxpbmstcCBkaXJlY3RvcnkpCisJCShsZXQqICgoZmlsZXMKKwkJCShmaWxl cy0tZm9yY2UgdCAjJ2RpcmVjdG9yeS1maWxlcyBkaXJlY3RvcnkgJ2Z1bGwKKwkJCQkgICAg ICBkaXJlY3RvcnktZmlsZXMtbm8tZG90LWZpbGVzLXJlZ2V4cCkpCisJCSAgICAgICAoZGly ZWN0b3J5LWV4aXN0cyAobGlzdHAgZmlsZXMpKSkKKwkJICAod2hlbiBkaXJlY3RvcnktZXhp c3RzCisJCSAgICAobWFwYyAobGFtYmRhIChmaWxlKQorCQkJICAgIDs7IFRoaXMgdGVzdCBp cyBlcXVpdmFsZW50IHRvIGJ1dCBtb3JlIGVmZmljaWVudAorCQkJICAgIDs7IHRoYW4gKGFu ZCAoZmlsZS1kaXJlY3RvcnktcCBmbikKKwkJCSAgICA7OwkJIChub3QgKGZpbGUtc3ltbGlu ay1wIGZuKSkpLgorCQkJICAgIChpZiAoZXEgdCAoY2FyIChmaWxlLWF0dHJpYnV0ZXMgZmls ZSkpKQorCQkJCShkZWxldGUtZGlyZWN0b3J5IGZpbGUgcmVjdXJzaXZlKQorCQkJICAgICAg KGZpbGVzLS1mb3JjZSB0ICMnZGVsZXRlLWZpbGUgZmlsZSkpKQorCQkJICBmaWxlcykpCisJ CSAgZGlyZWN0b3J5LWV4aXN0cykpCisJKGZpbGVzLS1mb3JjZSByZWN1cnNpdmUgIydkZWxl dGUtZGlyZWN0b3J5LWludGVybmFsIGRpcmVjdG9yeSkpKSkpKQogCiAoZGVmdW4gZmlsZS1l cXVhbC1wIChmaWxlMSBmaWxlMikKICAgIlJldHVybiBub24tbmlsIGlmIGZpbGVzIEZJTEUx IGFuZCBGSUxFMiBuYW1lIHRoZSBzYW1lIGZpbGUuCi0tIAoyLjcuNAoK --------------99926CA45558F620211FEA5D--