From: Drew Adams <drew.adams@oracle.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 20625@debbugs.gnu.org
Subject: bug#20625: 25.0.50; doc of `define-error` is incorrect
Date: Sat, 23 May 2015 09:22:40 -0700 (PDT) [thread overview]
Message-ID: <0fec8ff5-ea94-442e-a00a-8b75f054f8af@default> (raw)
In-Reply-To: <jwvbnhbgtj8.fsf-monnier+emacsbugs@gnu.org>
> > In fact, I think that the right change would be not only
> > to say what nil MESSAGE means but to make MESSAGE an
> > &optional parameter.
>
> I disagree. The bookmark.el code is just a historical accident.
Then please remove it. Either this is an intended feature
or it is not. If you don't want `define-error` to provide
exactly the same thing that you can get by using property
`error-conditions' directly, then leave its definition and
doc as they are, but change the `bookmark.el' code back to
using `error-conditions' directly, so any code that expects
error condition `bookmark-errors' to be available will not
be surprised. Or remove it from bookmark.el altogether,
if you don't care about such backward compatibility. Or
provide a MESSAGE arg for the definition of `bookmark-errors'.
One way or another, the doc and behavior should match, and
bookmark.el should be made coherent with both.
next prev parent reply other threads:[~2015-05-23 16:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<b9eb3f53-8dec-4157-8a96-7634274687ac@default>
[not found] ` <<83382n38et.fsf@gnu.org>
2015-05-23 14:48 ` bug#20625: 25.0.50; doc of `define-error` is incorrect Drew Adams
2015-05-23 14:57 ` Eli Zaretskii
2015-05-23 16:15 ` Stefan Monnier
2015-05-23 16:22 ` Drew Adams [this message]
[not found] <<10eb5733-c84c-491d-86ca-2d6a05b80e7d@default>
[not found] ` <<83oalb1gvn.fsf@gnu.org>
2015-05-23 16:02 ` Drew Adams
2015-05-21 21:04 Drew Adams
2015-05-23 10:17 ` Eli Zaretskii
2016-04-30 19:25 ` Lars Ingebrigtsen
2016-04-30 19:42 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fec8ff5-ea94-442e-a00a-8b75f054f8af@default \
--to=drew.adams@oracle.com \
--cc=20625@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).