unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: "Clément Pit--Claudel" <clement.pitclaudel@live.com>,
	26958@debbugs.gnu.org
Subject: bug#26958: Can we make wavy underlines scale like straight ones?
Date: Tue, 16 May 2017 21:14:24 -0700 (PDT)	[thread overview]
Message-ID: <0f5ba7d0-ab89-448c-969f-cdfc6bd0ef50@default> (raw)
In-Reply-To: <2751b56b-c419-8ad9-c588-11186a86fb9e@live.com>

> Straight underlines get thicker when font size increases, but wavy
> underlines do not.  The problem is particularly visible on hi-resolution
> displays, where wavy underlines look really tiny. This problem can be
> observed on all displays by running the following and pressing C-x C-= a few
> times:
> 
> (font-lock-mode -1)
> (insert (propertize "AAAAA" 'face '(:underline (:style line)))
>         "\n" (propertize "AAAAA" 'face '(:underline (:style wave))))

FWIW, on Windows I see neither straight nor wavy underline thicken.
They both continue to have the same line width (thickness) when
text-scaled.

Should they not stay the same?  Should they thicken?  Why?

I'm not on a "highdpi", I imagine.  But why should that make
difference as to whether an underline should change thickness
as the text is scaled?

What about :overline?  It has no :wavy property, but should
it too thicken when the text is scaled up?

And :box?  :box has a :line-width property.  Is that relevant
here?  What should the behavior be for :box?  What should it
be for attributes such as :underline or :overline or
:strike-through, which don't have a :line-width property?

It doesn't seem as if the right design is obvious.

Note that the first URL you cite does not ask necessarily for
the wavy underline to scale.  It explicitly asks about
customizing to specify the line width.

Maybe that's what the enhancement request should be: provide
:line-width for :underline, like we do for :box.  And perhaps
for :overline and :strike-through?

The first question is whether such line widths should respond
to scaling.  Dunno.





  reply	other threads:[~2017-05-17  4:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-17  3:47 bug#26958: Can we make wavy underlines scale like straight ones? Clément Pit--Claudel
2017-05-17  4:14 ` Drew Adams [this message]
2017-05-17  4:36   ` Clément Pit--Claudel
2017-05-17 15:23 ` Eli Zaretskii
2017-05-17 19:38   ` Clément Pit--Claudel
2017-05-19  7:18     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f5ba7d0-ab89-448c-969f-cdfc6bd0ef50@default \
    --to=drew.adams@oracle.com \
    --cc=26958@debbugs.gnu.org \
    --cc=clement.pitclaudel@live.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).