From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#56682: feature/improved-locked-narrowing 9dee6df39c: Reworked locked narrowing. Date: Tue, 14 Feb 2023 14:59:22 +0000 Message-ID: <0f053182b04357300cb1@heytings.org> References: <166939872890.18950.12581667269687468681@vcs2.savannah.gnu.org> <83eds0ksev.fsf@gnu.org> <8aadf0ddd54c85c8144a@heytings.org> <831qnhg3d9.fsf@gnu.org> <9757fbea37611e9c44b9@heytings.org> <83cz6yacxt.fsf@gnu.org> <6943e04e30e5a02a52e6@heytings.org> <838rhk5fy1.fsf@gnu.org> <6943e04e30a40824e107@heytings.org> <83k0143q37.fsf@gnu.org> <94821a0ef100102ac9e0@heytings.org> <83bkmdz04y.fsf@gnu.org> <43562d4dd9dffd81938f@heytings.org> <83357ozhx0.fsf@gnu.org> <83wn4zurit.fsf@gnu.org> <83bkmaueib.fsf@gnu.org> <83357fnwyy.fsf@gnu.org> <83ttzsk6v4.fsf@gnu.org> <83wn4le8s3.fsf@gnu.org> <0f053182b02103503c26@heytings.org> <83pmaccnz7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34828"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56682@debbugs.gnu.org, monnier@iro.umontreal.ca, akrl@sdf.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 14 16:00:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRwmy-0008uC-E6 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Feb 2023 16:00:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRwmr-0003o6-BT; Tue, 14 Feb 2023 10:00:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRwmo-0003lu-Uf for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 10:00:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRwmo-0008Qs-Ho for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 10:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pRwmo-0004Ak-Dm for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 10:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Feb 2023 15:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.167638676715966 (code B ref 56682); Tue, 14 Feb 2023 15:00:02 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 14 Feb 2023 14:59:27 +0000 Original-Received: from localhost ([127.0.0.1]:56698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRwmF-00049S-HW for submit@debbugs.gnu.org; Tue, 14 Feb 2023 09:59:27 -0500 Original-Received: from heytings.org ([95.142.160.155]:56568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRwmC-00049I-9H for 56682@debbugs.gnu.org; Tue, 14 Feb 2023 09:59:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1676386762; bh=7J8Go3Z0CDlAR8INDv9bAf9kCzMkUdJbsUMo+n3pNuo=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=a0jhXdMzaUrfaTmKlaJ6dZdKex4ZOP1I26PlmPTmUBs+UIEmLJyidJcMQvplRySuq sgHNkwthO7IOYY6exLH08DArt6LaCmG3NYiflPdHcFmFGKFjfrlh738n3+errRC2EN Oiy84Xf+0amqqV2boCELOCpcMpeZaAq4f0F7W8n2C+LyKSvyS9yItMLtkh9zeRT/5P ES7G/rjfl3UPHt0KI9eON3gSz2KBV2YEkANRjEyBj4PrbLwf77f8Y5ZJgcWfIVEpCG UDfMUbZr0A4SsuFEUcYn0eDZWFr1BZbD1SFneNhpHpFN6xNs6KZOnT+vvyImwYIa0/ Q7j+ovuEOuO+w== In-Reply-To: <83pmaccnz7.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255602 Archived-At: >> 1. There are three places (indent.c:line_number_display_width, >> xdisp.c:display_count_lines_logically, fileio.c:write_region) where we >> currently use >> >> record_unwind_protect (save_restriction_restore, save_restriction_save ()); >> Fwiden (); > > I'm not sure these should be subject to locked narrowing. They don't > present performance problems with very long lines, AFAIK. > >> 2. In another place (process.c:Finternal_default_process_filter) we >> currently have: >> >> /* If the output marker is outside of the visible region, save >> the restriction and widen. */ >> if (! (BEGV <= PT && PT <= ZV)) >> Fwiden (); >> >> (without the "save the restriction" mentioned in the comment). > > This should be fixed to use unwind-protect of some kind, I think, and > that's orthogonal to locked narrowing. > >> 3. Also, in Ferase_buffer, we do Fwiden to "delete the entire contents >> of the current buffer". >> >> These five places probably need to be adapted to handle labeled >> narrowings correctly. If you agree with that, I'll write a patch to >> that effect. > > I'm not sure what you mean by "adapt to". Please tell more. > Fwiden in the functions above (which are AFAICS the only places in Emacs where Fwiden is called) is not prepared to the possibility of them being called inside a labeled narrowing, either one installed by the long lines code, or another one. Basically we need to use a variant of reset_outermost_narrowings (for the current buffer only) where we use record_unwind_protect (save_restriction_restore, save_restriction_save ());