From: Dmitry Gutov <dgutov@yandex.ru>
To: Drew Adams <drew.adams@oracle.com>,
Ryan Thompson <rct@thompsonclan.org>,
27158@debbugs.gnu.org
Subject: bug#27158: 25.2; Eliminating old usage of completing-read from built-in files
Date: Thu, 1 Jun 2017 23:53:28 +0300 [thread overview]
Message-ID: <0edc70e8-2b43-887d-1c5d-022eb430dd44@yandex.ru> (raw)
In-Reply-To: <bdc25c2e-5903-4dd2-a5b6-b5080677eee2@default>
On 6/1/17 5:57 PM, Drew Adams wrote:
> `completing-read-function' needs to have the same signature
> as `completing-read'.
>
> I am the one who requested `completing-read-function' and
> pushed to have it added to Emacs.
Thank you for that, but that doesn't mean it can't ever change.
> Its purpose is to easily
> let you change the _complete_ behavior of `completing-read',
> just by binding a variable.
Indeed.
> That requires passing it exactly the same arguments, to do
> as it pleases with them.
No, it does not require that.
> If, as in your case, it wants to
> act as if DEF were in fact `(or DEF "")', it can do that.
It _already is_, according to the contract of completing-read. And that
is the problem.
> Changing the signature of `completing-read-function' in the
> way you suggest makes all uses of `completing-read-function'
> follow the path you've outlined for `ido-ubiquitous-mode'.
Nope. Like I said, the behavior of completing-read will not change.
completing-read-function will change, but just a little. With the new
benefit that it's now aware of whether the caller wants to have a
default value or not.
> And no need. You don't need that, to make your mode do
> what you want. If you disagree, please show da codez: a
> simple example that doesn't work and for which you see no
> possible solution.
The code is pointless here. Just read this again:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27158#32
>> Obviously not. Also not when it's not installed, in case you
>> were wondering.
>
> In that case, it's obvious that you can do whatever you need
> inside the mode.
Nope.
> There is a reason for the DEF argument, a reason for it to
> be optional, and a reason for its default value to be "".
> All of which I've gone over.
Err, no. You didn't.
> DEF was even expanded several releases ago, to allow a
> value that is a list of default values. Those too likely
> don't fit your narrow use case. Default values are
> intentionally not completion candidates. And yes, in
> general they are useful, even if not for your use case
> of `completing-read'.
Nobody is taking DEF away.
next prev parent reply other threads:[~2017-06-01 20:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 4:41 bug#27158: 25.2; Eliminating old usage of completing-read from built-in files Ryan
2017-05-31 5:52 ` Drew Adams
2017-05-31 11:45 ` Ryan Thompson
2017-05-31 14:51 ` Drew Adams
2017-05-31 12:23 ` Dmitry Gutov
2017-05-31 14:51 ` Drew Adams
2017-05-31 14:59 ` Dmitry Gutov
2017-05-31 15:19 ` Drew Adams
2017-05-31 15:44 ` Ryan Thompson
2017-05-31 22:41 ` Dmitry Gutov
2017-05-31 23:16 ` Drew Adams
2017-05-31 23:54 ` Dmitry Gutov
2017-06-01 2:23 ` Drew Adams
2017-06-01 9:27 ` Dmitry Gutov
2017-06-01 14:57 ` Drew Adams
2017-06-01 20:53 ` Dmitry Gutov [this message]
2017-06-01 21:04 ` Ryan Thompson
2017-06-05 23:01 ` Dmitry Gutov
2017-06-06 0:06 ` Ryan Thompson
2017-06-06 0:09 ` Dmitry Gutov
2017-05-31 21:20 ` Dmitry Gutov
2020-08-24 14:58 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0edc70e8-2b43-887d-1c5d-022eb430dd44@yandex.ru \
--to=dgutov@yandex.ru \
--cc=27158@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=rct@thompsonclan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).