unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dmitry@gutov.dev>
To: Eli Zaretskii <eliz@gnu.org>
Cc: ankit@argp.in, 69562@debbugs.gnu.org
Subject: bug#69562: 29.2.50; go-ts-mode does not handle comments with fill-paragraph
Date: Tue, 5 Mar 2024 20:59:38 +0200	[thread overview]
Message-ID: <0eca8c60-cf13-4800-b18c-0fa6218dff89@gutov.dev> (raw)
In-Reply-To: <86o7bsllvu.fsf@gnu.org>

On 05/03/2024 17:49, Eli Zaretskii wrote:
>> That's odd: here it becomes
>>
>>     // Sample is a sample function with a very long comment. Sample is a
>>     // new details added to the comment sample function with a very long
>>     // comment. Sample is a sample function with a very long
>>     // comment. Sample is a sample function with a very long comment.
>>     func Sample() {
> Could it be that you two use different versions of the grammar
> library?

I expect that it doesn't matter: we're not talking about a situation 
where some queries fail or some syntax errors.

go-ts-mode also doesn't set syntax-propertize-function (which is a 
mechanism of translating the grammar's syntax into something our generic 
code would look up. So it should only be affected by the settings we 
make in Lisp: the buffer syntax table and whatever other variables 
affect how filling happens.

Anyway, I've installed the latest version of the Go grammar now and 
don't see a change.





  reply	other threads:[~2024-03-05 18:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05  8:41 bug#69562: 29.2.50; go-ts-mode does not handle comments with fill-paragraph Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-05 12:44 ` Eli Zaretskii
2024-03-05 13:03 ` Dmitry Gutov
     [not found]   ` <CAN7zea2d+Ku3YG6hw9xw1xKRkkomf7pji8JArZskHbJ2CwZOGw@mail.gmail.com>
2024-03-05 14:49     ` Dmitry Gutov
2024-03-05 15:49       ` Eli Zaretskii
2024-03-05 18:59         ` Dmitry Gutov [this message]
2024-03-06  5:22       ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-07  1:57         ` Dmitry Gutov
2024-03-07  8:58           ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-07  9:38             ` Eli Zaretskii
2024-03-07 10:18               ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]               ` <CAN7zea13N9xgVLzQAFUiZiiVajB1vzQmh=vbaWOW97VKvL71Ww@mail.gmail.com>
2024-03-07 10:55                 ` Eli Zaretskii
2024-03-07 11:13                   ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-07 14:15                     ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0eca8c60-cf13-4800-b18c-0fa6218dff89@gutov.dev \
    --to=dmitry@gutov.dev \
    --cc=69562@debbugs.gnu.org \
    --cc=ankit@argp.in \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).