From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Martin Jerabek Newsgroups: gmane.emacs.bugs Subject: bug#58718: Acknowledgement (Incorrect regex in nXML URI check) Date: Sun, 23 Oct 2022 12:46:18 +0200 Message-ID: <0eae90fa905f352731ef7e26ba02d390b4f9329e.camel@fastmail.fm> References: <938384610b8c5411944afa7fae860f15e2e40eae.camel@fastmail.fm> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-R0KfpTIzlzELMPFZuuw5" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20161"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) To: 58718@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 24 06:52:46 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ompS5-0004rK-FZ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Oct 2022 06:52:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ommao-0007vO-FK for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Oct 2022 21:49:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ombb4-0007aN-Gy for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2022 10:05:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ombb4-0008LD-7m for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2022 10:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ombb3-0002fd-V5 for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2022 10:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Martin Jerabek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Oct 2022 14:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58718 X-GNU-PR-Package: emacs Original-Received: via spool by 58718-submit@debbugs.gnu.org id=B58718.166653389310247 (code B ref 58718); Sun, 23 Oct 2022 14:05:01 +0000 Original-Received: (at 58718) by debbugs.gnu.org; 23 Oct 2022 14:04:53 +0000 Original-Received: from localhost ([127.0.0.1]:46313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ombat-0002fA-Vq for submit@debbugs.gnu.org; Sun, 23 Oct 2022 10:04:53 -0400 Original-Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:46255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omYUt-0007No-5W for 58718@debbugs.gnu.org; Sun, 23 Oct 2022 06:46:31 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 366A03200313 for <58718@debbugs.gnu.org>; Sun, 23 Oct 2022 06:46:21 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 23 Oct 2022 06:46:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailservice.ms; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1666521980; x=1666608380; bh=jAfXnZc+jH Nc/IjmKenf32Sq5eQEHmnoK+ePQRfnPZA=; b=dPm1BleFV3oCovuZ1ddFahmKAq FMUQIHoYk9leLhsnyzUa2zZvep4t1ou2ACpnQ4VOHUEpLF9/pv0oGIxvrwlZKDHL GMj2x3uUwrYdbJcl4IlzII027gOM9c8wR+VwHCEMspacht4Nzuk++k76d6ATlLnd IolO/m/bdVlM/nB4AxGyUeiNyEhSqRXPJ0zKZt3qnWLJReJD7gM6XwfAPcyyhjbn j8Wx5dpCZHEQXPRFKHO7knsoN71CPxVYkf7luCo7sSA60+jdVqsmkWdhYNOuH9Cx dhxr2+9A1elUs8Hh5nw/ZWay3rvA7ggwK25Y3gF52i0YHUuAHl8aqSl246sA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1666521980; x=1666608380; bh=jAfXnZc+jHNc/IjmKenf32Sq5eQE HmnoK+ePQRfnPZA=; b=lxuSzqjwWLElxL8FMIy1Lto91BsJk+FwJbLQ96CkiCdR abTrLNmPpMhllyCuTNML3CpxA1CU1yGvhENFFxMClAw2DsrbGoy5HVYIFbDhQPdO kb4VJmtgpv0pTU5nj7d/7L/sttSAPr/fJIvbHPg6rnV/JT+9LfCORRg+tNzvZhRv r0HMP9Env3CuMe0JYB/t8i8cFyg/4geWTyVULBOCNCDQH4QeB/KS/P1EVy7ubgxw iKfcRuw7DrN076dur6BxsRSXCnwv0a+zSczpj++cNixbOcs7RsPFaj6pqQ9DAr5g k5ax5dWL601zvPnlDyumhXXN5yurOaiu5hHi3MTHaA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgedtvddgfeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkuffhvfffjghftggfggesmhdtre ertderjeenucfhrhhomhepofgrrhhtihhnucflvghrrggsvghkuceoohhmsehmrghilhhs vghrvhhitggvrdhmsheqnecuggftrfgrthhtvghrnheplefggeduvedtueffkedvkedvgf euueevudefgffhteehheekkeejteeuueevtdefnecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomhepohhmsehmrghilhhsvghrvhhitggvrdhmsh X-ME-Proxy: Feedback-ID: i49c94607:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA for <58718@debbugs.gnu.org>; Sun, 23 Oct 2022 06:46:20 -0400 (EDT) In-Reply-To: X-Mailman-Approved-At: Sun, 23 Oct 2022 10:04:50 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:246081 Archived-At: --=-R0KfpTIzlzELMPFZuuw5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable It turned out that my patch was incomplete. Fixing the bug in rng-uri-file-name-1 revealed another bug in rng-uri-unescape-unibyte. The anonymous function passed to replace-regexp-in-string returned a number (e.g. 32 for space) but replace-regexp-in-string expected a string as the return value. I therefore added a call to "string" to convert the number back to a string (e.g. " "). With this fix I was finally able to use a RELAX-NG schema file in a path containing spaces. I made the same fix in rng-uri-unescape-unibyte-match because it was also obviously wrong (regexp-quote expects a string). However, it would be good if someone more familiar with this code (and Lisp in general) could check all the other occurrences of replace-regexp-in-string to make sure they do not contain the same bug. Find attached the expanded patch. --=-R0KfpTIzlzELMPFZuuw5 Content-Disposition: attachment; filename="rng-uri.patch" Content-Type: text/x-patch; name="rng-uri.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvbnhtbC9ybmctdXJpLmVsIGIvbGlzcC9ueG1sL3JuZy11cmkuZWwK aW5kZXggNzdmZWQ4YzMyZC4uMjQyMjM4ZTBkMSAxMDA2NDQKLS0tIGEvbGlzcC9ueG1sL3JuZy11 cmkuZWwKKysrIGIvbGlzcC9ueG1sL3JuZy11cmkuZWwKQEAgLTY4LDcgKzY4LDcgQEAgU2lnbmFs IGFuIGVycm9yIGlmIFVSSSBpcyBub3QgYSB2YWxpZCBmaWxlIFVSTC4iCiAKIDs7IHBhdHRlcm4g aXMgZWl0aGVyIG5pbCBvciBtYXRjaCBvciByZXBsYWNlCiAoZGVmdW4gcm5nLXVyaS1maWxlLW5h bWUtMSAodXJpIHBhdHRlcm4pCi0gICh1bmxlc3MgKHN0cmluZy1tYXRjaCAiXFxgXFwoPzpbXiVd XFx8JVtbOnhkaWdpdDpdXXsyfVxcKSpcXCciIHVyaSkKKyAgKHVubGVzcyAoc3RyaW5nLW1hdGNo ICJcXGBcXCg/OlteJV1cXHwlW1s6eGRpZ2l0Ol1dXFx7MlxcfVxcKSpcXCciIHVyaSkKICAgICAo cm5nLXVyaS1lcnJvciAiQmFkIGVzY2FwZXMgaW4gVVJJIGAlcyciIHVyaSkpCiAgIChzZXRxIHVy aSAocm5nLXVyaS11bmVzY2FwZS1tdWx0aWJ5dGUgdXJpKSkKICAgKGxldCogKChjb21wb25lbnRz CkBAIC0zMTIsNyArMzEyLDcgQEAgQm90aCBGVUxMIGFuZCBCQVNFIG11c3QgYmUgYWJzb2x1dGUg VVJJcy4iCiAoZGVmdW4gcm5nLXVyaS11bmVzY2FwZS11bmlieXRlIChzdHIpCiAgIChyZXBsYWNl LXJlZ2V4cC1pbi1zdHJpbmcgIiVbMC03XVtbOnhkaWdpdDpdXSIKIAkJCSAgICAobGFtYmRhICho KQotCQkJICAgICAgKHN0cmluZy10by1udW1iZXIgKHN1YnN0cmluZyBoIDEpIDE2KSkKKwkJCSAg ICAgIChzdHJpbmcgKHN0cmluZy10by1udW1iZXIgKHN1YnN0cmluZyBoIDEpIDE2KSkpCiAJCQkg ICAgc3RyCiAJCQkgICAgdAogCQkJICAgIHQpKQpAQCAtMzI1LDggKzMyNSw4IEBAIEJvdGggRlVM TCBhbmQgQkFTRSBtdXN0IGJlIGFic29sdXRlIFVSSXMuIgogCQkJCShyZWdleHAtcXVvdGUKIAkJ CQkgKGlmICg9IChsZW5ndGggbWF0Y2gpIDEpCiAJCQkJICAgICBtYXRjaAotCQkJCSAgIChzdHJp bmctdG8tbnVtYmVyIChzdWJzdHJpbmcgbWF0Y2ggMSkKLQkJCQkJCSAgICAgMTYpKSkpKQorCQkJ CSAgIChzdHJpbmcgKHN0cmluZy10by1udW1iZXIgKHN1YnN0cmluZyBtYXRjaCAxKQorCQkJCQkJ ICAgICAxNikpKSkpKQogCQkJICAgIHN0cgogCQkJICAgIHQKIAkJCSAgICB0KSkK --=-R0KfpTIzlzELMPFZuuw5--