From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#64799: [PATCH] Add 'project-prompt-key' face Date: Tue, 25 Jul 2023 04:56:27 +0300 Message-ID: <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21354"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: 64799@debbugs.gnu.org To: Protesilaos Stavrou , Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 25 03:57:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qO7In-0005JG-Ef for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Jul 2023 03:57:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qO7IP-00073A-UT; Mon, 24 Jul 2023 21:57:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qO7IO-000732-91 for bug-gnu-emacs@gnu.org; Mon, 24 Jul 2023 21:57:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qO7IN-0002ym-Ev for bug-gnu-emacs@gnu.org; Mon, 24 Jul 2023 21:57:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qO7IL-0006Do-Vb for bug-gnu-emacs@gnu.org; Mon, 24 Jul 2023 21:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jul 2023 01:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64799-submit@debbugs.gnu.org id=B64799.169025020223887 (code B ref 64799); Tue, 25 Jul 2023 01:57:01 +0000 Original-Received: (at 64799) by debbugs.gnu.org; 25 Jul 2023 01:56:42 +0000 Original-Received: from localhost ([127.0.0.1]:44407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qO7I1-0006DD-KB for submit@debbugs.gnu.org; Mon, 24 Jul 2023 21:56:41 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:34281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qO7Hw-0006Cw-97 for 64799@debbugs.gnu.org; Mon, 24 Jul 2023 21:56:40 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 10B725C00E8; Mon, 24 Jul 2023 21:56:31 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 24 Jul 2023 21:56:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1690250191; x=1690336591; bh=4Zh6fUPITShMZmDF0E2qsZFP5QA8WDKq7p+ h79sbQJU=; b=VppDbRW7V1yfumO+oZdyyW8LciQEWM28s7kN2XxyQAaP8z7gdnK vW6RgYgYNw5YB2uMggJITNtfIwKL3eVUV5SwxeLzD2/ho3DANUXjkM3bXbM707fy r8jPzJh5qzFx0AT3cnmryLgVZkNjcWGnl26CWgOJiRhXMTxDCNwhrMPA05R4EsnZ Px7vopw2J8i7kdrA6YQ+sptsNLg9Dttx+b+1uOLzmtj7BG+hEidOA2rgFMX2h0pZ vBXM3dzkO+yw02JnSlDPKKXc/qYRQKPfMe+Zj0T7l8KNZ7OHFs6udWkz8xQCInJp KqPbbYx9k/k9qUzOVeo6lXBYftKmkQfmrtw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690250191; x=1690336591; bh=4Zh6fUPITShMZmDF0E2qsZFP5QA8WDKq7p+ h79sbQJU=; b=0GJgdJQbq0n2fOHmSlOnUefV+iStbxWXCE1NnlgP+kQc1bB48nk CH4GXyevRhSaCSEhAyF4byOrFbWYUa5wIpa+Qh2XgkhMI0dGPJaE6gaWlA3R75FX p5LaYiAt8LSHgxYpzHrdvtdTaSTKsmUEiJpkpJk1zMVgs39fmt/5Me0fXz7EnbIM td3ZbDkJ2RfFZ/QUSQhZ/J5gM7LSabArikNykt+4FKyLZUITkFP/rkyuc9D7scRA FXGYwreYLnU/UVxb4+gA9xJtfqZnJUi55Sg5h9WZH75mwOes5J7mviLlw2AyJDsv qCOTe44LgCQrA12fmBt9CBn3kapq+7CRqmg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrheelgdehvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeevledv veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 24 Jul 2023 21:56:29 -0400 (EDT) Content-Language: en-US In-Reply-To: <874jlt7t4f.fsf@protesilaos.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266013 Archived-At: On 24/07/2023 08:53, Protesilaos Stavrou wrote: >> From: Philip Kaludercic >> Date: Sun, 23 Jul 2023 13:59:41 +0000 > >> [... 14 lines elided] > >>>> Does this even need a separate face, or shouldn't `help-key-binding' be >>>> reused directly? >>> >>> That would be my choice, though also with the removal of the square >>> brackets around it. The proposed patch is for backward-compatibility. >> >> Backwards-compatible to what? > > Just so that existing users do not complain. > >> Can someone depend on this specific behaviour? > > No, but the appearance still comes with certain expectations. Plus, > there is this at the top of the file: > > ;; This is a GNU ELPA :core package. Avoid using functionality that > ;; not compatible with the version of Emacs recorded above > > The required Emacs version is 26.1, while that of 'help-key-binding' is > 28.1. Indeed, so if we switch to it in project.el, it will need some polyfill for Emacs 26-27. > Perhaps a user option for the whole 'format' would be better? We can add a user option. But while we could also apply 'face' property on that option's string value, that doesn't seem like a very user-friendly approach toward someone who will want to change the face used (it will require some Lisp knowledge from the user). But a user option to change how the prompt text is constructed -- why not. E.g. one defaulting to "[%s] %s".