From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Maxim Nikulin Newsgroups: gmane.emacs.bugs Subject: bug#55635: `make-decoded-time' incorrectly sets DST to nil, it should be -1 (guess) Date: Sat, 28 May 2022 23:31:43 +0700 Message-ID: <0e506652-fb7d-5707-8247-7747ff1e53b0@gmail.com> References: <940415ce-2e31-ae18-3e16-8fdc54504a67@gmail.com> <87o7zkbif3.fsf@gnus.org> <96e9d729-2e23-5637-3136-ac29e26aa287@cs.ucla.edu> <87r14f8dhw.fsf@gnus.org> <87zgj23pn9.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10504"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Cc: 55635-done@debbugs.gnu.org To: Lars Ingebrigtsen , Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 28 18:32:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuzMW-0002bo-5f for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 May 2022 18:32:24 +0200 Original-Received: from localhost ([::1]:37056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuzMU-0002DZ-1q for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 May 2022 12:32:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuzMA-0002CC-Ja for bug-gnu-emacs@gnu.org; Sat, 28 May 2022 12:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44880) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuzMA-0004BA-Ag for bug-gnu-emacs@gnu.org; Sat, 28 May 2022 12:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nuzMA-0007A3-6m for bug-gnu-emacs@gnu.org; Sat, 28 May 2022 12:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Maxim Nikulin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 May 2022 16:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55635 X-GNU-PR-Package: emacs Original-Received: via spool by 55635-done@debbugs.gnu.org id=D55635.165375551327511 (code D ref 55635); Sat, 28 May 2022 16:32:02 +0000 Original-Received: (at 55635-done) by debbugs.gnu.org; 28 May 2022 16:31:53 +0000 Original-Received: from localhost ([127.0.0.1]:38777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuzM1-00079e-Dq for submit@debbugs.gnu.org; Sat, 28 May 2022 12:31:53 -0400 Original-Received: from mail-lf1-f45.google.com ([209.85.167.45]:35714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuzLz-00079K-BI for 55635-done@debbugs.gnu.org; Sat, 28 May 2022 12:31:51 -0400 Original-Received: by mail-lf1-f45.google.com with SMTP id br17so11037871lfb.2 for <55635-done@debbugs.gnu.org>; Sat, 28 May 2022 09:31:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:in-reply-to :content-transfer-encoding; bh=wx0LbpPfOOWvPMi+bIT7+s52qEwhPsG79HYO7lXyCFM=; b=OB/h7FpajsaXWLXwr9FjgkC3ZxG4NAN1JUsnJsAzPSSM6he3SSEGPKdH2qVeV1Qpia OiubuRfKhBWI+a860y8VqEnWRKV/kPsIeywf0exEivLCRtKivgLtwAqe+O6Tmo5wcaFF Uy8r2vAgbyNGnb2ugEvGcqdsSk6LcirhJkgmtn8fW8qqzZoBdqhsCE208b6rhBtXchrt ezakCR8/LbeLduHCwWNtMVSUY9BOTadeyPuNfZUQqM3kKIAv+lh4AX29UEcJLf0LcDbq U9REWF1n2vF8cTYE3nYZJfeFvDRckujyQpaJSxfZ3D/61RW1aLYfAOs5rmfZQqGRfiWZ FxAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:in-reply-to :content-transfer-encoding; bh=wx0LbpPfOOWvPMi+bIT7+s52qEwhPsG79HYO7lXyCFM=; b=tqo1dCvV4mwETib1DnYOLuDJk3fOKAYjEF+nmpwWlYm3VoL5SvfAkQLXTtTeny1wsK qEY/ZVYyEn4HKsYZ601d7X8e8zo4nVobXkG2euhWbIQP3drEhbEgtQc/A9zehzB7t/4L mJYaRVyUqBRhBRLIpqLPklVvwFD2eTVaeY2EPi2giP81BH4ktm2qGda4MOnU4FBd8rzM ujjEqJAAE1WkmvS2wHMdzWqMxzqRHT9XcNkLK5xrHai+v+9xHdaXcPEnDjOeQ2rtUuoC 8CDiMXUogW2txoyUO9kHEdMd5ZAz/2+ANgIz+yagCXdxwAaC4bpQtJFKwKWbqOupBMru Ec6w== X-Gm-Message-State: AOAM532dH0ZRJu/DPb1UfMb+ZhbIgqxR1cMcl0xruusFi34JbwC8GVAc nUr40wtjyStjlj+e9iA1kgUue/c23JX9k6Wp X-Google-Smtp-Source: ABdhPJxLM5qBX/9YERWRS1nV/1yCHyKjnHd8nit7ca+b67AdSgMoOOlT9qWuBP4vU5xe5GGO4IaA5Q== X-Received: by 2002:a05:6512:32c1:b0:478:6e6c:53a5 with SMTP id f1-20020a05651232c100b004786e6c53a5mr21563036lfg.435.1653755505062; Sat, 28 May 2022 09:31:45 -0700 (PDT) Original-Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id d30-20020ac25ede000000b00477cab3374asm1384046lfq.303.2022.05.28.09.31.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 May 2022 09:31:44 -0700 (PDT) X-Google-Original-From: Maxim Nikulin Content-Language: en-US In-Reply-To: <87zgj23pn9.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233263 Archived-At: On 28/05/2022 17:41, Lars Ingebrigtsen wrote: > Paul Eggert writes: > >> To try to lessen the confusion I installed the attached, which fixes >> the reported bug so I'll close the bug report. Please feel free to >> revert if you see a problem with it (I'm just trying to save time here >> by being bold). > > Thanks; I think that looks like the correct thing here. Thank you, with the committed changes my examples work as I expect. Paul, do you have any comment concerning the last part of the bug report? `decoded-time-add' docstring: > (decoded-time-add (decode-time) (make-decoded-time :month 2)) I think, it is confusing that `make-decoded-time' is used to create timestamps *and* time intervals. They are different types, for example sum of intervals is meaningful (despite may be ambiguous) while there is no point to add timestamps. Daylight saving time and timezone are something alien for intervals. Though I am unsure if it is reasonable to mark intervals by e.g. 'time-interval symbol or to make these types distinct by some other way.