From: martin rudalics <rudalics@gmx.at>
To: Lars Ingebrigtsen <larsi@gnus.org>, Eli Zaretskii <eliz@gnu.org>
Cc: pm@a16n.net, 49997@debbugs.gnu.org
Subject: bug#49997: 27.2; idle-time reset when switching desktop-page
Date: Wed, 18 Aug 2021 10:02:33 +0200 [thread overview]
Message-ID: <0e03c073-2678-5f47-1a92-6a585c8dfe19@gmx.at> (raw)
In-Reply-To: <87a6likc5a.fsf@gnus.org>
[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]
>> The code you show is in keyboard.c, where we interpret the events
>> we've received. To see whether we can distinguish between these
>> events and "real" move-frame events, we need to look in xterm.c, where
>> the events come in from the window-system. Maybe they are different
>> in their raw form?
>
> Ah, I see. Right, this is in handle_one_xevent, where we apparently
> synthesise the MOVE_FRAME_EVENT:
>
> if (!FRAME_TOOLTIP_P (f)
> && (old_left != f->left_pos || old_top != f->top_pos))
> {
> inev.ie.kind = MOVE_FRAME_EVENT;
> XSETFRAME (inev.ie.frame_or_window, f);
> }
> }
>
> So it's purely based on whether the window manager told is that the
> position changed -- which I guess it sort of does? When I move to a
> different virtual desktop, it shows me all the iconified frames, and
> that's probably where this comes from?
>
> This is in:
>
> case ConfigureNotify:
>
> that case in itself is almost 200 lines long...
>
> I've added Martin to the CCs; perhaps he has some insights here.
I can offer the attached trivial patch. Peter, can you try it?
martin
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: move-frame.diff --]
[-- Type: text/x-patch; name="move-frame.diff", Size: 407 bytes --]
diff --git a/src/keyboard.c b/src/keyboard.c
index 34c64b9186..e643d3267b 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -2929,6 +2929,7 @@ read_char (int commandflag, Lisp_Object map,
if (CONSP (c)
&& (EQ (XCAR (c), Qselect_window)
+ || EQ (XCAR (c), Qmove_frame)
|| EQ (XCAR (c), Qfocus_out)
#ifdef HAVE_DBUS
|| EQ (XCAR (c), Qdbus_event)
next prev parent reply other threads:[~2021-08-18 8:02 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 8:42 bug#49997: 27.2; idle-time reset when switching desktop-page Peter Münster
2021-08-11 11:32 ` Lars Ingebrigtsen
2021-08-11 12:00 ` Eli Zaretskii
2021-08-15 14:18 ` Lars Ingebrigtsen
2021-08-15 14:29 ` Eli Zaretskii
2021-08-15 14:36 ` Lars Ingebrigtsen
2021-08-15 14:44 ` Eli Zaretskii
2021-08-15 14:59 ` Lars Ingebrigtsen
2021-08-15 16:17 ` Lars Ingebrigtsen
2021-08-15 16:46 ` Eli Zaretskii
2021-08-15 16:49 ` Eli Zaretskii
2021-08-15 17:12 ` Lars Ingebrigtsen
2021-08-15 17:39 ` Eli Zaretskii
2021-08-15 16:54 ` Eli Zaretskii
2021-08-15 17:03 ` Eli Zaretskii
2021-08-15 17:09 ` Lars Ingebrigtsen
2021-08-18 8:02 ` martin rudalics [this message]
2021-08-18 9:16 ` Peter Münster
2021-08-18 11:36 ` Eli Zaretskii
2021-08-18 14:36 ` Lars Ingebrigtsen
2021-08-20 8:19 ` martin rudalics
2021-08-20 10:43 ` Eli Zaretskii
2021-08-22 8:24 ` martin rudalics
2021-08-22 9:33 ` Eli Zaretskii
2021-08-22 21:41 ` Lars Ingebrigtsen
2021-10-11 9:40 ` Lars Ingebrigtsen
2021-10-11 11:11 ` martin rudalics
2021-10-11 11:20 ` Lars Ingebrigtsen
2021-10-12 8:11 ` martin rudalics
2021-10-11 11:33 ` Peter Münster
2021-10-12 8:11 ` martin rudalics
2021-08-15 20:02 ` Peter Münster
2021-08-15 20:16 ` Lars Ingebrigtsen
2021-08-16 7:22 ` Peter Münster
2021-08-16 11:43 ` Lars Ingebrigtsen
2021-08-16 11:54 ` Eli Zaretskii
2021-08-16 15:51 ` Peter Münster
2021-08-16 15:55 ` Eli Zaretskii
2021-08-16 16:42 ` Peter Münster
2021-08-16 16:49 ` Eli Zaretskii
2021-08-16 17:10 ` Peter Münster
2021-08-16 17:21 ` Eli Zaretskii
2021-08-16 17:47 ` Peter Münster
2021-08-16 18:08 ` Eli Zaretskii
2021-08-16 19:54 ` Peter Münster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e03c073-2678-5f47-1a92-6a585c8dfe19@gmx.at \
--to=rudalics@gmx.at \
--cc=49997@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=pm@a16n.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).