From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#63828: 29.0.90; project-query-replace-regexp tries to find-and-replace in binary files Date: Sat, 3 Jun 2023 04:47:02 +0300 Message-ID: <0d8df374-dcb7-0dd7-f14c-11713ede2bc8@gutov.dev> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23352"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 To: Spencer Baugh , 63828@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 03 03:48:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5GNO-0005rA-VD for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Jun 2023 03:48:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5GNA-0005FI-BG; Fri, 02 Jun 2023 21:48:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5GN8-0005F4-44 for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2023 21:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5GN7-00025Y-Rp for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2023 21:48:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q5GN7-0006ri-O7 for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2023 21:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Jun 2023 01:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63828 X-GNU-PR-Package: emacs Original-Received: via spool by 63828-submit@debbugs.gnu.org id=B63828.168575683626197 (code B ref 63828); Sat, 03 Jun 2023 01:48:01 +0000 Original-Received: (at 63828) by debbugs.gnu.org; 3 Jun 2023 01:47:16 +0000 Original-Received: from localhost ([127.0.0.1]:41099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5GMN-0006oS-Od for submit@debbugs.gnu.org; Fri, 02 Jun 2023 21:47:16 -0400 Original-Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:44699) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5GMJ-0006oB-H5 for 63828@debbugs.gnu.org; Fri, 02 Jun 2023 21:47:14 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id E1E5F3200961; Fri, 2 Jun 2023 21:47:05 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 02 Jun 2023 21:47:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1685756825; x=1685843225; bh=KAz1zCsEvYK7qZ9Hj8b6rkhmkRQCLFBk+ke VTomMh+g=; b=cAj6ghOJTFIw88xPQ7tmg8eOTDiHRsf57KAZlLTLl2YA0ERn2Qk UOgxoweDa3+3C/dJ+BP+yInpopLi5a0Z9jGca8ZkbdcwbX1bCnkY2TheCBzkZjzv iBxP9PGtp4rikvTst1akYKanUFUqYS5ovrr//l+hPG1afAie39FirYt5e+/y8FAb k+RrnKaTVvzj4lCJn0ETbYMIidtQrKK9oNkWD7IvCh4cx567zqr0mv6XI0FtlyBQ SvOis3ieNkGTn0LKmek28F3m4snkemBXAsbNKoHsRdUQqc924HrlAXSK2jd+VjXF 4f11y/Oj92rwDqkl9zAwCNbpCMQgHMc37eQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1685756825; x= 1685843225; bh=KAz1zCsEvYK7qZ9Hj8b6rkhmkRQCLFBk+keVTomMh+g=; b=F /4Ta26y6H20qzlTcGYzlBLYFqElvZ3VF0AeDsZ8CWOyRLJOD2yhJ58y6k58+0iN/ pgliwnK23ZaISj3clOkyU33mXksNi5Naj860oLUFR3SvjJGPeLnhJZ9mxNQ7zuyI uWsK8mMGRJr9bEOP1csMbYrQhuD5ut126Wlbna/RXuPNf6uifUSV/0je8CoHGlv1 p2fP2vTRKIT61EWXIprI12KO7Zqs1+jTI+EJ22UlJMiKtvWMdicrdlgfccJyi1UV Zd0OsDAsYhnbd1ntMAHb6mwtmDTyX3u0gcuCkKBFxQrWMv9E97HC0s/1pOSrZvtK WHpSLxvBUU9hur0P8oC6g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeelgedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeghedthedujeeiteeutddtjeekheejteeukeehffdutdejuedvfeevueeviedu udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Jun 2023 21:47:04 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262793 Archived-At: On 01/06/2023 23:16, Spencer Baugh wrote: > 1. emacs -Q > 2. Open a git repository which has some binary files committed, or any > other project that has binary files. > 3. C-x p r foo bar > 4. query-replace will enter the binary files > > Perhaps it should not do this? Perhaps fileloop-initialize-replace > should skip binary files? Perhaps by some customization? It would be useful if you compare to what project-find-regexp does in such project: does it produce the matches in said binary files? If it behaves better (from your POV), one solution could be to pre-filter the list of project files using the same search, before passing them to project-query-replace-regexp. It can have benefits in performance as well. (BTW JFYI, you can press 'r' inside the project-find-regexp output buffer instead of using 'project-query-replace-regexp'.)