From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#59347: 29.0.50; `:family` face setting ignored Date: Tue, 22 Nov 2022 13:38:19 +0000 Message-ID: <0d1ea3007f532a493429@heytings.org> References: <83cz9j9zyu.fsf@gnu.org> <838rk77yfo.fsf@gnu.org> <834juu9aya.fsf@gnu.org> <7cc9e03786024fc72f3b@heytings.org> <83a64l65ai.fsf@gnu.org> <7cc9e0378678a092e6ee@heytings.org> <835yf962q4.fsf@gnu.org> <7cc9e03786754c9e0aaf@heytings.org> <83zgcl4jra.fsf@gnu.org> <7cc9e03786c281cffdd4@heytings.org> <83tu2t4ie9.fsf@gnu.org> <7cc9e03786e324ff82ef@heytings.org> <83bkp04gjl.fsf@gnu.org> <83leo42vm9.fsf@gnu.org> <0d1ea3007fd94b7ae0b1@heytings.org> <83r0xv1649.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17361"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , 59347@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 22 14:39:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxTUn-0004II-HY for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Nov 2022 14:39:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxTUO-0004Z4-K6; Tue, 22 Nov 2022 08:39:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxTUN-0004Y6-27 for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 08:39:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxTUM-00044t-Po for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 08:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxTUM-0000y3-LR for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 08:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Nov 2022 13:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59347 X-GNU-PR-Package: emacs Original-Received: via spool by 59347-submit@debbugs.gnu.org id=B59347.16691243043666 (code B ref 59347); Tue, 22 Nov 2022 13:39:02 +0000 Original-Received: (at 59347) by debbugs.gnu.org; 22 Nov 2022 13:38:24 +0000 Original-Received: from localhost ([127.0.0.1]:50233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxTTk-0000x4-4q for submit@debbugs.gnu.org; Tue, 22 Nov 2022 08:38:24 -0500 Original-Received: from heytings.org ([95.142.160.155]:54442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxTTi-0000ww-6q for 59347@debbugs.gnu.org; Tue, 22 Nov 2022 08:38:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1669124300; bh=e6mqSQfp0YgZ2sc+pAmgWRRaRczPueFqRSh1hbvbxtw=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=Y/7ROT8FaaC0EmYfxess68dabjsoPHKqIXo1fDiEUtZPx0BbbgC5xFNgGxNBkIBNs xINqCKJaIMQhrOUGTRNXufOHU5QhUh+KmYD7stLyf75unSFhd54FewXPxHUiIhvwxG m+xgvJjLKmHuviwaQwiOMcEisSScFhLKI9HcmloMSldfgHq15z451vW2WA5235cSiq XM2xxn1Lo1APU1/raJfzxziTQ8nFWFFUKzJpkHN+OQeMpJ32/DPHL/d52X1+kuFUYg tuBzeH7FYn/CGHrNF9rq2HWfXh6qUlNwxQAIHYKhFnc+O49JnjKtg6Eun7EJiws0DR C45ygHywNetVA== In-Reply-To: <83r0xv1649.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248636 Archived-At: > > Whereas with your proposal, it will start from a "clean slate" every > time and will need to examine many (if not all) of the fonts on the > system to be sure score-only matches will find the best candidate. > That's not what it does, no. The loop in font_find_for_lface limits the number of fonts that are considered to some foundry, family, registry and additional style, and only considers more fonts if no suitable fonts have been found. > > Also, font_score only scores the numerical attributes, so how do we > assess the "score" of matches for :family or :adstyle? > That's the purpose of the loop at the end of font_find_for_lface. It starts with a specific spec and gradually makes it less specific if necessary (that is, if no suitable font has been found with a more specific spec).