From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#44611: Prefix arg for xref-goto-xref Date: Mon, 28 Dec 2020 02:54:11 +0200 Message-ID: <0ccddef8-387e-e8cc-591b-61487aef4186@yandex.ru> References: <87k0up68e4.fsf@mail.linkov.net> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> <83k0t7ndbs.fsf@gnu.org> <87wnx6z1gs.fsf@mail.linkov.net> <83a6u2nm8o.fsf@gnu.org> <87h7o7bfoe.fsf@mail.linkov.net> <83a6tzkt3g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15269"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: joaotavora@gmail.com, 44611@debbugs.gnu.org To: Eli Zaretskii , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 28 01:55:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ktgoZ-0003pF-Ns for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Dec 2020 01:55:11 +0100 Original-Received: from localhost ([::1]:33298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktgoY-0002zr-Ph for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Dec 2020 19:55:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58282) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktgoQ-0002ye-Ay for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2020 19:55:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50585) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ktgoQ-0008Aw-3P for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2020 19:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ktgoQ-0005F8-1J for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2020 19:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Dec 2020 00:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44611 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 44611-submit@debbugs.gnu.org id=B44611.160911686120098 (code B ref 44611); Mon, 28 Dec 2020 00:55:01 +0000 Original-Received: (at 44611) by debbugs.gnu.org; 28 Dec 2020 00:54:21 +0000 Original-Received: from localhost ([127.0.0.1]:33898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktgnl-0005E6-I1 for submit@debbugs.gnu.org; Sun, 27 Dec 2020 19:54:21 -0500 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:40557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktgnk-0005Du-7b for 44611@debbugs.gnu.org; Sun, 27 Dec 2020 19:54:20 -0500 Original-Received: by mail-wr1-f45.google.com with SMTP id 91so10023893wrj.7 for <44611@debbugs.gnu.org>; Sun, 27 Dec 2020 16:54:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BVEyhzoQ2uea4Y5a44Wl7XH3HQ3czcuQdiYuBaeHNcg=; b=pnl3xASRsjDMgUiVW8VPd5pprDuE8JDowVKlqNZ1fP1uRiRweErq90xfT6IuZ8WtLB XrseQCSffx9BoHESom+UCw3xdntXyX87qS4azxPsA8Qwn4h0uHw2VYD3vD9XegEBuMbU PSVeupXjrdC3h1uNChobQXusAz+L4yzKRaUPL90r0UgEIcGcWC4S+/ALgHrnFwVpPDcw DtNIdYB+PVh2h4WiKpwSVKMfi/7seu2DUiSU86i/eDsjAeQ3pNr7mBET8udPjp6JTf6q akVryZvtsAsrWPu3y3a9HHnIe9OXGjRwwm9ZI8tc7VmKtfxK706Aax0ylIgvYUcoTRDd W2pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BVEyhzoQ2uea4Y5a44Wl7XH3HQ3czcuQdiYuBaeHNcg=; b=ZmoBL09fGn2JYGy1ueuBl7Z2bra8JowysvKFn0Glhqwuh+Br8+NWBXa67EpXh/6VcZ 21SERMbc6R7kYwx1MHYO2uMfzG8hrNqCJOJ6vxsQiZeFmOkSC1auHGXpE0cQcE70aUm7 /wxcyLmQqmuv8vRfHfcqKXpzypeL5eSEM1CBDNIrqqxfUZWBqJkzzHbpS1mktQekVa3D eQ1L0bLpVLe2JW4d6YigO57+P2uM5dXuGxJo792naOKHjrm94m2Rp+phGW+mrfN39Zni BIjD/UHiQA41GDEhzJS5U8zxS5dkBX2P/WEo/PfkB6/19gH4W/oeeripBhfoCYOSpltB +HeA== X-Gm-Message-State: AOAM531gRiQ2+5vvORFtxag79eXOsD5H2jzAMr0Rr821K8S22i9RsWc5 CQ2TZ87lYTospwGNZ43SBvk5IvlpUoA4UA== X-Google-Smtp-Source: ABdhPJx7BWdG2DP/FWtNKfIzwd+q7HMHBTnLsYbENW+/ApzPCzhyuWDB4+dp+hTmn40461VqERE1hg== X-Received: by 2002:adf:e80d:: with SMTP id o13mr48843814wrm.293.1609116854042; Sun, 27 Dec 2020 16:54:14 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id z3sm56022635wrn.59.2020.12.27.16.54.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Dec 2020 16:54:13 -0800 (PST) In-Reply-To: <83a6tzkt3g.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196838 Archived-At: On 27.12.2020 20:21, Eli Zaretskii wrote: >>> This works both ways: if you want TAB to do something other than its >>> default, you can rebind it for you, right? >> This is not about my personal preferences. > Your original explanation of the rationale was that you always press > TAB because you are used to it in Grep buffers. Avoiding unnecessary ad-hoc differences is not just about any personal preference. >>> That contradicts what Dmitry said: that the current Xref UI moves away >>> of the completion UI, and towards compilation-mode and grep-mode. >>> There, deleting the window with C-j will look odd, I think. >> There are two modes: xref-show-xrefs and xref-show-defs. >> xref-show-xrefs is similar to grep, whereas xref-show-defs >> resembles the Completion UI where C-j makes sense. > AFAIU, Dmitry didn't like the proposal to have different bindings in > these two modes. Two buffers that look exactly the same shouldn't behave differently. I think it's just basic usability. What we could do instead, is change the default value of xref-show-xrefs-function to use some new function that would use a new major mode with the (slightly) new bindings which you have discussed with Juri. And *also* change the default value of xref-show-definitions-function to one of the alternative functions, which already behave in some notably different way than xref--show-xref-buffer. I'm not sure what we would buy with such a combination, however, given that it will create an bigger difference in behavior than simply changing a key binding (*). But the latter change in the default seems to be a Good Thing either way. Maybe we should put it to a vote. (*) I guess you might like that the user could customize xref-show-definitions-function back to a value where TAB behaves like it did in Emacs 27? Although they could change the key binding back just as well with a couple of line of Emacs Lisp, one can't do that via Customize.