* bug#19232: 25.0.50; ring.el: why not autoload `ring-member' etc.?
@ 2014-11-30 19:18 Drew Adams
2014-12-01 3:59 ` Stefan Monnier
0 siblings, 1 reply; 2+ messages in thread
From: Drew Adams @ 2014-11-30 19:18 UTC (permalink / raw)
To: 19232
Subject line says it all. Why make users `require' ring.el for such
functions, or autoload them themselves? Do what you do now for `ringp'
and `make-ring' for other functions as well, such as `ring-insert',
`ring-member', and `ring-next'. This is a utility library.
In GNU Emacs 25.0.50.1 (i686-pc-mingw32)
of 2014-10-20 on LEG570
Bzr revision: 118168 rgm@gnu.org-20141020195941-icp42t8ttcnud09g
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
`configure --enable-checking=yes,glyphs CPPFLAGS=-DGLYPH_DEBUG=1'
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#19232: 25.0.50; ring.el: why not autoload `ring-member' etc.?
2014-11-30 19:18 bug#19232: 25.0.50; ring.el: why not autoload `ring-member' etc.? Drew Adams
@ 2014-12-01 3:59 ` Stefan Monnier
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2014-12-01 3:59 UTC (permalink / raw)
To: Drew Adams; +Cc: 19232
tags 19232 notabug
thanks
> Subject line says it all. Why make users `require' ring.el for such
> functions, or autoload them themselves? Do what you do now for `ringp'
> and `make-ring' for other functions as well, such as `ring-insert',
> `ring-member', and `ring-next'. This is a utility library.
I think the error is to autoload ring-p and make-ring. Of course it's
a bit late to fix it, but that's no reason to add many more autoloads.
Just (require 'ring) like everyone else if you use functions from that
library.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-01 3:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-30 19:18 bug#19232: 25.0.50; ring.el: why not autoload `ring-member' etc.? Drew Adams
2014-12-01 3:59 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).