From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#47286: 28.0.50; [PATCH] Replace "(default %s)" with 'format-prompt' Date: Mon, 22 Mar 2021 02:48:56 +0200 Message-ID: <0c74e9b8-1100-30a4-f229-81c859a8ee2d@yandex.ru> References: <87o8fc1p1q.fsf@gmail.com> <2454249f-5987-8f04-a58e-0596f572bb0e@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36119"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 To: Gabriel , 47286@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 22 01:50:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lO8lm-0009J6-1j for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Mar 2021 01:50:10 +0100 Original-Received: from localhost ([::1]:42638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lO8ll-0007Jm-3k for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Mar 2021 20:50:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lO8le-0007Jf-Ok for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 20:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44187) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lO8le-0000Cz-HG for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 20:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lO8le-00079P-Eh for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 20:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Mar 2021 00:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47286 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47286-submit@debbugs.gnu.org id=B47286.161637414827406 (code B ref 47286); Mon, 22 Mar 2021 00:50:02 +0000 Original-Received: (at 47286) by debbugs.gnu.org; 22 Mar 2021 00:49:08 +0000 Original-Received: from localhost ([127.0.0.1]:55733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lO8kl-00077y-SU for submit@debbugs.gnu.org; Sun, 21 Mar 2021 20:49:08 -0400 Original-Received: from mail-wr1-f44.google.com ([209.85.221.44]:34443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lO8kj-00077T-D1 for 47286@debbugs.gnu.org; Sun, 21 Mar 2021 20:49:06 -0400 Original-Received: by mail-wr1-f44.google.com with SMTP id j7so14929132wrd.1 for <47286@debbugs.gnu.org>; Sun, 21 Mar 2021 17:49:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fVsqWli98bTFMVKVzxoPo8CFzuF8EL0TTgl9s3UiUpk=; b=NYIY7XEyGtHf5eTiPNEnT+drZxRS7kv/Rf46tbnVXYvpAyEuGqHbCyWmNCITD12vqg 7WUFcM6Kv5DHU0G8Mskw7MNN2q9UIfjfbAXtkZKQiHGVNYqwvjcwdNQt9KzUGdemPhKY ubU8+hGDp65t2ltqlbM+IQtxhBkMOF0De7qDmoC7UW08iRDV1dZHKACG0eYEXIF/41JB UEOgbQWxC0/W7yweExs7tS8x+6vq4pAIskpGkw7p2NupLvxJoYpWE7USWZM4s8/vgQPX dri8oFWom/0ohOz3YN0ZbmeSYBBbuhOK7wZwe24FJs0usYwI1l7QqSlq5rgob19eKv70 JOaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fVsqWli98bTFMVKVzxoPo8CFzuF8EL0TTgl9s3UiUpk=; b=Ap6jTXJNk4g+HAWfuYElnQM0C5bwZNvugX7/G1Qda9tWSYh5neP0zA7ZJL+i35yUwE iPlUxf4gq9zi7WPZbJZ6DUsCeQ++AJ3KUKEN9LdapRVeVXdfYqrJ0gyi4+5lbH+RANj1 7hCAIXNt82Vx6sCbYgFharE+SE1udg7csSEDXhQKxSJKDpbn6uS+NLxuvEStlUpd8liA d5Lvtvm/Cw3qt9VrwnY5bVGopcqmFHD6RUya1RlV7Vq7Oh3DXkOzxzFE6FPE9gWjA8ZR Y5J+A45JmhdtG2TfdCYh5gaR5udNci0ehx8uR+uZ7gSIYkyStTUcw/06w2Yq1L8guRDL HUKw== X-Gm-Message-State: AOAM531KZz+yhfR4/t1qC3nnXD3yGKVLbw7vcfSDP5vDMIwclZrhx0Tg YVaECH+Cxw8gjWoFzqNgwsAyu3Q//aU= X-Google-Smtp-Source: ABdhPJxMJ9Rr+u25FNDuDw2I4HNMEYKU71pXHf6e8MDRLjlvhFg6Z5Z5O+XfOInIPWoaqrYgI64Ujw== X-Received: by 2002:a5d:63c8:: with SMTP id c8mr15263137wrw.299.1616374139511; Sun, 21 Mar 2021 17:48:59 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id b12sm7478646wrf.39.2021.03.21.17.48.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Mar 2021 17:48:58 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202817 Archived-At: On 22.03.2021 02:03, Gabriel wrote: > Dmitry Gutov writes: >> Also note that project--completing-read-strict includes as (string-equal default >> "") check added in 2be537e64. >> >> Perhaps format-prompt could use it as well. > > Do you mean to add a new check to 'format-prompt' to consider an empty > DEFAULT as nil, e.g., to not show it on minibuffer prompt in case the > value of the DEFAULT argument is an empty string ? Yup. > Also, maybe another useful check for 'format-prompt' would remove the > ": " suffix from the PROMPT argument, to avoid displaying something like > "prompt: : ", which could avoid regressions when migrating existing > code. My (weak) preference would be on "no": whether the prompt is showing an extra ":" should be apparent from very brief testing of the code. It's not like it will show up only if DEFAULT is non-nil, for instance. So no need to complicate the implementation.