From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: David Ponce via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74725: 31.0.50; image-scaling-factor is ignored by create-image Date: Fri, 27 Dec 2024 17:11:30 +0100 Message-ID: <0c671511-12e0-4764-91bc-9df5959ce319@orange.fr> References: <2793f551-8715-4679-8f52-b4673dd6802d@orange.fr> <86y10rh26m.fsf@gnu.org> <87plm3ghzw.fsf@yahoo.com> <86frmyhfss.fsf@gnu.org> <87h67eha9b.fsf@yahoo.com> <86plm2fk1l.fsf@gnu.org> <86frmh8kj9.fsf@gnu.org> <87o714pnpq.fsf@yahoo.com> <86a5co6wnv.fsf@gnu.org> Reply-To: David Ponce Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40424"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: Alan Third , Eli Zaretskii , Po Lu , 74725@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 27 17:12:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tRCwj-000AM9-Ie for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Dec 2024 17:12:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRCwX-0008CO-BS; Fri, 27 Dec 2024 11:12:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRCwU-0008Al-Kj for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2024 11:12:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tRCwU-0007aT-28 for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2024 11:12:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=9+7zrtK5+mNIcY9obZfTLjLAA8NqacxvX2ZFkHKa7y8=; b=ZUvhvkKkYVlE98aBBsPAP6dRkqUYljcUG5VhNYQSl5VM0/l0OxOSDG4DTjTd2TVdfA+cv4Ni44pXyKh08lokzrvtIajIc5/YNR9ox8lYBBDdhBMBdGDuYzw637ldGBO0WlFrvPfImTlrLihAuwXhQDhMkSShFIUXKQ+Et22EtRIfu8HW7SpUgqBKAAwQuBcUrzs29oQqSDLaQhV3IPppFN4Ujmx+Rqixxby2HrjN11YdQ1maDykVW1FXmJa4XrlwaVcrDGhKiX9Ugsqa2t8PkMFZ/5eSfEruiPHic4LfnPFhO5J3mktYRiR/WXV/vfU+ZsZEloMLZ+iXqseypKvUCw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tRCwT-0001fD-L3 for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2024 11:12:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: David Ponce Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Dec 2024 16:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74725 X-GNU-PR-Package: emacs Original-Received: via spool by 74725-submit@debbugs.gnu.org id=B74725.17353159006341 (code B ref 74725); Fri, 27 Dec 2024 16:12:01 +0000 Original-Received: (at 74725) by debbugs.gnu.org; 27 Dec 2024 16:11:40 +0000 Original-Received: from localhost ([127.0.0.1]:47314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRCw7-0001eD-OB for submit@debbugs.gnu.org; Fri, 27 Dec 2024 11:11:39 -0500 Original-Received: from smtp-16.smtpout.orange.fr ([80.12.242.16]:37007 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRCw4-0001e3-IP for 74725@debbugs.gnu.org; Fri, 27 Dec 2024 11:11:39 -0500 Original-Received: from [192.168.1.21] ([90.112.40.65]) by smtp.orange.fr with ESMTPA id RCvytS1QHjlXXRCw1t92yC; Fri, 27 Dec 2024 17:11:35 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1735315895; bh=9+7zrtK5+mNIcY9obZfTLjLAA8NqacxvX2ZFkHKa7y8=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=HCMIQrBlAbNwlpy77fnchsIAK97Hj3Cj4iHxmkjUPoCyTa7kTP2PWUMcUIN1HebTl ffO+ifdQFCML1SUWraQegPmGtneOAtYdGjyDiUYp7VWt2ntyRUme7UzBhIGubxhsCR TuJgBR2NUqNNG95zQJx1MFQ6zsw8ADwehaEDITrYOfX+G3Qs38uNPR1J8BFMr7z44J YSm5+La82ctAABo5CSabmqFK4DIvADM3fd8R774rO80lBp+QPfzqc7bPa0FtHLo6+H Jxpd5uZ59Vguy4kDjmMBUwkRhKQ7ZX1jKW4pPBiCU40Wd1zRRU2JJWgwQpFKkVPjWi vN6TT4kKQt05Q== X-ME-Helo: [192.168.1.21] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Fri, 27 Dec 2024 17:11:35 +0100 X-ME-IP: 90.112.40.65 Content-Language: fr, en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297834 Archived-At: On 2024-12-27 13:11, Alan Third wrote: > On Sun, Dec 22, 2024 at 08:48:04AM +0200, Eli Zaretskii wrote: >> Alan, could you please prepare a patch (for the master branch) that >> records the scaling factor in the image cache and rejects a cache hit >> with a different scaling factor? > > Hi Eli, patch attached. > > I named a new function image_compute_scale because most of the other > functions in that file start image_, however I wasn't sure if I should > name it compute_image_scale to mirror compute_image_size. Let me know > if you think I should change it. Hi Alan, FYI, I applied your patch and it fixes the issue for me with the initial examples I provided. Many thanks Alan, and to all of you!