From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas =?UTF-8?Q?R=C3=B6hler?= Newsgroups: gmane.emacs.bugs Subject: bug#29923: [PATCH] Skip writing empty abbrev tables Date: Wed, 19 Sep 2018 08:04:11 +0200 Message-ID: <0c0713fa-e8c7-938b-c2b6-d18dd59b3e5c@easy-emacs.de> References: <87tvmyflla.fsf@gmail.com> <874lemquwr.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1537336892 12867 195.159.176.226 (19 Sep 2018 06:01:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 19 Sep 2018 06:01:32 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 Cc: Allen Li , Noam Postavsky To: 29923@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 19 08:01:28 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2VY8-00033C-Sg for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Sep 2018 08:01:21 +0200 Original-Received: from localhost ([::1]:43805 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2VaF-0001gS-Ff for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Sep 2018 02:03:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2Va0-0001gK-Ek for bug-gnu-emacs@gnu.org; Wed, 19 Sep 2018 02:03:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2VZm-0006OM-Lc for bug-gnu-emacs@gnu.org; Wed, 19 Sep 2018 02:03:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40779) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g2VZm-0006NM-7w for bug-gnu-emacs@gnu.org; Wed, 19 Sep 2018 02:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g2VZm-0003jq-3q for bug-gnu-emacs@gnu.org; Wed, 19 Sep 2018 02:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas =?UTF-8?Q?R=C3=B6hler?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Sep 2018 06:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29923 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.153733696314335 (code B ref -1); Wed, 19 Sep 2018 06:03:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Sep 2018 06:02:43 +0000 Original-Received: from localhost ([127.0.0.1]:45037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2VZS-0003j8-O8 for submit@debbugs.gnu.org; Wed, 19 Sep 2018 02:02:43 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2VZQ-0003it-Gj for submit@debbugs.gnu.org; Wed, 19 Sep 2018 02:02:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2VZK-0005pf-Bh for submit@debbugs.gnu.org; Wed, 19 Sep 2018 02:02:35 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:35405) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g2VZK-0005p4-4d for submit@debbugs.gnu.org; Wed, 19 Sep 2018 02:02:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2VZF-00015T-2d for bug-gnu-emacs@gnu.org; Wed, 19 Sep 2018 02:02:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2VWn-00022B-0C for bug-gnu-emacs@gnu.org; Wed, 19 Sep 2018 02:00:01 -0400 Original-Received: from mout.kundenserver.de ([212.227.17.24]:59995) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g2VWm-0001yK-MU for bug-gnu-emacs@gnu.org; Wed, 19 Sep 2018 01:59:56 -0400 Original-Received: from [192.168.178.35] ([92.78.135.136]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MTiLj-1gEEQe3qJR-00U4zl; Wed, 19 Sep 2018 07:59:46 +0200 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:SlmR92dQqxXrKsLgEFrN8ATPutOfFPhVS3O+qsQf2IifBxRP1rK tu2m+LXqr7m3wYevSG+AWrd4Ztq2zLEr7mInkQoBFaR2qn3Qidy+hWcokRhih6wekjIaZus NKLcORn/mKI9J4St4nfDX5bhzaoAxvR797YkCui9cm6Ez/r1jpSY3BBFUm4LZT8na7/+zex rMzG8Tlf5sMZmEk79FAvg== X-UI-Out-Filterresults: notjunk:1;V01:K0:bcC/HtgMzVE=:RYLm2xw+xNHMhoWOGmhL0X ig8+f/MCINDttf7YO6t4Y/Ej7Y/Z4Q6ow0p6vu5HlNhgaPJy8munWxZxrHWtbyUbGpn7oY6Sc UmOchBPJZt9+sXoa5TdG6v/bVQ36qPpojj2XS+tRyypIaVgJnlJFhBShUSD+L1orqC+St6YqA wMBWTUCVUIX7G9BYjMfWLrKIwwV9yfa7XvE8ccRiwlTYaqC8e1MmCG4K+fJfQ8O0miB/Ng2EN Xh2Z7BxgSCMuXts9/v4Qy4N9cLmHxLP8jvF8vlo+RFsqaRfYpWGchauPyIm2tPISG+TnDhaQH x2762sBH1s/CITH7h/8txAlfNtm21aqPo4xiTq43mBxZkJ766h3NzRmvZcuknFLGBHbpvZ7ga s9no3lDUbVDaX07vHXD7+QwoOT7RT6RordU50i2ptTF5gz1ZnHWX+L7w4IIVmhDhieM5waVOx xVj+1pMxiLzdfsBQM05yD/oCHdn1qh0zqSQbbHFVKIlAKtjKqtLprpwJ/4jWIrqObXhp5Xv0h iz9vsRkezn5aKnUmMsn94bjhAOZPBvSpwxS4nOTNI4842aHqYV2nDGvRP/nDA3yjHQoCjciaG cLezIruFoGcXG54+nCHdKaCiHA5bYI8VPKqQqb35dsEDOB1UblmCtikBD5Rv3NvOwNBi9MTpg QYMxRiAYDbhDY0RFGS/ivsi7CdHerTa3Crpq2Z9FIUGIlWNTSxVqs5bbcQtWVv9GWM6+/XYUC yPLTTzxx3VwrF32w X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150437 Archived-At: On 19.09.2018 04:55, Allen Li wrote: > On Tue, Sep 18, 2018 at 3:53 PM Noam Postavsky wrote: >> >> Allen Li writes: >> >>> The system abbrev omitting worked (if readable is nil); it's >>> implemented in abbrev--write. >>> However, that doesn't allow us to skip writing a table if it only >>> contains system abbrevs; >>> we'll still see a table with abbrevs, write the opening of the >>> define-abbrev-table form, >>> and then realize in abbrev-write that all of the abbrevs are system abbrevs. >> >> Ah, it would be good to have this information in the commit message, as >> the patch is a bit confusing to read otherwise. > > Done. I have also removed the system abbrev check in abbrev--write since > it is redundant now and this is the only place it is called. > AFAIU add-mode-abbrev expect a respective abbrev-table existing. (add-abbrev (if only-global-abbrevs global-abbrev-table (or local-abbrev-table (error "No per-mode abbrev table"))) Will this still work? Cheers, Andreas