From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#66186: "make lisp/eshell/esh-proc-tests" fails intermittently since 7e50861ca7ed3f620fe62ac6572f6e88b3600ece Date: Sun, 24 Sep 2023 22:34:55 -0700 Message-ID: <0bf05269-a8b4-3457-95e1-0c1916f33b22@gmail.com> References: <83fs323ldl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------p8wE9B9QEbu67UvqZq0HGLG3" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5878"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jschmidt4gnu@vodafonemail.de, 66186@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 25 07:36:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkeGc-0001LY-2l for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Sep 2023 07:36:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qkeGG-0006Wf-1I; Mon, 25 Sep 2023 01:36:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkeG7-0006Ut-LB for bug-gnu-emacs@gnu.org; Mon, 25 Sep 2023 01:35:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qkeG6-00038I-DV for bug-gnu-emacs@gnu.org; Mon, 25 Sep 2023 01:35:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qkeGI-0002Ek-5B for bug-gnu-emacs@gnu.org; Mon, 25 Sep 2023 01:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Sep 2023 05:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66186 X-GNU-PR-Package: emacs Original-Received: via spool by 66186-submit@debbugs.gnu.org id=B66186.16956201208541 (code B ref 66186); Mon, 25 Sep 2023 05:36:02 +0000 Original-Received: (at 66186) by debbugs.gnu.org; 25 Sep 2023 05:35:20 +0000 Original-Received: from localhost ([127.0.0.1]:43921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkeFc-0002Dg-AY for submit@debbugs.gnu.org; Mon, 25 Sep 2023 01:35:20 -0400 Original-Received: from mail-ot1-x336.google.com ([2607:f8b0:4864:20::336]:54677) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkeFW-0002DK-3z for 66186@debbugs.gnu.org; Mon, 25 Sep 2023 01:35:19 -0400 Original-Received: by mail-ot1-x336.google.com with SMTP id 46e09a7af769-6c21b2c6868so2819913a34.1 for <66186@debbugs.gnu.org>; Sun, 24 Sep 2023 22:35:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695620096; x=1696224896; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=VjVQ+yaCvZqOZ4MhslNhPmK2Y3HHX1Q1EBvGxtwlXcc=; b=mgEW8F5sDn9a+uvQ9gaz88BYuwkCG9kjyC3jaF/HHSn9Le5girX1CVqwyzR+2x6CZW fBq2L4PWZT3A3Y40zuJP9Si5ilnx8GYYZ4Yee5TcUw0siEY8W4uvGqPpsVkDmqFK6Mjq MHp+axXa0spE69lMg2xWX5MjcVU0XaxM6zvrB0hKdv6Zld7LDP/gjg1aUMXConD1opx6 wmrh/0u4a4g1Vn/JPYv2dbCec2N3oUQ801bgmIa9LCpOTnayH7ZkdEFD1nkQCD6QfNvE O0yf/T7m7mJ77zG8TCM2yzzHouaPgikLNj1t6Wyonp2ZMhai62eopPUkn0Z752aqOL82 knbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695620096; x=1696224896; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VjVQ+yaCvZqOZ4MhslNhPmK2Y3HHX1Q1EBvGxtwlXcc=; b=b1Emv6lQADZYD/rGUMG6PhTHqhFhKmapJ9uzATVIwI7gMo2au/n7jVZ4GD/kxMxykU eFThZjB+DdF5HIXpxT723LOSblN7pqdNCp3TjHxhNCh9OCWtwn/GH9EHWFxRfe7/u1JA q6IXuNJLPvTnMfak+4OKxsUDDhVofWJ8LpAVOftQ6Lzw6m5SvKSRgLWxFwD1kRRtvnaX KGUTYj3crgzVQZFPopaLzMGoW44Fnw8+pn2HpqAmV057gAstAM52i0obb+SjYHmQxTKI VRVGi0j4hIaztcOsTi4cQoMYsi8V7Mzew/zINEFyknqBsVZaTENTTHl5nq2GQ0OcOOPH y03Q== X-Gm-Message-State: AOJu0YzXLtIgTTJncswLXG52dLWDOcxXflYp76bz/y2okRS2lYcJblor IPmd/rhu6dmIzeTPbw2/wbs= X-Google-Smtp-Source: AGHT+IG1oujqzcWjiLiFfuU23p6ippPRtZRmVrn2FgWpvxkZuJyCNQWM/NHPdENr1PfmZkD64f7oaQ== X-Received: by 2002:a05:6830:4d8:b0:6c4:a127:9ff2 with SMTP id s24-20020a05683004d800b006c4a1279ff2mr5969690otd.11.1695620096062; Sun, 24 Sep 2023 22:34:56 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id z186-20020a6333c3000000b00581048ffc13sm2351712pgz.81.2023.09.24.22.34.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Sep 2023 22:34:55 -0700 (PDT) Content-Language: en-US In-Reply-To: <83fs323ldl.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271295 Archived-At: This is a multi-part message in MIME format. --------------p8wE9B9QEbu67UvqZq0HGLG3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/24/2023 9:52 PM, Eli Zaretskii wrote: >> Date: Sun, 24 Sep 2023 16:02:03 -0700 >> From: Jim Porter >> >> However, I don't understand why this would cause an abort though; >> normally, 'process-send-string' should just signal an Elisp error (which >> Eshell then catches and does the right thing with it). Maybe there's a >> bug somewhere in process.c where it's not correctly handling the (real) >> SIGPIPE signal and converting it to an Elisp signal? > > In batch mode, SIGPIPE is not ignored by Emacs, see init_signals. > This was changed 11 years ago, see commit 4d7e6e51dd. Thanks, I didn't realize that. > Perhaps Eshell should check that the process is still alive before > calling process-send-string? Ok, how about this? Jens, could you try this patch out to see if it fixes things for you? --------------p8wE9B9QEbu67UvqZq0HGLG3 Content-Type: text/plain; charset=UTF-8; name="0001-Check-for-process-liveness-before-calling-process-se.patch" Content-Disposition: attachment; filename*0="0001-Check-for-process-liveness-before-calling-process-se.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBlOWQ5NjFmMGIxZGViZWQ4MmZjMDA0ZDY2MzFmZmU2YWRmZjdjMTlmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMjQgU2VwIDIwMjMgMjI6MzA6MzQgLTA3MDAKU3ViamVjdDogW1BB VENIXSBDaGVjayBmb3IgcHJvY2VzcyBsaXZlbmVzcyBiZWZvcmUgY2FsbGluZwogJ3Byb2Nl c3Mtc2VuZC1zdHJpbmcnIGluIEVzaGVsbAoKSW4gb3RoZXIgd29yZHMsIHNlZWsgcGVybWlz c2lvbiBpbnN0ZWFkIG9mIGFza2luZyBmb3IgZm9yZ2l2ZW5lc3MKKGJ1ZyM2NjE4NikuCgoq IGxpc3AvZXNoZWxsL2VzaC1pby5lbCAoZXNoZWxsLW91dHB1dC1vYmplY3QtdG8tdGFyZ2V0 KTogQ2hlY2sKJ3Byb2Nlc3MtbGl2ZS1wJyBmaXJzdC4KLS0tCiBsaXNwL2VzaGVsbC9lc2gt aW8uZWwgfCAxMSArKystLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygr KSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2VzaGVsbC9lc2gtaW8uZWwg Yi9saXNwL2VzaGVsbC9lc2gtaW8uZWwKaW5kZXggY2QwY2VlNmUyMWQuLjY2OGZmMTNiODI1 IDEwMDY0NAotLS0gYS9saXNwL2VzaGVsbC9lc2gtaW8uZWwKKysrIGIvbGlzcC9lc2hlbGwv ZXNoLWlvLmVsCkBAIC02NDQsMTUgKzY0NCwxMCBAQCBlc2hlbGwtb3V0cHV0LW9iamVjdC10 by10YXJnZXQKICAgIk91dHB1dCBPQkpFQ1QgdG8gdGhlIHByb2Nlc3MgVEFSR0VULiIKICAg KHVubGVzcyAoc3RyaW5ncCBvYmplY3QpCiAgICAgKHNldHEgb2JqZWN0IChlc2hlbGwtc3Ry aW5naWZ5IG9iamVjdCkpKQotICAoY29uZGl0aW9uLWNhc2UgZXJyCisgIChpZiAocHJvY2Vz cy1saXZlLXAgdGFyZ2V0KQogICAgICAgKHByb2Nlc3Mtc2VuZC1zdHJpbmcgdGFyZ2V0IG9i amVjdCkKLSAgICAoZXJyb3IKLSAgICAgOzsgSWYgYHByb2Nlc3Mtc2VuZC1zdHJpbmcnIHJh aXNlcyBhbiBlcnJvciBhbmQgdGhlIHByb2Nlc3MgaGFzCi0gICAgIDs7IGZpbmlzaGVkLCB0 cmVhdCBpdCBhcyBhIGJyb2tlbiBwaXBlLiAgT3RoZXJ3aXNlLCBqdXN0Ci0gICAgIDs7IHJl LXRocm93IHRoZSBzaWduYWwuCi0gICAgIChpZiAocHJvY2Vzcy1saXZlLXAgdGFyZ2V0KQot ICAgICAgICAgKHNpZ25hbCAoY2FyIGVycikgKGNkciBlcnIpKQotICAgICAgIChzaWduYWwg J2VzaGVsbC1waXBlLWJyb2tlbiAobGlzdCB0YXJnZXQpKSkpKQorICAgIDs7IElmIHRoZSBw cm9jZXNzIGlzIGFscmVhZHkgZGVhZCwgdHJlYXQgdGhhdCBhcyBhIGJyb2tlbiBwaXBlLgor ICAgIChzaWduYWwgJ2VzaGVsbC1waXBlLWJyb2tlbiAobGlzdCB0YXJnZXQpKSkKICAgb2Jq ZWN0KQogCiAoY2wtZGVmbWV0aG9kIGVzaGVsbC1vdXRwdXQtb2JqZWN0LXRvLXRhcmdldCAo b2JqZWN0Ci0tIAoyLjI1LjEKCg== --------------p8wE9B9QEbu67UvqZq0HGLG3--