From: Drew Adams <drew.adams@oracle.com>
To: Damien Cassou <damien@cassou.me>
Cc: 26540@debbugs.gnu.org
Subject: bug#26540: 25.2; [PATCH] Add cl-set-equal to test for set equality
Date: Tue, 18 Apr 2017 14:49:35 -0700 (PDT) [thread overview]
Message-ID: <0a84e2b3-ae04-4528-8ef1-fd86f9bbeb28@default> (raw)
In-Reply-To: <87wpahbwz0.fsf@cassou.me>
> > If we do add it, I'd imagine that the implementation should be
> > the same (adding `not', as you say), for clarity and consistency
> > - unless other things are not equal for some reason (i.e.,
> > unless there is a good reason not to use the existing
> > implementation).
>
> I updated the patch.
Maybe there is a good reason not to use the existing fn.
I didn't check the patch or the implementation of
`cl-set-exclusive-or', but that function is designed not
just to test for equality but also to return the list (set)
of elements that are in only one of the argument lists.
A naive guess is that when the sets are unequal this would
be slower than just a check for equality. You might want
to take a look. If that's the case then a simple equality
implementation would be better (e.g. throw to a catch as
soon as we know they are unequal).
next prev parent reply other threads:[~2017-04-18 21:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-17 9:16 bug#26540: 25.2; [PATCH] Add cl-set-equal to test for set equality Damien Cassou
2017-04-17 13:55 ` Drew Adams
2017-04-18 11:21 ` Damien Cassou
2017-04-18 14:00 ` Drew Adams
2017-04-18 14:40 ` Damien Cassou
2017-04-18 21:49 ` Drew Adams [this message]
2017-04-18 20:13 ` John Mastro
2017-04-18 21:53 ` Drew Adams
2017-04-19 9:39 ` Nicolas Petton
2017-04-19 10:43 ` Damien Cassou
2017-04-19 11:39 ` Damien Cassou
2017-04-19 14:41 ` Nicolas Petton
2017-05-03 13:02 ` Damien Cassou
2017-05-04 9:41 ` Nicolas Petton
2017-04-19 21:19 ` Michael Heerdegen
2017-05-03 13:12 ` Damien Cassou
2017-05-11 19:42 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a84e2b3-ae04-4528-8ef1-fd86f9bbeb28@default \
--to=drew.adams@oracle.com \
--cc=26540@debbugs.gnu.org \
--cc=damien@cassou.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).