From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil Date: Sat, 31 Dec 2022 15:02:57 +0000 Message-ID: <0a62cbaeff1ee0497715@heytings.org> References: <87zgb5lx6y.fsf@oracle.com> <6c9d91cffcdbff97f034@heytings.org> <87lemot7ek.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="JrZC5PZDQX" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29121"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60411@debbugs.gnu.org To: Knut Anders Hatlen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 31 16:04:30 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pBdPR-0007OA-UW for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Dec 2022 16:04:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pBdP6-0001Ka-M5; Sat, 31 Dec 2022 10:04:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBdP1-0001Jf-LG for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2022 10:04:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pBdP0-0000B5-Iw for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2022 10:04:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pBdP0-00052d-Ek for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2022 10:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Dec 2022 15:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60411 X-GNU-PR-Package: emacs Original-Received: via spool by 60411-submit@debbugs.gnu.org id=B60411.167249898219279 (code B ref 60411); Sat, 31 Dec 2022 15:04:02 +0000 Original-Received: (at 60411) by debbugs.gnu.org; 31 Dec 2022 15:03:02 +0000 Original-Received: from localhost ([127.0.0.1]:39612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBdO1-00050n-MS for submit@debbugs.gnu.org; Sat, 31 Dec 2022 10:03:02 -0500 Original-Received: from heytings.org ([95.142.160.155]:53178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBdNz-00050c-E8 for 60411@debbugs.gnu.org; Sat, 31 Dec 2022 10:02:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1672498978; bh=jEUqydakEQl0su27iuG/fpTc6gxQ6bpTv8xTyLh0uyA=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=SjaDPezlodVVUhbTCqYGiwaOfNa5NcUNc0HyZaBIlLKIxN8uH+rQo9YhYzuLj54uy JsuITcINygaa7jmAsuiXTsumO3ANQYakX69AUQPXbY2v0co9Ivwfm97zAGNyvtkJqO OoQMtPBhkHz4C2+u6/nGBVD1HCRn62Wk1L0ARCy+ecJRNn6TnQDyEOPa5GBW5UIZa2 tyJBbxPwhoflFV04XcwgdNtsJKK6KqXKfmA4GBNUUWYtFtR2+e/o2k5RX6nwrAXGII RoqC3zpL3E/Ux6MCXU6f6REaIodfGWjs6U/P4u2nPV2VGRMk8XRBe2sWnSDaMsDnE2 5SmnVMd31kSrA== In-Reply-To: <87lemot7ek.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252195 Archived-At: --JrZC5PZDQX Content-Type: text/plain; charset=us-ascii; format=flowed > > For completeness, you may consider also handling the case where > completions-header-format is an empty string, which is another not too > unreasonable way to disable the header. minibuffer-next-completion still > skips the first candidate for that case. > Thanks for your feedback! Indeed, that's another bug, which makes a fix elsewhere in the code even less likely. It is fixed in the attached patch. Can you try it? Eli, do you have objections to that patch? --JrZC5PZDQX Content-Type: text/x-diff; name=Fix-handling-of-completions-header-format.patch Content-Transfer-Encoding: base64 Content-ID: <0a62cbaeffd696e1d8c7@heytings.org> Content-Disposition: attachment; filename=Fix-handling-of-completions-header-format.patch RnJvbSBkMDQ0M2UwMjE1MTk2YjE1NzY4MDBhZTFkNWYwZjUzNTdhOGE4ZGFk IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBTYXQsIDMxIERl YyAyMDIyIDE0OjUwOjEzICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIEZpeCBo YW5kbGluZyBvZiBjb21wbGV0aW9ucy1oZWFkZXItZm9ybWF0DQoNCiogbGlz cC9taW5pYnVmZmVyLmVsIChkaXNwbGF5LWNvbXBsZXRpb24tbGlzdCk6IElu c2VydCBhbg0KaW52aXNpYmxlIGxpbmUgd2hlbiBjb21wbGV0aW9ucy1oZWFk ZXItZm9ybWF0IGlzIG5vdCBhIHN0cmluZyAoaW4NCnBhcnRpY3VsYXIsIG5p bCkgb3IgaXMgYW4gZW1wdHkgc3RyaW5nLiAgRml4ZXMgYnVnIzYwNDExLg0K QWxzbywgZG8gbm90IHVzZSBjb21wbGV0aW9ucy1oZWFkZXItZm9ybWF0IHdo ZW4gaXQgaXMgbm90IGENCnN0cmluZy4NCi0tLQ0KIGxpc3AvbWluaWJ1ZmZl ci5lbCB8IDggKysrKysrKy0NCiAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRp b25zKCspLCAxIGRlbGV0aW9uKC0pDQoNCmRpZmYgLS1naXQgYS9saXNwL21p bmlidWZmZXIuZWwgYi9saXNwL21pbmlidWZmZXIuZWwNCmluZGV4IDdhNzIw Y2YyYzAuLjZjNzQxM2M1NTUgMTAwNjQ0DQotLS0gYS9saXNwL21pbmlidWZm ZXIuZWwNCisrKyBiL2xpc3AvbWluaWJ1ZmZlci5lbA0KQEAgLTIyNzUsOCAr MjI3NSwxNCBAQCBkaXNwbGF5LWNvbXBsZXRpb24tbGlzdA0KIA0KICAgICAo d2l0aC1jdXJyZW50LWJ1ZmZlciBzdGFuZGFyZC1vdXRwdXQNCiAgICAgICAo Z290by1jaGFyIChwb2ludC1tYXgpKQ0KLSAgICAgICh3aGVuIGNvbXBsZXRp b25zLWhlYWRlci1mb3JtYXQNCisgICAgICAod2hlbiAoc3RyaW5ncCBjb21w bGV0aW9ucy1oZWFkZXItZm9ybWF0KQ0KICAgICAgICAgKGluc2VydCAoZm9y bWF0IGNvbXBsZXRpb25zLWhlYWRlci1mb3JtYXQgKGxlbmd0aCBjb21wbGV0 aW9ucykpKSkNCisgICAgICAod2hlbiAob3IgKG5vdCAoc3RyaW5ncCBjb21w bGV0aW9ucy1oZWFkZXItZm9ybWF0KSkNCisgICAgICAgICAgICAgICAgKHN0 cmluZz0gY29tcGxldGlvbnMtaGVhZGVyLWZvcm1hdCAiIikpDQorICAgICAg ICA7OyBJbnNlcnQgYW4gaW52aXNpYmxlIGxpbmUsIG90aGVyd2lzZSB0aGUg Zmlyc3QgY2FsbCB0bw0KKyAgICAgICAgOzsgJ21pbmlidWZmZXItbmV4dC1j b21wbGV0aW9uJyBtaWdodCBzZWxlY3QgdGhlIHNlY29uZA0KKyAgICAgICAg OzsgY29tcGxldGlvbiBjYW5kaWRhdGUuICBTZWUgYnVnIzYwNDExLg0KKyAg ICAgICAgKGluc2VydCAocHJvcGVydGl6ZSAiXG4iICdpbnZpc2libGUgdCkp KQ0KICAgICAgIChjb21wbGV0aW9uLS1pbnNlcnQtc3RyaW5ncyBjb21wbGV0 aW9ucyBncm91cC1mdW4pKSkNCiANCiAgIChydW4taG9va3MgJ2NvbXBsZXRp b24tc2V0dXAtaG9vaykNCi0tIA0KMi4zOS4wDQoNCg== --JrZC5PZDQX--