From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#63469: 29.0.90; project.el doesn't add menu-bar entries Date: Wed, 24 May 2023 04:00:20 +0300 Message-ID: <0a09aefc-85b4-ec8d-e9a7-d7e881d4a96b@gutov.dev> References: <834jod1lvc.fsf@gnu.org> <83o7mkz2ap.fsf@gnu.org> <83sfbvxkj3.fsf@gnu.org> <3d97111e-794d-eeef-73b0-ee3f6f5f15d5@gutov.dev> <83jzx6w2bg.fsf@gnu.org> <6a3eed52-3248-74f9-bcaf-bf12660ae0ed@gutov.dev> <83h6savsz4.fsf@gnu.org> <83mt21vfgl.fsf@gnu.org> <86mt211vk3.fsf@mail.linkov.net> <0ce4532f-03aa-6afe-bd8f-8ef1df6615de@gutov.dev> <86ilco7qbs.fsf@mail.linkov.net> <83r0rctxbc.fsf@gnu.org> <867ct4b4ds.fsf@mail.linkov.net> <835y8otbub.fsf@gnu.org> <86o7mccl5z.fsf@mail.linkov.net> <63854a1a-8178-d039-288c-34b1e67e5b06@gutov.dev> <86ttw3blc6.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35800"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Cc: sbaugh@janestreet.com, Eli Zaretskii , 63469@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 24 03:01:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q1csS-00096w-4n for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 May 2023 03:01:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q1csC-00064f-KW; Tue, 23 May 2023 21:01:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1csA-00064V-Pt for bug-gnu-emacs@gnu.org; Tue, 23 May 2023 21:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q1csA-0007te-IB for bug-gnu-emacs@gnu.org; Tue, 23 May 2023 21:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q1csA-0000pZ-0C for bug-gnu-emacs@gnu.org; Tue, 23 May 2023 21:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 May 2023 01:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63469 X-GNU-PR-Package: emacs Original-Received: via spool by 63469-submit@debbugs.gnu.org id=B63469.16848900313145 (code B ref 63469); Wed, 24 May 2023 01:01:01 +0000 Original-Received: (at 63469) by debbugs.gnu.org; 24 May 2023 01:00:31 +0000 Original-Received: from localhost ([127.0.0.1]:40677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1cre-0000of-VF for submit@debbugs.gnu.org; Tue, 23 May 2023 21:00:31 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:59795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1crd-0000oQ-Ak for 63469@debbugs.gnu.org; Tue, 23 May 2023 21:00:30 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 449A55C020A; Tue, 23 May 2023 21:00:24 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 23 May 2023 21:00:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1684890024; x=1684976424; bh=NNndDkcZlUYiMNecf0C3Q3VFZ0lC5bID0Fs TisOrRnE=; b=V7Bcj0M6LuCa+UNU1Ovq+TfLcWkBNbzVHI8ttT6e193qFetGy/n YeLkvpd06MgUE9UbzHLDzzQMGoXMof/0mlSoJ2uHfCLwbuJg/K439IxpJ8JB9YpN hn798FwISrOQ1UEd9hvPszDVxUyIXEVXkkDOmJg9nAPGo3KoRcdJ1S3/tJ+t83E3 o+rB1EeFfMIkWqd4U+lnkzSTT1jNy4pUzUP0sLgeKwaUC11j+tcYj/Y+SGftinRr +K68cJh6LdKYETY2OhU5aS4sDM6UDD9dzDxKqO16vLYUGZ73cqAjSAGUNIudjI87 OAfR1SUTpU0I24pC58q9cJoZILfEsoioH3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1684890024; x=1684976424; bh=NNndDkcZlUYiMNecf0C3Q3VFZ0lC5bID0Fs TisOrRnE=; b=dejjt7QwUvzsLBzNrCcEIrXQ8O70QkF8iC19B4ZRD2nJI4ReLRo yFpIEThG32bXcOOmW3BCBo7qeUSJTu6n7Loz6714nh/+8DyQBu2pxwdxvJEZs5Jt J/VrUxbxdsZG54tjlluALYv8pGPHC+rsnI6OKPGsSn+FwQq4lcowYbDe6FFN8Bmv JFfw04omiOeHE1Chb5dxmeeVrypSz4MZfiJLvZzgtDaMAS8U72KCt+fATqd0HgR3 IslFHqUaOBx94erfyria83S2cJS7pGKfmOKa6ByAwhGSw2pb2czoaWGiTGQ3eYv6 GlsTGUQyVaKNajq1KDPNDFCF/n4rgTMJSiw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejgedggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 23 May 2023 21:00:22 -0400 (EDT) Content-Language: en-US In-Reply-To: <86ttw3blc6.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262260 Archived-At: On 23/05/2023 09:46, Juri Linkov wrote: >>> +(define-minor-mode project-mode >>> + "Toggle display of project menu in the project-aware buffers." >>> + (if project-mode >>> + (setq-local project-name (concat >>> + " " >>> + (propertize >>> + (project-name (project-current)) >>> + 'mouse-face 'mode-line-highlight >>> + 'local-map project-mode-line-map))))) >> >> At the very least, this will need some better name, because project >> features don't need any mode to be turned on to be used. >> >> project-menu-mode? > > 'project-mode' will be more like 'vc-mode' that actually is not a minor mode. > I don't know why it was named 'vc-mode'. vc-mode is not a mode at all: you can't choose to enable or disable it. >> Next, I'm not quite sure about the caching of project-name. There is no >> scenario when it will be invalidated, right? > > I can't imagine such scenario. Any scenario where the user assigns of changes the name, e.g. by changing the value of project-vc-name. >> Try simply calling (project-name (project-current t)) every time, see how >> the performance is. Or, more thoroughly, copy the if-let logic from >> project-prefixed-buffer-name. > > Ok, will try. > > BTW, there is another problem: by default 'project-name' is defined as > (file-name-nondirectory (directory-file-name (project-root project))). > But then project name often is the same for different projects > because the directory name is the same for the same repository. > For example, in a subtree: > > emacs-master/emacs/... > emacs-29/emacs/... > emacs-28/emacs/... > > All project names are the same 'emacs'. How would it be possible to > customize project names? Trying to get a parent dir might be too > unreliable. So probably the only way is to define the name manually. > Maybe in .dir-locals.el. Actually this works: > > ((nil . ((project-vc-name . "emacs-29")))) > > Not sure why non-VC projects can't be named the same way. They can -- using whatever way the respective backend provides. > Also noticed that project-vc-name is not marked as safe, > so always asks a confirmation.