From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#31357: 26.1; tramp-make-tramp-file-name: incompatible lisp changes in 26.1 ? Date: Fri, 04 May 2018 02:23:45 +1200 Message-ID: <0a062d8f1fea73fcead8cafe8f225378@webmail.orcon.net.nz> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1525357391 26966 195.159.176.226 (3 May 2018 14:23:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 3 May 2018 14:23:11 +0000 (UTC) User-Agent: Orcon Webmail To: 31357@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 03 16:23:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEF8V-0006tZ-3a for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 May 2018 16:23:07 +0200 Original-Received: from localhost ([::1]:56875 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEFAb-0003uW-U9 for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 May 2018 10:25:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEFAR-0003u4-Sk for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 10:25:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEFAM-0001uX-Ti for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 10:25:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40446) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fEFAM-0001uJ-Pg for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 10:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fEFAM-0001kH-F3 for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 10:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 May 2018 14:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15253574546640 (code B ref -1); Thu, 03 May 2018 14:25:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 May 2018 14:24:14 +0000 Original-Received: from localhost ([127.0.0.1]:48343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEF9Z-0001j2-Vm for submit@debbugs.gnu.org; Thu, 03 May 2018 10:24:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fEF9Y-0001ip-F3 for submit@debbugs.gnu.org; Thu, 03 May 2018 10:24:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEF9S-0001Yl-13 for submit@debbugs.gnu.org; Thu, 03 May 2018 10:24:07 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:42092) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fEF9R-0001YZ-Tm for submit@debbugs.gnu.org; Thu, 03 May 2018 10:24:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEF9Q-0003VR-GX for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 10:24:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEF9J-0001VV-W3 for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 10:24:04 -0400 Original-Received: from smtp-4.orcon.net.nz ([60.234.4.59]:33341) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fEF9J-0001Uc-L3 for bug-gnu-emacs@gnu.org; Thu, 03 May 2018 10:23:57 -0400 Original-Received: from [10.253.37.70] (port=50887 helo=webmail.orcon.net.nz) by smtp-4.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1fEF97-00030I-Mf for bug-gnu-emacs@gnu.org; Fri, 04 May 2018 02:23:55 +1200 Original-Received: from [150.107.175.243] via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Fri, 04 May 2018 02:23:45 +1200 X-Sender: psainty@orcon.net.nz X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145972 Archived-At: In Emacs 25 `tramp-make-tramp-file-name' takes 4-5 arguments: (method user host localname &optional hop) In Emacs 26.1 it takes 6-7 (method user domain host port localname &optional hop) That can then trigger a "wrong-number-of-arguments" error. This should surely be covered in NEWS under the "Incompatible Lisp Changes in Emacs 26.1" section? I rather suspect there were also many other functions affected by these changes, but I've not attempted to audit that. I have custom code where I am presently using the following construct to deal with this. (if (version< emacs-version "26") (tramp-make-tramp-file-name method user host localname hop) (tramp-make-tramp-file-name method user domain host port localname hop)) (With a consequential complaint from the 26.1 byte-compiler about the first of those two calls.) Is there a single approach which is backwards-compatible (at least with Emacs 25) ? For my specific use-case, what I really wanted was a way to modify only a specific named component of a tramp file name, but I ended up using `tramp-dissect-file-name', extracting the components with the various `tramp-file-name-COMPONENT' functions, and using `tramp-make-file-name' to put it all back together. I thought there might be a simpler way to do this, but I didn't see one. -Phil In GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2018-04-15 built on shodan Windowing system distributor 'The X.Org Foundation', version 11.0.11804000 System Description: Ubuntu 16.04.4 LTS Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Mark activated Configured using: 'configure --prefix=/home/phil/emacs/26.1rc1/usr/local --with-x-toolkit=lucid --without-sound' Configured features: XAW3D XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK DBUS GSETTINGS NOTIFY GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 THREADS LCMS2 Important settings: value of $LANG: en_NZ.UTF-8 locale-coding-system: utf-8 Major mode: Dired by name Minor modes in effect: show-paren-mode: t minibuffer-depth-indicate-mode: t winner-mode: t global-hl-line-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils dired-x easymenu paren mb-depth winner ring hl-line dired dired-loaddefs advice elec-pair time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 100308 9804) (symbols 48 20761 2) (miscs 40 101 271) (strings 32 30242 1161) (string-bytes 1 789994) (vectors 16 14561) (vector-slots 8 496928 9732) (floats 8 58 59) (intervals 56 269 7) (buffers 992 13) (heap 1024 44332 1473))