From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#49127: Performance degradation in encode_coding_object Date: Mon, 16 Aug 2021 22:04:36 +0200 Message-ID: <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> <83lf516x7o.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38409"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 16 22:05:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFir9-0009jX-Tl for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Aug 2021 22:05:12 +0200 Original-Received: from localhost ([::1]:60358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFir7-0003FC-TI for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Aug 2021 16:05:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFir0-0003Dm-BQ for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2021 16:05:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39537) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mFir0-0004Y2-58 for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2021 16:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mFiqz-0005js-TQ for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2021 16:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Aug 2021 20:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49127 X-GNU-PR-Package: emacs Original-Received: via spool by 49127-submit@debbugs.gnu.org id=B49127.162914429222036 (code B ref 49127); Mon, 16 Aug 2021 20:05:01 +0000 Original-Received: (at 49127) by debbugs.gnu.org; 16 Aug 2021 20:04:52 +0000 Original-Received: from localhost ([127.0.0.1]:51083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFiqp-0005jM-Pt for submit@debbugs.gnu.org; Mon, 16 Aug 2021 16:04:52 -0400 Original-Received: from mail1461c50.megamailservers.eu ([91.136.14.61]:60026 helo=mail267c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFiqk-0005j2-HX for 49127@debbugs.gnu.org; Mon, 16 Aug 2021 16:04:50 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1629144279; bh=2GjTgEGWe7CHrJwpq72JZd0k2d9/t3y4facIsHNJypM=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=ZGTLjVROQUML00WbjM/0586dtUzFp8MXtR4Yzny+uc5/mqXmZ6uab9w0x1Nq7tH19 J9ttwC1rt1DgZhKcOuGLzG+bCAiiZjqfmwe8GN83M3edWf7zhXvEC0UqX8TdqAp6KY aIKDJyJPjAiNXIocbut+xgn3+1fKmUDxCxNdv58E= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail267c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17GK4aCb012639; Mon, 16 Aug 2021 20:04:38 +0000 In-Reply-To: <83lf516x7o.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F18.611AC4D7.004B, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=S9SnP7kP c=1 sm=1 tr=0 a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=QEEfLx4z3-02V98Qa4IA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212065 Archived-At: 16 aug. 2021 kl. 20.50 skrev Eli Zaretskii : > It does, if both src_object and dst_object are the same (current) > buffer. There is nothing in that function or in the comment describing it which = says that the current buffer must be either. It costs us nothing to use = the correct value so that's what we should do. > How can we be sure this reproduces the original issue? The original > issue was reported from a real-life use case, not from a toy program. Because I have read and tested the original code as well, which is how = that toy program that reproduces the problem in a simpler but = qualitatively equivalent way came to be. The patch fixes the symptoms of = both the toy program and the real-life use case. > Thanks, but this is not the whole story with that problem in > encode_coding_object. What is the whole story then?