From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#43677: 27.1; Calc holidays off-by-one error, incorrect business day calculation Date: Wed, 30 Sep 2020 11:42:58 +0200 Message-ID: <0FA74B6A-DD93-41D7-91C4-ED4EB881E2DD@acm.org> References: Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3591"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Aaron Zeng , 43677@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 30 11:44:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNYek-0000px-Qp for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 11:44:15 +0200 Original-Received: from localhost ([::1]:43592 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNYej-0005ms-J6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 05:44:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNYeb-0005mX-MC for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 05:44:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46717) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNYeY-0003dK-DF for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 05:44:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNYeY-0006ko-AC for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 05:44:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 09:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43677 X-GNU-PR-Package: emacs Original-Received: via spool by 43677-submit@debbugs.gnu.org id=B43677.160145899325894 (code B ref 43677); Wed, 30 Sep 2020 09:44:02 +0000 Original-Received: (at 43677) by debbugs.gnu.org; 30 Sep 2020 09:43:13 +0000 Original-Received: from localhost ([127.0.0.1]:58263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNYdk-0006ja-Nk for submit@debbugs.gnu.org; Wed, 30 Sep 2020 05:43:12 -0400 Original-Received: from mail1449c50.megamailservers.eu ([91.136.14.49]:55858 helo=mail265c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNYdg-0006jI-Vf for 43677@debbugs.gnu.org; Wed, 30 Sep 2020 05:43:11 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1601458982; bh=zFCGYYJBykEqRyCVZCecs3VihDTJsff8OPk5+RJZEBk=; h=From:Subject:Date:Cc:To:From; b=EqE+4aPHN06UG77KwbSjxEr2ACQvbPy4zsyS79VKI5yd2pzLdTu4t+aiiTWzbmSN5 h7U90SLuGs9B34OEt4l8GxiVXjhyx5cy55jYoC+0nPTv5fWzRMKQqaw0UzY6F6Tuyr 2xSGpDcWw3c1GDGLZ64B2/wde7Jq7z433uM8aTzw= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-304ee655.032-75-73746f71.bbcust.telenor.se [85.230.78.48]) (authenticated bits=0) by mail265c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 08U9gxRo016808; Wed, 30 Sep 2020 09:43:01 +0000 X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A782F25.5F745326.0040, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=D5w51cZj c=1 sm=1 tr=0 a=63Z2wlQ1NB3xHpgKFKE71g==:117 a=63Z2wlQ1NB3xHpgKFKE71g==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=LdZ1IVNqazZ2p9ERV48A:9 a=CjuIK1q_8ugA:10 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189325 Archived-At: > Indeed -- applying the following patch (which numbers Monday as 0 and = Sunday as 6) makes the test case work correctly for me. But trying to = follow the code makes it unclear... er... what's going on, and there = aren't many comments in the Calc code to explain what they were = thinking. Welcome to Calc! > I wondered whether this might be a US/non-US thing (with a difference = in what day starts the week), but I couldn't really find anything in = calc talking about that...=20 The weekday numbering can be arbitrary as long as it is only used = internally. Calc's date representation (from Rata Die) sets Dec 31, 1 = B.C. as day 0, and this happens to be a Sunday. That means that (mod DAY = 7) is an easy way to get the week-starts-on-Sunday numbering used by = some foreigners. Since the bug is a regression -- it is present in Emacs 26.1 but not in = 22.1.1 -- it may be a good idea to find out exactly what change = introduced it, and work from there. That might reduce the risk of = causing secondary bugs.