bug#29361: 26.0.50; MacOSX Command-Option-H undefined

bug#29361: 26.0.50; MacOSX Command-Option-H undefined

[Devon Sean McCullough]

$ Open -n -a Emacs --args -Q
Clover-Alt-H fails to perform ns-do-hide-others
which does work from the menu Emacs > Hide Others

The MacOSX Emacs menu says: 	But the keymap says:
	About Emacs
	Preferences...	 ⌘, 	s-, runs the command customize
	Services      	 ►
	Hide Emacs    	 ⌘H 	s-h runs the command ns-do-hide-emacs
	Hide Others   	⌥⌘H 	M-s-˙ is undefined
	Quit Emacs    	 ⌘Q 	s-q runs the command save-buffers-kill-emacs

What the menu promises should work
and these particular bindings are mandatory for all MacOSX apps.

To fix this and related infelicities, patch lisp/term/ns-win.el

--- old/ns-win.el	2017-06-06 16:19:10.000000000 -0400
+++ new/ns-win.el	2017-11-19 13:57:17.000000000 -0500
@@ -101,6 +101,7 @@
 (define-obsolete-variable-alias 'ns-alternatives-map 'x-alternatives-map "24.1")
 
 ;; Here are some Nextstep-like bindings for command key sequences.
+;; * indicates non-NeXTStep binding
 (define-key global-map [?\s-,] 'customize)
 (define-key global-map [?\s-'] 'next-multiframe-window)
 (define-key global-map [?\s-`] 'other-frame)
@@ -110,29 +111,38 @@
 (define-key global-map [?\s-?] 'info)
 (define-key global-map [?\s-^] 'kill-some-buffers)
 (define-key global-map [?\s-&] 'kill-current-buffer)
-(define-key global-map [?\s-C] 'ns-popup-color-panel)
-(define-key global-map [?\s-D] 'dired)
-(define-key global-map [?\s-E] 'edit-abbrevs)
-(define-key global-map [?\s-L] 'shell-command)
-(define-key global-map [?\s-M] 'manual-entry)
-(define-key global-map [?\s-S] 'ns-write-file-using-panel)
 (define-key global-map [?\s-a] 'mark-whole-buffer)
 (define-key global-map [?\s-c] 'ns-copy-including-secondary)
+(define-key global-map [?\M-\s-c] 'ns-popup-color-panel)
+(define-key global-map [?\s-C] 'ns-popup-color-panel) ; *
 (define-key global-map [?\s-d] 'isearch-repeat-backward)
+(define-key global-map [?\M-\s-d] 'dired)
+(define-key global-map [?\s-D] 'dired) ; *
 (define-key global-map [?\s-e] 'isearch-yank-kill)
+(define-key global-map [?\M-\s-e] 'edit-abbrevs)
+(define-key global-map [?\s-E] 'edit-abbrevs) ; *
 (define-key global-map [?\s-f] 'isearch-forward)
+(define-key global-map [?\s-F] 'isearch-backward)
 (define-key global-map [?\s-g] 'isearch-repeat-forward)
+(define-key global-map [?\s-G] 'isearch-repeat-backward)
 (define-key global-map [?\s-h] 'ns-do-hide-emacs)
-(define-key global-map [?\s-H] 'ns-do-hide-others)
+(define-key global-map [?\M-\s-h] 'ns-do-hide-others)
+(define-key global-map [?\s-H] 'ns-do-hide-others) ; *
 (define-key global-map [?\s-j] 'exchange-point-and-mark)
 (define-key global-map [?\s-k] 'kill-current-buffer)
 (define-key global-map [?\s-l] 'goto-line)
+(define-key global-map [?\M-\s-l] 'shell-command)
+(define-key global-map [?\s-L] 'shell-command) ; *
 (define-key global-map [?\s-m] 'iconify-frame)
+(define-key global-map [?\M-\s-m] 'manual-entry)
+(define-key global-map [?\s-M] 'manual-entry) ; *
 (define-key global-map [?\s-n] 'make-frame)
 (define-key global-map [?\s-o] 'ns-open-file-using-panel)
 (define-key global-map [?\s-p] 'ns-print-buffer)
 (define-key global-map [?\s-q] 'save-buffers-kill-emacs)
 (define-key global-map [?\s-s] 'save-buffer)
+(define-key global-map [?\M-\s-s] 'ns-write-file-using-panel)
+(define-key global-map [?\s-S] 'ns-write-file-using-panel) ; *
 (define-key global-map [?\s-t] 'ns-popup-font-panel)
 (define-key global-map [?\s-u] 'revert-buffer)
 (define-key global-map [?\s-v] 'yank)

		Peace
			--Devon

P.S. The MacOSX Emacs Edit menu fails to show some mandatory keys:

The MacOSX Edit menu says:	  	But should say:
        Undo (C-x u)      	  	Undo (C-x u)    	 ⌘Z
        Cut               	  	Cut             	 ⌘X
        Copy              	 ⌘C	Copy            	 ⌘C
        Paste (C-y)       	  	Paste (C-y)     	 ⌘V
        Select and Paste  	 ►	Select and Paste	 ►
        Clear             	  	Clear
        Select All (C-x h)	  	Select All (C-x h)	 ⌘A
        Search            	 ►	Search          	 ►
        Replace           	 ►	Replace         	 ►
        Go To             	 ►	Go To           	 ►
        Bookmarks         	 ►	Bookmarks       	 ►
        Fill              	  	Fill
        Spell             	 ►	Spell           	 ►
        Text Properties   	 ►	Text Properties 	 ►

These keys all work as required but only ⌘C appears on the menu.
Sorry, I have no patch for this.

P.P.S. In case your (hopefully fixed-width) font lacks these characters:
	Glyph 	Unicode 	Name(s)
	⌘     	?\u2318 	?\N{PLACE OF INTEREST SIGN} fka ?\N{COMMAND KEY}
	⌥     	?\u2325 	?\N{OPTION KEY}
	►     	?\u25BA 	?\N{BLACK RIGHT-POINTING POINTER}

In GNU Emacs 26.0.50 (build 1, x86_64-apple-darwin13.4.0, NS appkit-1265.21 Version 10.9.5 (Build 13F1911))
 of 2017-06-07 built on builder10-9.local
Windowing system distributor 'Apple', version 10.3.1404
Recent messages:
Warning: arch-dependent data dir ’/Users/build/workspace/Emacs-Multi-Build/label/mavericks/emacs-source/nextstep/Emacs.app/Contents/MacOS/libexec/’: No such file or directory

For information about GNU Emacs and the GNU system, type C-h C-a.
M-s-˙ is undefined

Configured using:
 'configure --with-ns '--enable-locallisppath=/Library/Application
 Support/Emacs/${version}/site-lisp:/Library/Application
 Support/Emacs/site-lisp' --with-modules'

Configured features:
NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv
bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date tooltip eldoc
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win
ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset
image regexp-opt fringe tabulated-list replace newcomment text-mode
elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow
isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu
font-core term/tty-colors frame cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote kqueue cocoa ns multi-tty
make-network-process emacs)

Memory information:
((conses 16 203320 6331)
 (symbols 48 19810 1)
 (miscs 40 44 107)
 (strings 32 17933 5906)
 (string-bytes 1 581665)
 (vectors 16 34820)
 (vector-slots 8 694346 6376)
 (floats 8 48 69)
 (intervals 56 209 0)
 (buffers 976 11))

bug#29361: 26.0.50; MacOSX Command-Option-H undefined

[Alan Third]

On Sun, Nov 19, 2017 at 03:23:39PM -0500, Devon Sean McCullough wrote:
> $ Open -n -a Emacs --args -Q
> Clover-Alt-H fails to perform ns-do-hide-others
> which does work from the menu Emacs > Hide Others

Hi Devon, I believe you already submitted a patch for clover‐alt‐H a
while back, and it was committed. I think you must be running a
slightly out of date build.

> The MacOSX Emacs menu says: 	But the keymap says:
> 	About Emacs
> 	Preferences...	 ⌘, 	s-, runs the command customize
> 	Services      	 ►
> 	Hide Emacs    	 ⌘H 	s-h runs the command ns-do-hide-emacs
> 	Hide Others   	⌥⌘H 	M-s-˙ is undefined
> 	Quit Emacs    	 ⌘Q 	s-q runs the command save-buffers-kill-emacs
> 
> What the menu promises should work
> and these particular bindings are mandatory for all MacOSX apps.
> 
> To fix this and related infelicities, patch lisp/term/ns-win.el

I’m unsure about some of the changes you’re making in this patch. Are
you rearranging some of the lines? I think that’s generally frowned
upon as it makes tracking changes harder.

If you could redo your changes against a more up to date copy of
ns-win.el, I’ll be happy to commit it.

> P.S. The MacOSX Emacs Edit menu fails to show some mandatory keys:
> 
> The MacOSX Edit menu says:	  	But should say:
>         Undo (C-x u)      	  	Undo (C-x u)    	 ⌘Z
>         Cut               	  	Cut             	 ⌘X
>         Copy              	 ⌘C	Copy            	 ⌘C
>         Paste (C-y)       	  	Paste (C-y)     	 ⌘V
>         Select and Paste  	 ►	Select and Paste	 ►
>         Clear             	  	Clear
>         Select All (C-x h)	  	Select All (C-x h)	 ⌘A
>         Search            	 ►	Search          	 ►
>         Replace           	 ►	Replace         	 ►
>         Go To             	 ►	Go To           	 ►
>         Bookmarks         	 ►	Bookmarks       	 ►
>         Fill              	  	Fill
>         Spell             	 ►	Spell           	 ►
>         Text Properties   	 ►	Text Properties 	 ►
> 
> These keys all work as required but only ⌘C appears on the menu.
> Sorry, I have no patch for this.

I’m not sure how to fix this either. I’ll have to have a dig around.
-- 
Alan Third

bug#29361: 26.0.50; MacOSX Command-Option-H undefined

[Lars Ingebrigtsen]

Alan Third <alan@idiocy.org> writes:

>> What the menu promises should work
>> and these particular bindings are mandatory for all MacOSX apps.
>> 
>> To fix this and related infelicities, patch lisp/term/ns-win.el
>
> I’m unsure about some of the changes you’re making in this patch. Are
> you rearranging some of the lines? I think that’s generally frowned
> upon as it makes tracking changes harder.
>
> If you could redo your changes against a more up to date copy of
> ns-win.el, I’ll be happy to commit it.

This was two years ago, and there was no response to this, so it seems
unlikely that we'll make further progress on this bug report, and I'm
closing it.  If the problem still exists, please respond to this email
and we'll reopen the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no