From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Mauger via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27 Date: Sun, 09 Aug 2020 02:13:55 +0000 Message-ID: <0ECl7a2DnX9lhCgi5l9yWWgYuaVA8vXSgopiT8XnU1gOTJ03LLk0aMCVRbM4a95Ab9aYDuP5EiFpeL03TY_RzB5ogHS-3jPzLxH5dVjUW8o=@protonmail.com> References: <837dzwboes.fsf@gnu.org> <83k13o8tsb.fsf@gnu.org> Reply-To: Michael Mauger , Michael Mauger Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7901"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "39960@debbugs.gnu.org" <39960@debbugs.gnu.org>, Eli Zaretskii To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 09 04:15:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4arg-0001w1-80 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Aug 2020 04:15:12 +0200 Original-Received: from localhost ([::1]:52734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4are-0008Kd-I5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Aug 2020 22:15:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4arW-0008KE-L2 for bug-gnu-emacs@gnu.org; Sat, 08 Aug 2020 22:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48268) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k4arW-0000mO-Bm for bug-gnu-emacs@gnu.org; Sat, 08 Aug 2020 22:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k4arW-0005mj-4J for bug-gnu-emacs@gnu.org; Sat, 08 Aug 2020 22:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Mauger Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Aug 2020 02:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39960 X-GNU-PR-Package: emacs Original-Received: via spool by 39960-submit@debbugs.gnu.org id=B39960.159693924822162 (code B ref 39960); Sun, 09 Aug 2020 02:15:02 +0000 Original-Received: (at 39960) by debbugs.gnu.org; 9 Aug 2020 02:14:08 +0000 Original-Received: from localhost ([127.0.0.1]:59814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4aqe-0005lO-D2 for submit@debbugs.gnu.org; Sat, 08 Aug 2020 22:14:08 -0400 Original-Received: from mail-40134.protonmail.ch ([185.70.40.134]:30226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4aqc-0005kl-F0 for 39960@debbugs.gnu.org; Sat, 08 Aug 2020 22:14:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1596939240; bh=CSblgSY2adPAOckTvUEgQkvbBfPXlQvQ83DAFoAzyV0=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=UvYDePLc0n6OdiU8tDYa40p2nzuEqhrfqSEPYDM36GydPOyL/GdNMi+MkqkCN8deq 8dlYv7pOIqNOraZSpn70mV1dj9fjq5feUL6MYFMmQ8fDKrAvza/9eJ6WjI+yUIVuzw cZXoIwOnqArfLa6/CXshx6rdcGE5QLi/BlzN+pv8= In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184376 Archived-At: =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Tuesday, July 28, 2020 4:06 PM, Philipp Stephani = wrote: > Am Mo., 23. M=C3=A4rz 2020 um 02:20 Uhr schrieb Michael Mauger > mmauger@protonmail.com: > > > =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Origina= l Message =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80= =90 > > On Friday, March 13, 2020 5:53 AM, Eli Zaretskii eliz@gnu.org wrote: > > > > > Ping! > > > > > > > Date: Sat, 07 Mar 2020 09:43:39 +0200 > > > > From: Eli Zaretskii eliz@gnu.org > > > > Cc: 39960@debbugs.gnu.org > > > > > > > > > From: Philipp p.stephani2@gmail.com > > > > > Date: Fri, 06 Mar 2020 23:39:16 +0100 > > > > > In Emacs 26, sql-add-product has the signature > > > > > (sql-add-product PRODUCT DISPLAY &rest PLIST) > > > > > However, in the Emacs 27 pretest the signature is now > > > > > (sql-add-product PRODUCT DISPLAY &optional PLIST) > > > > > Note the change from &rest to &optional. This is a breaking chang= e that > > > > > breaks all users of sql-add-product. I've found quite a few uses = of the > > > > > old signature in the wild, > > > > > > > > Thanks for reporting this. > > > > Michael, could you please look into this ASAP? TIA. > > > > Btw, this change of a public API is not in NEWS, AFAICT; if we deci= de > > > > eventually on keeping the change, we should announce it in NEWS. > > > > Sorry for the delay. The massive switch to WFH and illness concerns at = home > > interfered. All are fine, and I actually do get work done occasionally. > > No worries, and good to hear that! > > > I've got the following patch to make. I assume it needs to be made to t= he > > emacs-27 branch and corresponding patches made to master as well. If I > > should only commit to master (same change is needed there) for cherry-p= icking > > for emacs-27, let me know. > > Thanks for the patch! I noticed that it made it to master as commit > 82a632edc8b80bf16d9b9f205474bf9724b084c0, but not to emacs-27, are you > still planning to backport it? Yes, it definitely needs to be backported. Eli, what do I need to do to get= this backported to Emacs 27? This was a bad breaking change to 27 that I fixed a= fter the release branch was cut. Let me know if I need to do a separate commit o= r take other action to get this done... -- MICHAEL@MAUGER.COM // FSF and EFF member // GNU Emacs sql.el maintainer