From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#58718: Incorrect regex in nXML URI check Date: Mon, 24 Oct 2022 12:51:30 +0200 Message-ID: <0E0045FD-164C-4626-A81B-EF400FD04AD5@gmail.com> References: <938384610b8c5411944afa7fae860f15e2e40eae.camel@fastmail.fm> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1885"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58718-done@debbugs.gnu.org To: Martin Jerabek Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 24 12:56:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1omv7w-0000KF-OI for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Oct 2022 12:56:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1omv4K-0007L7-N1; Mon, 24 Oct 2022 06:52:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omv3q-00079U-N0 for bug-gnu-emacs@gnu.org; Mon, 24 Oct 2022 06:52:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1omv3q-0002Hz-F5 for bug-gnu-emacs@gnu.org; Mon, 24 Oct 2022 06:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1omv3p-0000St-UF for bug-gnu-emacs@gnu.org; Mon, 24 Oct 2022 06:52:01 -0400 In-Reply-To: <938384610b8c5411944afa7fae860f15e2e40eae.camel@fastmail.fm> Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Oct 2022 10:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 58718 X-GNU-PR-Package: emacs Mail-Followup-To: 58718@debbugs.gnu.org, mattias.engdegard@gmail.com, om@mailservice.ms Original-Received: via spool by 58718-done@debbugs.gnu.org id=D58718.16666087101766 (code D ref 58718); Mon, 24 Oct 2022 10:52:01 +0000 Original-Received: (at 58718-done) by debbugs.gnu.org; 24 Oct 2022 10:51:50 +0000 Original-Received: from localhost ([127.0.0.1]:47187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omv3e-0000SP-An for submit@debbugs.gnu.org; Mon, 24 Oct 2022 06:51:50 -0400 Original-Received: from mail-lf1-f50.google.com ([209.85.167.50]:36660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omv3b-0000SC-Jl for 58718-done@debbugs.gnu.org; Mon, 24 Oct 2022 06:51:48 -0400 Original-Received: by mail-lf1-f50.google.com with SMTP id g12so5513240lfh.3 for <58718-done@debbugs.gnu.org>; Mon, 24 Oct 2022 03:51:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=XqRwcXF8GrQlhGRfEd+R2Xt2JEqZUvKAQJQdPu8ZOlc=; b=b0S/HJ+nzqvWK5jbn/d1+Oj0ZH3pE9C6lfQt0zfZVUf9WUFL8USgZYXyfHKP2nRfjG HnZeMlTG1jY3iMBy0wfSE4W8V6iu7Y1uI3Zic1hVkshc4Txty0cPkwTW0YtjZcJsjYos J5mMwTT9ys4H3NspyZfN7VyI46QvGNAQ/GjfQvAdDvykuEvA9WNEvEk1vAkf7H8PEzM0 wp7cP64OaY+SpM1U4GSBACTNwmsPg9oeVHT1AlOQ5lZ+TyCN96bEX8LXFpZW4meOSatS uozh0qIjWCHhvRYiPd8v1RjkEi8xakVdw1Yy1bMtybes6Kyj/63cl5MFd/AEzIQgM1rb 984A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XqRwcXF8GrQlhGRfEd+R2Xt2JEqZUvKAQJQdPu8ZOlc=; b=jG1ZXrD3q45dD0jHKwzJJzbpdBZk0URRzYex6Sj/o8HlO9QuRBHnFXg2+0ctWqMT4W 7wtv1EGoBoeK1YU6QUMW3nej3vUEbcWURoaVvspUEUsMM644sCf8JgG5f/8IKXCGF9lX eOd3BidUSvAaotAXGxvTx+17YUWjOAiQIBsHVnKsnP8fJ6xGRopCYLEy9/OFWbR20s9a 9W1020HoPDAMVFi8oikJX7utXkfwIzuUwP7ORNUpzfsnPCABoLkbkCcBOvn9kkFgL5pK Nxo4GJv/LVl2/jYHyuFO1gQJLdyvnyKoJlwwksK9QCgWjPHsaHiyjqEYi1z5r/GZG2nk erGg== X-Gm-Message-State: ACrzQf39oz4QGBf7R/vPXi5UKda/H5lW2XK5MCoa8HCE68VlQ36iAjv1 gpccl7nZ+Uc/dk2vFFT36sI= X-Google-Smtp-Source: AMsMyM6XpzCQwaQwy8/YRvXeQt0bUxBGSELPkqlCrPejFWtFFe8yG3MAKQg88lN0uX+4z6OiZRDTFA== X-Received: by 2002:a19:3853:0:b0:4a2:8dc4:3888 with SMTP id d19-20020a193853000000b004a28dc43888mr10726808lfj.289.1666608701223; Mon, 24 Oct 2022 03:51:41 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se. [188.150.171.209]) by smtp.gmail.com with ESMTPSA id i9-20020a2ea369000000b002770fb5722fsm197289ljn.123.2022.10.24.03.51.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Oct 2022 03:51:40 -0700 (PDT) X-Mailer: Apple Mail (2.3654.120.0.1.13) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246102 Archived-At: I concur with the assessment. Your fixes are straightforward and have = now been pushed to master. I also did a quick scan for similar errors (missing backslashes before = curly brackets) but found no obvious cases of the same bug in the Emacs = tree. A check could be added to the regexp linter but it's hard to guard = against false positives. Thanks for the report and patch. This code hasn't seen much changes = since it was added to Emacs, so if you find something else to improve = you are more than welcome to contribute to further development.