From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE Date: Sat, 4 Apr 2020 20:06:23 +0200 Message-ID: <0D7F6CFF-89DB-4A0F-8F4C-3F0C7E7235D8@acm.org> References: <805F9723-8298-4FD7-A47B-1E683721A5B0@acm.org> <835zegwn9y.fsf@gnu.org> <83mu7rvbyk.fsf@gnu.org> <729DE2D1-EA0F-46F9-8B4B-2ED146CE6892@acm.org> <83pncntbc2.fsf@gnu.org> <83o8s7tams.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="59194"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 40407@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 04 20:07:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jKnCL-000FJO-8w for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Apr 2020 20:07:13 +0200 Original-Received: from localhost ([::1]:41198 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKnCJ-0002oy-V1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Apr 2020 14:07:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38553) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKnCB-0002op-8l for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2020 14:07:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKnCA-0005i2-Bn for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2020 14:07:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33247) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jKnCA-0005ho-8p for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2020 14:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jKnCA-0007BX-3u for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2020 14:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Apr 2020 18:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40407 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 40407-submit@debbugs.gnu.org id=B40407.158602359427536 (code B ref 40407); Sat, 04 Apr 2020 18:07:02 +0000 Original-Received: (at 40407) by debbugs.gnu.org; 4 Apr 2020 18:06:34 +0000 Original-Received: from localhost ([127.0.0.1]:44793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKnBi-0007A4-6L for submit@debbugs.gnu.org; Sat, 04 Apr 2020 14:06:34 -0400 Original-Received: from mail1434c50.megamailservers.eu ([91.136.14.34]:35582 helo=mail263c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKnBg-00079Y-KS for 40407@debbugs.gnu.org; Sat, 04 Apr 2020 14:06:33 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1586023586; bh=sHhbXxhZIimD2pgSrApfqDBXE2fWNMqt9ssJtycePso=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=gYDqTXQR9C2COLBcF/Z2W0lW25Rp7ViixNFCdBzBsOtuqgJE5xGpSzUONiMEroLlj AQQsbaDGqhF80PGTYSgqNy02hJvne5sUn9OQtDD1n5SbEVVCEdAn+fOMwQNRi9a+SO hDBz0hISXSTmql26Pr2sAKFUcIYksMJo26KY44HM= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail263c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 034I6OTD019478; Sat, 4 Apr 2020 18:06:25 +0000 In-Reply-To: <83o8s7tams.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.14) X-CTCH-RefID: str=0001.0A782F25.5E88CC70.0074, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=e6d4tph/ c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=TomUGQFZFQpKtidUOcoA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178038 Archived-At: 4 apr. 2020 kl. 19.37 skrev Eli Zaretskii : > Btw, if we want this particular use case to be as fast as possible, > then Fcopy_sequence is not the best way, because it is not optimized > for the case of copying a single string. We could do better by > calling make_uninit_multibyte/unibyte_string and memcpy directly. Yes, if that would provide a benefit. The pattern should probably be = encapsulated in copy_string or similar, if it doesn't already exist. = (Should it copy properties? Probably not.)