From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Date: Sun, 1 Jan 2023 16:12:24 -0800 Message-ID: <0D5F2396-277A-4017-AE0B-371F591BD141@gmail.com> References: <7A5618C7-25D7-4B52-8D16-5C54F09FA4CA@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3392"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60376@debbugs.gnu.org, eliz@gnu.org, jostein@kjonigsen.net To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 02 01:13:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pC8SG-0000fx-PF for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Jan 2023 01:13:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pC8Rv-0003iz-VW; Sun, 01 Jan 2023 19:13:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC8Rq-0003id-VL for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 19:13:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pC8Rq-0004us-JZ for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 19:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pC8Rq-0006Ky-3S for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 19:13:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <7A5618C7-25D7-4B52-8D16-5C54F09FA4CA@gmail.com> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Jan 2023 00:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60376 X-GNU-PR-Package: emacs Original-Received: via spool by 60376-submit@debbugs.gnu.org id=B60376.167261835524310 (code B ref 60376); Mon, 02 Jan 2023 00:13:02 +0000 Original-Received: (at 60376) by debbugs.gnu.org; 2 Jan 2023 00:12:35 +0000 Original-Received: from localhost ([127.0.0.1]:42009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC8RO-0006K1-Qi for submit@debbugs.gnu.org; Sun, 01 Jan 2023 19:12:35 -0500 Original-Received: from mail-pg1-f180.google.com ([209.85.215.180]:41689) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC8RM-0006Jp-Pq for 60376@debbugs.gnu.org; Sun, 01 Jan 2023 19:12:33 -0500 Original-Received: by mail-pg1-f180.google.com with SMTP id 78so17475592pgb.8 for <60376@debbugs.gnu.org>; Sun, 01 Jan 2023 16:12:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=2Y7DQ2vZvext6PYMIYcAHubH7yMS55aV7uBoy4fBF4w=; b=HfaT9UrOjW2jXObc8KgnXYgfTlppkfV/LrIZh67qb5vqC025L056z18a3jCa/EMbYL eEv+oqX1nkJUGosd3RDhaU/w0dkBGSU8taa7BkZp0aFMVv+zPfqEx8lzd2I1E6ovU7VR cPCF/aPxywbSrnmaJJU9NvyM3fXSBwQezyQTaeJct/6qkpgaHbMCr7rz8O5dE2utOp1D iYq+70QjcGxWI7eBigNY9naRmN09FRr/LqS5YbZ03Civ+O7fV3UaO+NbkGomUlGqgxYI Rt7sq0QKzDSILpMAf3GcyAvCPwjgaYwU4w7QtBAgfRRGJezv5ua1Jdre1EPF0N5q+mDp aV/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2Y7DQ2vZvext6PYMIYcAHubH7yMS55aV7uBoy4fBF4w=; b=Ce68qAjkyBk1QD0GLDAobc0wcDkrXIwdJNRLAdpWVXTepv2pY8qogIjzuysMcQ2T8c 8YJUMR5t9RDfT9GsZjEZQg/Hqjdu4jme0+s5biwYnmwgGo7nqCL9BVloiHSfiZVmDm2+ I3OypgymXJyimZzu/3r+6I95JpOOlghm6OOukcAQBgiIc8E9HBHt+oyQsbEdUi+u4vRZ o1c/gqhoU4uRc6xODmV9yeluYBp1yYPXNDz0i1hUVTb9gXjTXA/8cEiOKHiCBwNrI+mH 9wlKnIfbZfaQpkCr/1XdrrCIqwac85P/Wdm1/8Cnw6kEyHq4KGJ0Z3rg8HuLa1vXJI/s M4rQ== X-Gm-Message-State: AFqh2kpsTWZIfNz2nRg/wAVAKU0NAsS7DYfGGNJAwrbkI/6/+zHcTAOE rlRZlnPFlhN2VFktKAL34xk= X-Google-Smtp-Source: AMrXdXuUMRonEhMJdjT1+WxCvPdYsgOHUfKv/8Sq5Iw1I7MBNy1pEnkmc7zH5slE+8AneH0ZE7UHGg== X-Received: by 2002:aa7:8a43:0:b0:576:f334:6740 with SMTP id n3-20020aa78a43000000b00576f3346740mr46783311pfa.23.1672618346787; Sun, 01 Jan 2023 16:12:26 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id 127-20020a620485000000b00574b86040a4sm17129408pfe.3.2023.01.01.16.12.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Jan 2023 16:12:26 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252294 Archived-At: Theodor Thornhill writes: > Jostein Kj=C3=B8nigsen writes: > >> On 01.01.2023 18:24, Jostein Kj=C3=B8nigsen wrote: >>> Disregard previous patch. >>> >>> Consider instead please the patch attached to this email. >>> >>> It does 3 things all in one: >>> >>> * moves function-call fontification to level 4 only (in its own = feature) >>> >>> * cleans up long-standing issues with "messy" rules for=20 >>> function-invocations. Removes the needs for "overrides". >>> >>> * also fixes issue with fonctification of self/this-method = invocations. >>> >>> Theo: Can you try this patch and see what you think? >>> >>> --=20 >>> >>> Jostein >> >> Disregard again (and sorry for the noise!) >> >> I've now gone through several files, done quite a bit of testing = myself,=20 >> and found another few issues needing to be solved: >> >> * Inconsistent variable-name fontification (sometimes when used, >> sometimes when declared, sometimes not when used, sometimes not = when >> declared) >> * Variable declaration with explicit generic types >> * new() expression fontification for generic types. >> * Bleeding type-face into brackets for generic return-types in = method >> definitions >> * Types when casting through as-expressions are not fontified at = all. >> * And more? >> >> I've solved those and combined all this into this latest patch, which=20= >> also moves function-invocation into its own (level 4) feature. >> >> This patch should be well beyond the "85%" which Eli has requested = for=20 >> Emacs-29 :) >> >> *Theo:* Could you give this a test-spin, and I promise to call it a = day? :) >> > > Hi! > > No worries at all, I'm just glad you found some inspiration :-) > > This looks good to me. I think we are are all set - there are at = least > no more features needed. I guess we can still add some tweaks to the > highlighting itself before the release? > > Yuan - you're next ;) > > Theo Fantastic! I applied the patch, thanks! Yuan