From: "Mattias Engdegård" <mattiase@acm.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 43598@debbugs.gnu.org
Subject: bug#43598: replace-in-string: finishing touches
Date: Sun, 27 Sep 2020 13:57:35 +0200 [thread overview]
Message-ID: <0CB4CF76-F4C1-447A-87A4-0CF120AB8A60@acm.org> (raw)
In-Reply-To: <87zh5b5tkz.fsf@gnus.org>
27 sep. 2020 kl. 13.48 skrev Lars Ingebrigtsen <larsi@gnus.org>:
> Didn't you just move the STRING_MULTIBYTE bits of the test from the
> string_ascii_p function and open-code it into Fstring_search function
> here?
No, look again. Previously, we would loop through all bytes of a unibyte needle before checking the lengths of a multibyte haystack. With the patch, we always do the cheap (length) check first. That's why that check had to be moved out of the helper function.
next prev parent reply other threads:[~2020-09-27 11:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 20:52 bug#43598: replace-in-string: finishing touches Mattias Engdegård
2020-09-24 21:12 ` Lars Ingebrigtsen
2020-09-24 21:19 ` Lars Ingebrigtsen
2020-09-24 23:18 ` Lars Ingebrigtsen
2020-09-25 9:21 ` Eli Zaretskii
2020-09-25 10:09 ` Lars Ingebrigtsen
2020-09-24 23:54 ` Lars Ingebrigtsen
2020-09-25 10:42 ` Mattias Engdegård
2020-09-25 11:11 ` Lars Ingebrigtsen
2020-09-25 11:22 ` Mattias Engdegård
2020-09-25 11:32 ` Lars Ingebrigtsen
2020-09-27 0:03 ` Lars Ingebrigtsen
2020-09-27 0:34 ` Lars Ingebrigtsen
2020-09-27 8:45 ` Mattias Engdegård
2020-09-28 3:41 ` Richard Stallman
2020-09-28 9:40 ` Mattias Engdegård
2020-09-29 3:29 ` Richard Stallman
2020-09-29 4:12 ` Eli Zaretskii
2020-09-27 11:12 ` Mattias Engdegård
2020-09-27 11:48 ` Lars Ingebrigtsen
2020-09-27 11:57 ` Mattias Engdegård [this message]
2020-09-27 12:02 ` Lars Ingebrigtsen
2020-09-27 16:14 ` Mattias Engdegård
2020-09-27 16:19 ` Eli Zaretskii
2020-09-27 16:41 ` Lars Ingebrigtsen
2020-09-27 16:48 ` Eli Zaretskii
2020-09-26 22:44 ` Lars Ingebrigtsen
2020-09-26 22:25 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0CB4CF76-F4C1-447A-87A4-0CF120AB8A60@acm.org \
--to=mattiase@acm.org \
--cc=43598@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).