From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#6695: 24.0.50; thing-at-point-url-at-point and ffap-guesser problem Date: Thu, 14 Jul 2011 09:29:19 -0700 Message-ID: <0C6ECB66B9154AEFB52AD5EDD9B54E6F@us.oracle.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1310662413 5616 80.91.229.12 (14 Jul 2011 16:53:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 14 Jul 2011 16:53:33 +0000 (UTC) Cc: 6695@debbugs.gnu.org To: "'Lars Magne Ingebrigtsen'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 14 18:53:27 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QhPAE-0002N7-P8 for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jul 2011 18:53:26 +0200 Original-Received: from localhost ([::1]:41149 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QhPAE-0000zF-1G for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jul 2011 12:53:26 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:36258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QhOnh-0005ES-RS for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2011 12:30:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QhOne-0001RL-Ad for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2011 12:30:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53870) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QhOnd-0001R6-Vy for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2011 12:30:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QhOnc-0004J7-VD; Thu, 14 Jul 2011 12:30:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Jul 2011 16:30:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6695-submit@debbugs.gnu.org id=B6695.131066097716474 (code B ref 6695); Thu, 14 Jul 2011 16:30:04 +0000 Original-Received: (at 6695) by debbugs.gnu.org; 14 Jul 2011 16:29:37 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhOnA-0004He-Av for submit@debbugs.gnu.org; Thu, 14 Jul 2011 12:29:36 -0400 Original-Received: from acsinet15.oracle.com ([141.146.126.227]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhOn8-0004HQ-R4 for 6695@debbugs.gnu.org; Thu, 14 Jul 2011 12:29:35 -0400 Original-Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by acsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p6EGTRc1025075 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 14 Jul 2011 16:29:28 GMT Original-Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p6EGTQgY009715 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 14 Jul 2011 16:29:26 GMT Original-Received: from abhmt106.oracle.com (abhmt106.oracle.com [141.146.116.58]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p6EGTLV8004678; Thu, 14 Jul 2011 11:29:21 -0500 Original-Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 14 Jul 2011 09:29:20 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcxCLqTv5DBw8p8IQEGbO1riX5DNAwAE7qKg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090202.4E1F1968.0111:SCFMA922111,ss=1,re=-4.000,fgs=0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 14 Jul 2011 12:30:04 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:49037 Archived-At: > These both return nil for me in Emacs 24. Yes. So it is still not fixed, but is broken in another way. Well, to be fair, punting and returning nil is not incorrect in the sense that it gives the wrong URL. It is incorrect in that it does not give the (correct) URL at all. It says, in effect, there is no URL at point, which is wrong. > > Neither of those is remotely correct. > > > > 3. Put the cursor on the g of Settings. > > M-: (ffap-guesser) => nil In the case of `ffap-guesser' it is perhaps too strong to say that a nil value indicates that there is no URL at point (as in the `thing-at-point' case). It is only claiming to "guess", whereas `thing-at-point' returning nil claims that there is no URL at point, and programs should be able to depend on that. > > What should happen: > > > > `ffap-guesser' should return > > "c:/Documents and Settings/foobar/My Documents/MyStuff/foo.pdf" > > > > `thing-at-point-url-at-point should return > > "http://c:/Documents and Settings/foobar/My > Documents/MyStuff/foo.pdf" > > I don't really see how guessing that these things are file names is > feasible. Why not? That's their job. > Unless one adds special matches for Windows where [letter]:/ matches > stuff until the end of the line or something... Maybe. Dunno. It would be good for someone knowledgable in thingatpt.el and ffap.el take a look and see how these cases can be improved. In the case of ffap.el, I guess you could call this an enhancement request, since returning `nil' is just giving up and saying it has no "guess". In the case of thingatpt.el, this is a bug: it claims incorrectly that there is no URL at point.