bug#59477: python-tests fail without tree-sitter

["Mattias Engdegård" <mattias.engdegard@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

Oh, there is one more test in python-tests that fails (on my Mac at least): `python-ffap-module-path-1`. It was added fairly recently (see bug#58713) so I'm not sure it was already broken at the time or if that is a recent change. CC:ing the author and attaching the test log.


[-- Attachment #2: python-ffap-module-path-1.log --]
[-- Type: application/octet-stream, Size: 2774 bytes --]

Test python-ffap-module-path-1 backtrace:
  signal(ert-test-failed (((should (file-exists-p (python-ffap-module-
  ert-fail(((should (file-exists-p (python-ffap-module-path "abc"))) :
  (if (unwind-protect (setq value-3262 (apply fn-3260 args-3261)) (set
  (let (form-description-3264) (if (unwind-protect (setq value-3262 (a
  (let ((value-3262 'ert-form-evaluation-aborted-3263)) (let (form-des
  (let* ((fn-3260 #'file-exists-p) (args-3261 (condition-case err (let
  (let ((inhibit-message t)) (python-shell-send-buffer) (python-tests-
  (progn (run-python nil t) (insert "\nimport abc\n") (goto-char (poin
  (unwind-protect (progn (run-python nil t) (insert "\nimport abc\n") 
  (let ((python-indent-guess-indent-offset nil) (python-shell-completi
  (progn (let ((python-indent-guess-indent-offset nil) (python-shell-c
  (unwind-protect (progn (let ((python-indent-guess-indent-offset nil)
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
  (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
  (closure (t) nil (let* ((fn-3255 #'executable-find) (args-3256 (cond
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name python-ffap-module-path-1 :documentat
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
  ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
  ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
  eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
  command-line-1(("-L" ":../../emacs/test" "-l" "ert" "-l" "lisp/progm
  command-line()
  normal-top-level()
Test python-ffap-module-path-1 condition:
    (ert-test-failed
     ((should
       (file-exists-p
	(python-ffap-module-path "abc")))
      :form
      (file-exists-p "__PYTHON_EL_eval(\"\\ndef __FFAP_get_module_path(objstr):\\n    try:\\n        import inspect\\n        import os.path\\n        # NameError exceptions are delayed until this point.\\n        obj = eval(objstr)\\n        module = inspect.getmodule(obj)\\n        filename = module.__file__\\n        ext = os.path.splitext(filename)[1]\\n        if ext in ('.pyc', '.pyo'):\\n            # Point to the source file.\\n            filename = filename[:-1]\\n        if os.path.exists(filename):\\n            return filename\\n        return ''\\n    except:\\n        return ''\\nprint(__FFAP_get_module_path(\\\"abc\\\"))\", \"<string>\")\15\n/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/abc.py")
      :value nil))
   FAILED   18/312  python-ffap-module-path-1 (0.405063 sec) at ../../emacs/test/lisp/progmodes/python-tests.el:4567

[-- Attachment #3: Type: text/plain, Size: 284 bytes --]



This looks like an error when parsing output from Python, mistaking input for output.

(How we ended up parsing a buffer containing both input, output and prompts intermingled is anyone's guess -- it doesn't look like a very reliable way of doing it, and evidently isn't.)