From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59628: 29.0.50; treesit-beginning/end-of-defun problems in C/C++ Date: Wed, 30 Nov 2022 15:07:45 -0800 Message-ID: <0A2994D9-54DC-48EC-8705-46893A962442@gmail.com> References: <83v8n0puxi.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2491"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eliz@gnu.org, 59628@debbugs.gnu.org To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 01 00:08:32 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0WBr-0000TB-Sn for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Dec 2022 00:08:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0WBW-0004eJ-0D; Wed, 30 Nov 2022 18:08:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0WBS-0004dw-Ox for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 18:08:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0WBO-0001YD-SZ for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 18:08:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0WBO-00058U-7Z for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 18:08:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <83v8n0puxi.fsf@gnu.org> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2022 23:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59628 X-GNU-PR-Package: emacs Original-Received: via spool by 59628-submit@debbugs.gnu.org id=B59628.166984967919736 (code B ref 59628); Wed, 30 Nov 2022 23:08:02 +0000 Original-Received: (at 59628) by debbugs.gnu.org; 30 Nov 2022 23:07:59 +0000 Original-Received: from localhost ([127.0.0.1]:35655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0WBL-00058G-9B for submit@debbugs.gnu.org; Wed, 30 Nov 2022 18:07:59 -0500 Original-Received: from mail-pg1-f169.google.com ([209.85.215.169]:35414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0WBG-000589-Bf for 59628@debbugs.gnu.org; Wed, 30 Nov 2022 18:07:58 -0500 Original-Received: by mail-pg1-f169.google.com with SMTP id f3so99772pgc.2 for <59628@debbugs.gnu.org>; Wed, 30 Nov 2022 15:07:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=7IusTvvCZsLA1Zp9IH8P0kAfQlkeNFlsDaFCtHdvJrY=; b=ARx7/j/815BEINWTKLOVynZaJOGP5+ObrQanfTuu/JxbM7PTl+h9P8+AUbtiroVT7x wfOGe/WWfb17mnviSBq6WhUFlW1uBem5KDcd90Z9DZYdjLz2UDA/Od3LsFQ+n6pNu4Fw LrsVG5DhRKOhpYBJOrZm0iHuvhDQAEJM/LXMJp2h+pSVpwl3ecjgkKQ47NLmWASRs8M/ Q6ITWk8xPZOmibDFF2I5F115c/ufvNkWIqVACfHsaymhsabBRafZa7bgFJj0r1VKnAdP f8EtjXhIZoWXQxzNBNTEvXQZT62gXP8dVNQS+l2TWpdUB7WWj3s4sM/cX6WQj6iaG0up mbHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7IusTvvCZsLA1Zp9IH8P0kAfQlkeNFlsDaFCtHdvJrY=; b=EvzOKzqZOS6aU0cEhNLKo1pXEVKl4mPeCOCC19+m6nW6xlJVm5hJhUP0phfcUALpSu nhGTbbWIpcQVUvZH8idWlBQ6yaPiSx/Ckh/31fT5MXdFArHxZiGSrHgkrttNw/tYCXpN DSHlZdAVcHSnjChuh2FkT7nUBOu0Y6jZ90mQkmzGMmd22NngHWFBBobHKWvRS6sEIrnm f0e9CKmQLlIi3JyV1kVI8nGqQ+jnZXaQoDo/xDFtAdqOd8yH3wIkvxGPtUiVEkEsC6rl k6CYFzON8RBCDvuw4VIzrtvQjXxSMq8GkwE4QmLnbewEQv5tdKFonJDJJvj360EFGhcW +7Jw== X-Gm-Message-State: ANoB5pmyuau3po0AYAo3Roj9D1iBYHliA848niWmPNut1P586zsLkoMr 8Avd7eeDpFf6Ft0dx3mFHAM= X-Google-Smtp-Source: AA0mqf4PuwgVuFiYUi4NgWiIfg7kM7htzv7isk+k24Ccv0aqms6KabPoKnZQIE4QuTX1LWBBAqJOKA== X-Received: by 2002:aa7:8595:0:b0:574:3ccd:a468 with SMTP id w21-20020aa78595000000b005743ccda468mr39538782pfn.61.1669849668129; Wed, 30 Nov 2022 15:07:48 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id t15-20020a170902e84f00b00188c9c11559sm2080749plg.1.2022.11.30.15.07.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Nov 2022 15:07:47 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249579 Archived-At: Daniel Mart=C3=ADn writes: > Yuan Fu writes: > >> >> Different languages have different grammars that give different names = to >> function definitions and class definitions. So it is necessary to = have a >> regexp variable. Finding such a regexp isn=E2=80=99t too hard, so I = don=E2=80=99t think >> we need a default value. If we do have a default, it would be often = wrong, >> given differences between language grammars. > > I see that each major mode sets the value of that buffer-local = variable. > c-ts-mode sets it to "\\(?:definition\\|specifier\\)" but, is that > correct? In C code, treesit-explore-mode shows function definition > nodes as "function_definition", so I think the regexp is matching more > nodes than expected, causing C-M-a C-M-e to move to weird places in = the > buffer. Right, I=E2=80=99ve fixed the value in 599369bf3a3. Yuan