From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression Date: Wed, 30 Nov 2022 19:10:04 +0100 Message-ID: <0A18F996-F3BB-4A7D-A0BE-76C8374DE517@thornhill.no> References: <831qpklejb.fsf@gnu.org> <83mt88jul4.fsf@gnu.org> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33461"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59691@debbugs.gnu.org, casouri@gmail.com, jostein@secure.kjonigsen.net, jostein@kjonigsen.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 30 19:13:42 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0RaX-0008R2-Ai for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Nov 2022 19:13:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0RZx-0003bM-CN; Wed, 30 Nov 2022 13:13:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0RZv-0003az-4S for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 13:13:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0RZu-0000gU-F1 for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 13:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0RZt-0001kW-Vn for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 13:13:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2022 18:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59691 X-GNU-PR-Package: emacs Original-Received: via spool by 59691-submit@debbugs.gnu.org id=B59691.16698319276707 (code B ref 59691); Wed, 30 Nov 2022 18:13:01 +0000 Original-Received: (at 59691) by debbugs.gnu.org; 30 Nov 2022 18:12:07 +0000 Original-Received: from localhost ([127.0.0.1]:34237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0RZ0-0001k7-Ja for submit@debbugs.gnu.org; Wed, 30 Nov 2022 13:12:06 -0500 Original-Received: from out2.migadu.com ([188.165.223.204]:62903) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0RYy-0001k0-6S for 59691@debbugs.gnu.org; Wed, 30 Nov 2022 13:12:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1669831922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=baxnqUyzAN647zJSN4qIa9DA8mPdeecKVOaJwOj5qMg=; b=U07Rap6lrF11RdEpTby1IAxcOZ1g+JPRrkT/0QkGFaebjJJ26pG1HyPOJXR3R4fX2DChrc sv6FWPe9lxh1/3W6iaRIk8jr2bUBEG5vLKy1iqZ4FrHkqoE0XRNM2hM/i+TYc0Ph/ZbkSy ZRK1YPClxZYP8ILblze5hgvROwDDI2rjkLlA2bm3n6TDNwub+Uwi1DM4zXUloqJ9lTOdQ8 p/pXYyxCvgh4A+3RsLuMj5DF/DFRJ8RPVUacPvPeW1ep9hmZKRYevfe7LEL/kVjhW5TLVN XEphgHeW5LroOoruhh6/2TVejIR6j6uJ3hjoKdGpX+suMRzYuffaM8kdEa0jXg== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: <83mt88jul4.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249541 Archived-At: On 30 November 2022 17:05:59 CET, Eli Zaretskii wrote: >> Date: Wed, 30 Nov 2022 16:21:37 +0100 >> From: Theodor Thornhill >> CC: jostein@secure=2Ekjonigsen=2Enet, 59691@debbugs=2Egnu=2Eorg, jostei= n@kjonigsen=2Enet >>=20 >> >> No strong opinions here, but currently a user could install >> >> tree-sitter-js, and find and enable js-ts-mode, which is >> >> straightforward, which is good=2E Since these four modes doesn=E2=80= =99t require >> >> too much boilerplate, I think it=E2=80=99s pretty good right now=2E >> > >> >Can we do that automatically? For example, can typescript-ts-mode cal= l >> >js-ts-mode when it detects that it is necessary? >>=20 >> That's not what we want=2E=20 >>=20 >> There are three languages here from treesitters pov=2E >>=20 >> Typescript >> Tsx >> JavaScript >>=20 >> They are all different, and should be treated as such, imo :) > >Our automatic turning-on of major-modes looks at the file-name extension = and >little else (magic-mode-alist is not useful here)=2E So if a file whose >extension is XYZ can have more than one applicable major-mode, we should = try >to do something to turn on the correct mode automatically=2E What can we= do? We are lucky because the extensions in question are ts, tsx and js=2E So w= e don't need any smartness :) Theo