unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Mauro Aranda <maurooaranda@gmail.com>
To: 66556@debbugs.gnu.org
Subject: bug#66556: 30.0.50; Missing choice in eglot-report-progress :type
Date: Sun, 15 Oct 2023 10:45:42 -0300	[thread overview]
Message-ID: <09d35f15-66aa-450b-b57e-4294815d5434@gmail.com> (raw)
In-Reply-To: <00812df9-b826-480a-8483-57a455df97ad@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 40 bytes --]

tags 66556 patch
quit


Patch attached.

[-- Attachment #2: 0001-Fix-eglot-report-progress-type.patch --]
[-- Type: text/x-patch, Size: 1075 bytes --]

From 89b13f8dccd0cc14e78e9d953375da6dcc034103 Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Sun, 15 Oct 2023 10:43:50 -0300
Subject: [PATCH] Fix eglot-report-progress :type

* lisp/progmodes/eglot.el (eglot-report-progress): Change :type to
choice, to allow 'messages' as a value.  (Bug#66556)
---
 lisp/progmodes/eglot.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index e511df01850..da92647bc93 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -467,7 +467,9 @@ eglot-report-progress
   "If non-nil, show progress of long running LSP server work.
 If set to `messages', use *Messages* buffer, else use Eglot's
 mode line indicator."
-  :type 'boolean
+  :type '(choice (const :tag "Don't show progress" nil)
+                 (const :tag "Show progress in *Messages*" messages)
+                 (const :tag "Show progress in Eglot's mode line indicator" t))
   :version "1.10")
 
 (defcustom eglot-ignored-server-capabilities (list)
-- 
2.34.1


  reply	other threads:[~2023-10-15 13:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-15 13:40 bug#66556: 30.0.50; Missing choice in eglot-report-progress :type Mauro Aranda
2023-10-15 13:45 ` Mauro Aranda [this message]
2023-10-15 14:24   ` Stefan Kangas
2023-10-15 15:00     ` Mauro Aranda
2023-10-21 10:06       ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09d35f15-66aa-450b-b57e-4294815d5434@gmail.com \
    --to=maurooaranda@gmail.com \
    --cc=66556@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).