From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#50244: 28.0.50; Support project-wide diagnostics reports in flymake.el Date: Fri, 17 Sep 2021 01:27:33 +0300 Message-ID: <09d26dd2-b27b-1f5b-b1b7-a72330ec6dd7@yandex.ru> References: <87bl5hm5qj.fsf@gmail.com> <87y283536t.fsf@gmail.com> <41cd4854-d162-bc6c-900e-96a4245e2c59@yandex.ru> <87o88w4al4.fsf@gmail.com> <061838b7-bf19-b899-f1aa-76760fb35607@yandex.ru> <87wnnj36vx.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37724"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Cc: 50244@debbugs.gnu.org, Philipp Stephani , Theodor Thornhill To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 17 00:28:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQzrW-0009eP-Vb for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Sep 2021 00:28:10 +0200 Original-Received: from localhost ([::1]:51910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQzrV-00049D-09 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Sep 2021 18:28:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQzrO-000491-SF for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 18:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45229) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQzrO-0001KC-Ko for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 18:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQzrO-0001Py-HW for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 18:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Sep 2021 22:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50244 X-GNU-PR-Package: emacs Original-Received: via spool by 50244-submit@debbugs.gnu.org id=B50244.16318312635422 (code B ref 50244); Thu, 16 Sep 2021 22:28:02 +0000 Original-Received: (at 50244) by debbugs.gnu.org; 16 Sep 2021 22:27:43 +0000 Original-Received: from localhost ([127.0.0.1]:56775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQzr5-0001PN-FN for submit@debbugs.gnu.org; Thu, 16 Sep 2021 18:27:43 -0400 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:36683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQzr3-0001P7-VW for 50244@debbugs.gnu.org; Thu, 16 Sep 2021 18:27:42 -0400 Original-Received: by mail-wr1-f46.google.com with SMTP id g16so11890579wrb.3 for <50244@debbugs.gnu.org>; Thu, 16 Sep 2021 15:27:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DZ8y3M51azuZ5Kf2cr/BfSsPKWmb/RDFbZxfjJ3uetc=; b=o3bn836WEdGKl/fyZ2cPpqAkB3eJGcu4M60lfvWUCJNEyBtGKBN9CWcOD0Hygx+XkQ nqpYS45XpqgGKrXt0S8XcVn/apCFSXpK7lsfYkNuk4OD0i9U//+KAcXch/HBydRNqPei NtiMwDPUle/cuoC2Nl0JSasqHHyCkvU4f11u5ct2Le1WUPD1WohuV8NE2NPcdWY5DMpZ J1vqgMkLYorpeBVrYZHAS2eADz400PwPB8ul5VBICeaKBehtF85dzpfNifwFwd79r3Zd JW4Mx6NrrJoyUjRKHV9wU+wTuiHqctabD8tmitgtKB1pr9WRZWbjd2B9lq4Yc8zrqISw g7HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DZ8y3M51azuZ5Kf2cr/BfSsPKWmb/RDFbZxfjJ3uetc=; b=syXcYjUk/aEP+4o/n9NgTsKtBJ5XObsTycV8WMQBSbjVDrwEF0B4TSGrD1jTcXBvJi yBJK145ydP+pePtB+i0F3TW8ycmCRXkEPyc2kU2ZSrp3iYOgw+8JkNRbJTK367u7F5p3 2UjVgBwA56D9h3wxyZSBS2+8qR782RK7k+OvH6s0LNyNI5yqnM2r3Or5qDkktXXVhR4h 4gATQxkjNXwGTGk0TLhMdLg2VbhLvbVrAbSyOEK96wfxlUJx7i+6XjaXOoOBLuf1Se04 ryPzvB6Ws2WoIR7LYkYud3lfSCLQpPKkn8bXLNa+sn34TWRAbalfc86ouTphg2ueIIyV KgUg== X-Gm-Message-State: AOAM533JDOCOHpISTdWSQZUYGs6FusyqJet/0xHr5Hp4RxRDIWjZj7YK QZOXqjx5tr4+Wnkb1+eMjPI= X-Google-Smtp-Source: ABdhPJwAVpfqaHsJ1gB9YQFXmSNb8Y6+Hn1SWWJjdfWAyrxh3Qb3nsNTKogR+ERsuNHfltTrKSWSSQ== X-Received: by 2002:a5d:4985:: with SMTP id r5mr8731343wrq.397.1631831256177; Thu, 16 Sep 2021 15:27:36 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id v17sm4687745wrr.69.2021.09.16.15.27.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Sep 2021 15:27:35 -0700 (PDT) In-Reply-To: <87wnnj36vx.fsf@gmail.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214511 Archived-At: On 14.09.2021 11:20, João Távora wrote: >> Like mentioned previously, I think using project.el for this is >> probably not ideal (rather, the diagnostic source can decide which >> diagnostics belong to the current default-directory), > Yes, it can, and it does (have you read the change?) In fact the > diagnostic source knows nothing about projects. But at a certain point, > someone will have to know about "projects", because the request is not > for "default-directory-wide diagnostics", it's for project-wide > diagnostics. I don't know what better library to use for segregating > diagnostics into projects other than project.el: it works quite well, to > be frank. When I said "belong to default-directory", I didn't mean "reside inside". I meant "all diagnostics that, in the opinion of the diagnostics source, relate to the specified default-directory". Basically all diagnostics belonging to the project which default-directory belongs to (with implicit assumption that default-directory can uniquely identify the project). > Indeed, I even thought that flymake-show-project-diagnostics could go into the 'C-x p' map. But users can do that easily if they want to, so I won't argue for that now. Uh, maybe. I was thinking we'd rather add a new keymap (in the spirit of Flycheck's 'C-c !') with Flymake-related commands. Then the "aggregated diagnostics" could be on its own button, or they could even be displayed by 'M-x flymake-show-diagnostics-buffer'.