From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?Lindstr=C3=B6m?= Newsgroups: gmane.emacs.bugs Subject: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline Date: Wed, 12 Jun 2024 07:21:04 +0200 Message-ID: <09bb792d-3a3c-46b0-8e42-193f62bc11c2@app.fastmail.com> References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=ef95b6c42da54744ab2942a5d8a8894a Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6727"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.11.0-alpha0-515-g87b2bad5a-fm-20240604.001-g87b2bad5 To: 71499@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 12 07:22:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sHGRJ-0001XE-99 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Jun 2024 07:22:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sHGQx-0007mk-6y; Wed, 12 Jun 2024 01:22:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHGQt-0007mJ-Pg for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2024 01:22:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sHGQt-0001aq-HX for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2024 01:22:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sHGQr-0000Ra-Vq for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2024 01:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?Lindstr=C3=B6m?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2024 05:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71499 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71499-submit@debbugs.gnu.org id=B71499.17181697131689 (code B ref 71499); Wed, 12 Jun 2024 05:22:01 +0000 Original-Received: (at 71499) by debbugs.gnu.org; 12 Jun 2024 05:21:53 +0000 Original-Received: from localhost ([127.0.0.1]:37335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHGQi-0000RB-U3 for submit@debbugs.gnu.org; Wed, 12 Jun 2024 01:21:53 -0400 Original-Received: from fout3-smtp.messagingengine.com ([103.168.172.146]:36591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHGQg-0000Qp-RO for 71499@debbugs.gnu.org; Wed, 12 Jun 2024 01:21:51 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailfout.nyi.internal (Postfix) with ESMTP id 66DC913800FF for <71499@debbugs.gnu.org>; Wed, 12 Jun 2024 01:21:46 -0400 (EDT) Original-Received: from imap43 ([10.202.2.93]) by compute3.internal (MEProxy); Wed, 12 Jun 2024 01:21:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h=cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1718169706; x=1718256106; bh=mBaPCSDPyh 49I/0zvr/YFGVJ4SlocfYbSsJZSyUeTZY=; b=D5C5ON2OxId4bBzGHfSmddw72T xl3rk7T2jqfwxtedE1jT4qk1GGU5IU4MZYiH7SBMmJoJTdhPJz0dLh7ktPmUxFBn +OdB4KxZrx2YUmubTkO9lCjWLe4bpUA/zhvc/t80QRaLVNB5mqM0EEL9Eei9xVgg l+lHKUaA94wmQuutO4qMLUKE0PxpR+wFXSvVczfjmjZEQ+QM0fLLJjJMY3lWHRwV AP48sr4fW4vtFD6hwG/4KQSYpflJDuDN4OVeQ2pVVf7qdvmP4NLXzuSqEsJTYN53 hDRAMTtBDX/1+lhh+3+516z4RqD4NRQTJ2pXfvqcs+xKlDaiTe1rd9SZJBcA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1718169706; x=1718256106; bh=mBaPCSDPyh49I/0zvr/YFGVJ4Slo cfYbSsJZSyUeTZY=; b=Xl9Wa/pDaAX+pobxggOE4ZbpX91S2u9G5QBQi+i9DQ4j WfayqDP7CAMYm4mp3leNHr+Gqek8FJv59Z4DwpOE2P3bxPaM3qcVCKwJlachkqz1 dN8mMHOLhwoHGj5yIL+tHjBavlMFFFeiqxQngJkBnAlh8MtimDLAIPh9GvqXBgcA qy35+b3D930g8KJXZOKIXk4uJTiUeQzUsgITcW13EkhlIqfWIK5NTs6nSS3blhEB bfjKZXlKmBpVbnVeFVe0DZMho3sOCoZTPAFzvuikDz8InW2f3QSBDwR8Jto++q2u Lqku+u3tU56WDHL/LdiBODe7NivqF7ygm7dlcIUHGA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedufedgleduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvufgtsehmtd erreerreejnecuhfhrohhmpeeujhpnrhhnucfnihhnughsthhrnphmuceosghkhhhlsegv lhgvkhhtrhhusggrughurhdrshgvqeenucggtffrrghtthgvrhhnpeettddvjefhleevke fhjeeigfeijeeflefgvedtveffueeufeffudevkeeuueekfeenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegskhhhlhesvghlvghkthhruhgsrg guuhhrrdhsvg X-ME-Proxy: Feedback-ID: i05c146bc:Fastmail Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id DE82A2D405B3; Wed, 12 Jun 2024 01:21:45 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287133 Archived-At: --ef95b6c42da54744ab2942a5d8a8894a Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Jun 11, 2024, at 20:16, Bj=C3=B6rn Lindstr=C3=B6m wrote: > Hello, > > attaching patch to make the whitespace-cleanup and=20 > whitespace-cleanup-region functions add a final newline to a file if=20 > whitespace-style contains `missing-newline-at-eof > > I'm aware this somewhat replicates what setting `require-final-newline=20 > would do, but I think since whitespace.el with this configuration=20 > highlights this as an error, it should also clean it up when asked. > > Best wishes, > Bj=C3=B6rn > Attachments: > * 0001-Make-whitespace.el-cleanup-add-missing-final-newline.patch Sorry, somehow messed up the first patch I sent, now attaching a correct= ed one. Attaching the correct one here. Best wishes, Bj=C3=B6rn --ef95b6c42da54744ab2942a5d8a8894a Content-Disposition: attachment; filename*0="0001-Make-whitespace.el-cleanup-add-missing-final-newline-2.p"; filename*1="atch" Content-Type: text/x-patch; name="=?UTF-8?Q?0001-Make-whitespace.el-cleanup-add-missing-final-newline-2.pa?= =?UTF-8?Q?tch?=" Content-Transfer-Encoding: BASE64 RnJvbSAzZTE4MDY3NDYwNGY0MWRlNzAxOThjM2FhYTNiMGJjNWNkZGYwYTY4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Qmo9QzM9QjZybj0yMExpbmRzdHI9 QzM9QjZtPz0gPGJraGxAZWxla3RydWJhZHVyLnNlPgpEYXRlOiBUdWUsIDExIEp1biAyMDI0 IDE5OjQ5OjU1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gTWFrZSB3aGl0ZXNwYWNlLmVsIGNs ZWFudXAgYWRkIG1pc3NpbmcgZmluYWwgbmV3bGluZQoKKiBsaXNwL3doaXRlc3BhY2UuZWwg KHdoaXRlc3BhY2UtY2xlYW51cC1yZWdpb24pOiBpZiBjbGVhbmluZyB1cCBhdCBlbmQKb2Yg ZmlsZSwgYWRkIG1pc3NpbmcgbmV3bGluZSBpZiBpbmRpY2F0ZWQgYnkgd2hpdGVzcGFjZS1z dHlsZS4KLS0tCiBsaXNwL3doaXRlc3BhY2UuZWwgfCAxNCArKysrKysrKysrKysrLQogMSBm aWxlIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1n aXQgYS9saXNwL3doaXRlc3BhY2UuZWwgYi9saXNwL3doaXRlc3BhY2UuZWwKaW5kZXggYmMy M2E4Nzk0ZWIuLjZmOGJkMGI4NTg1IDEwMDY0NAotLS0gYS9saXNwL3doaXRlc3BhY2UuZWwK KysrIGIvbGlzcC93aGl0ZXNwYWNlLmVsCkBAIC0xNDY1LDYgKzE0NjUsMTEgQEAgZGVmdW4g d2hpdGVzcGFjZS1jbGVhbnVwLXJlZ2lvbgogICAgSWYgYHdoaXRlc3BhY2Utc3R5bGUnIGlu Y2x1ZGVzIHRoZSB2YWx1ZQogICAgYHNwYWNlLWFmdGVyLXRhYjo6c3BhY2UnLCByZXBsYWNl IFRBQnMgYnkgU1BBQ0VzLgogCis1LiBtaXNzaW5nIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUu CisgICBJZiBgd2hpdGVzcGFjZS1zdHlsZScgaW5jbHVkZXMgdGhlIHZhbHVlIGBtaXNzaW5n LW5ld2xpbmUtYXQtZW9mJywKKyAgIGFuZCB0aGUgY2xlYW51cCByZWdpb24gaW5jbHVkZXMg dGhlIGVuZCBvZiBmaWxlLCBhZGQgYSBmaW5hbCBuZXdsaW5lCisgICBpZiBpdCBpcyBub3Qg dGhlcmUgYWxyZWFkeS4KKwogU2VlIGB3aGl0ZXNwYWNlLXN0eWxlJywgYGluZGVudC10YWJz LW1vZGUnIGFuZCBgdGFiLXdpZHRoJyBmb3IKIGRvY3VtZW50YXRpb24uIgogICAoaW50ZXJh Y3RpdmUgIkByIikKQEAgLTE1NDUsNyArMTU1MCwxNCBAQCBkZWZ1biB3aGl0ZXNwYWNlLWNs ZWFudXAtcmVnaW9uCiAgICAgICAgICAoKG1lbXEgJ3NwYWNlLWJlZm9yZS10YWI6OnNwYWNl IHdoaXRlc3BhY2Utc3R5bGUpCiAgICAgICAgICAgKHdoaXRlc3BhY2UtcmVwbGFjZS1hY3Rp b24KICAgICAgICAgICAgJ3VudGFiaWZ5IHJzdGFydCByZW5kCi0gICAgICAgICAgIHdoaXRl c3BhY2Utc3BhY2UtYmVmb3JlLXRhYi1yZWdleHAgMikpKSkKKyAgICAgICAgICAgd2hpdGVz cGFjZS1zcGFjZS1iZWZvcmUtdGFiLXJlZ2V4cCAyKSkpCisgICAgICAgIDs7IFBST0JMRU0g NTogbWlzc2luZyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCisgICAgICAgICh3aGVuIChhbmQg KG1lbXEgJ21pc3NpbmctbmV3bGluZS1hdC1lb2Ygd2hpdGVzcGFjZS1zdHlsZSkKKyAgICAg ICAgICAgICAgICAgICAoPSAocG9pbnQtbWF4KSAod2l0aG91dC1yZXN0cmljdGlvbiAocG9p bnQtbWF4KSkpKQorICAgICAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1heCkpCisgICAgICAg ICAgKHdoZW4gKHJlLXNlYXJjaC1iYWNrd2FyZCAiLlxcJyIgbmlsIHQpCisgICAgICAgICAg ICAoZ290by1jaGFyIChwb2ludC1tYXgpKQorICAgICAgICAgICAgKGluc2VydCAiXG4iKSkp KQogICAgICAgKHNldC1tYXJrZXIgcmVuZCBuaWwpKSkpCQk7IHBvaW50IG1hcmtlciB0byBu b3doZXJlCiAKIAotLSAKMi40NS4yCgo= --ef95b6c42da54744ab2942a5d8a8894a--