From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: John Cummings Newsgroups: gmane.emacs.bugs Subject: bug#50630: [PATCH] Add tests for insert-directory Date: Sat, 25 Sep 2021 12:13:26 +0000 Message-ID: <09Q2_4ijvzbpkXBOIHRu07ASyULhwDIyz2tesdh7TeKgTPIM2C5Fzorc5-z7hYpNpQ37xG25Nz7SXR9Uw2I7QolyUPk8wu-FxaE8KekDbPA=@rootabega.net> References: <87ee9dqvcu.fsf@gnus.org> <87v92o9979.fsf@gmx.de> Reply-To: John Cummings Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35338"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "50630@debbugs.gnu.org" <50630@debbugs.gnu.org>, Lars Ingebrigtsen To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 25 14:14:28 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mU6ZW-0008tm-IH for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 14:14:26 +0200 Original-Received: from localhost ([::1]:32774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mU6ZU-0002zl-JR for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 08:14:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mU6Z8-0002wu-6e for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 08:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48827) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mU6Z7-0001bd-QP for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 08:14:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mU6Z7-0002bi-Jw for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 08:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: John Cummings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Sep 2021 12:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50630 X-GNU-PR-Package: emacs Original-Received: via spool by 50630-submit@debbugs.gnu.org id=B50630.16325720209972 (code B ref 50630); Sat, 25 Sep 2021 12:14:01 +0000 Original-Received: (at 50630) by debbugs.gnu.org; 25 Sep 2021 12:13:40 +0000 Original-Received: from localhost ([127.0.0.1]:60373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mU6Ym-0002am-2Q for submit@debbugs.gnu.org; Sat, 25 Sep 2021 08:13:40 -0400 Original-Received: from mail-40131.protonmail.ch ([185.70.40.131]:10916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mU6Yk-0002aT-2a for 50630@debbugs.gnu.org; Sat, 25 Sep 2021 08:13:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rootabega.net; s=protonmail; t=1632572007; bh=OJL58CPh6v5G5Qd922DiiN/ah/lC2q9+Ek/y2mqKL8E=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=mPGNl0Qok4TK9CkxnVNkA1mPlEYGCXOv6KzGttYkNQbfiDF+FvbFTGNc47j8o+ckf Rpw5BdQDk9qR5C7xTzs1/ZzT32TSsvSP96/OWPHjOvLAuy7Ybo3+FKt9iels897+F6 Y9pIThuSt9J/+EJpzgbrEIw2xH/eas08Vme0h6XaPwqSlGe4ud3nGyoI+4o5FnfeSo 6PlkJv4O+53KJrSFx1cm8CS3/1g6D5nor8gokg1uwwKNGpG6+Z6d+2CfgGDszmCYUu camVzeVXyLMvNsl9iGbnWDMjoncdOpKmNNvXUWm/l9klvTJpAhY3xv/zEykgTQt+V+ eFEf+Inx6qHgw== In-Reply-To: <87v92o9979.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215435 Archived-At: Michael Albinus wrote: > For Tramp (I'm the maintainer) I don't care whether it is a separate bug > number, or not. Thanks Michael, I appreciate the guidance and flexibility. I see how what looks like a single simple bug could end up lumping together a bunch of otherwise unrelated maintainers or contributors, so if separate bugs turns out to be the decision, so be it. I will certainly keep this in mind if I run into a bug which is larger or more complex, or can't be fixed quickly enough to make it into the same release. > If you want to add/extend a regression test for the > Tramp case, you might check whether tramp-test17-insert-directory in > test/lisp/net/tramp-tests.el is a proper place. The test17 test(s) came up on my radar while I was trying to measure the extent of the bug. I will make sure that I give good consideration to possibly extending those tests instead of only adding new ones. From what I remember, even though several existing tramp tests called insert-directory, they were orthogonal to the free space aspect.