unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jared Finder via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 43756@debbugs.gnu.org, larsi@gnus.org
Subject: bug#43756: Fix for TTY menus mouse interaction
Date: Fri, 02 Oct 2020 12:54:54 -0700	[thread overview]
Message-ID: <094def0cf664c29c513b0686929eb808@finder.org> (raw)
In-Reply-To: <83k0w8e7z8.fsf@gnu.org>

On 2020-10-02 12:35 pm, Eli Zaretskii wrote:
>> Cc: 43756@debbugs.gnu.org
>> Date: Fri, 02 Oct 2020 09:45:33 -0700
>> From: Jared Finder via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>> 
>> * Emacs repo from git://git.sv.gnu.org/emacs.git, commit
>> f6277911eb2c520aec8f0efd80c91999226e3322
>> * Run on Debian under Windows Subsystem for Linux 2 (the VM version).
>> I've also seen this on MacOS and native Win32 builds of Emacs.
> 
> Native Windows build doesn't support xterm-mouse, and the native mouse
> clicks work correctly there.  If you have a recipe for the native
> Windows build that shows incorrect menus popping down, please show
> that.

On Windows builds, only the M-x tmm-menubar step is broken, with the 
order in the displayed menu bar being different then in the tmm-menubar 
popup. This is *only* about text based menus, not the native platform 
ones.

>> emacs -Q
>> M-x ielm
>> M-x xterm-mouse-mode
> 
> Ah, xterm-mouse-mode.  AFAIR, no one has made TTY menus work with
> xterm-mouse-mode.  The first thing to do is to disable tmm-menubar,
> and then you need to cause a mouse click call menu-bar-open with the
> 2nd argument set to the X coordinate of the click.

I think this may be getting mixed up with my feature proposal on 
emacs-devel? I did find this bug when working on making the TTY menus 
work with xterm-mouse-mode and they both affect menus. The patches I 
attached in that thread follow the pattern you described.

This bug report is separable from the rest of that feature. It's also 
much smaller, just two lines. :) This fixes the current behavior of the 
command tmm-menubar-mouse, which is bound to <menu-bar> <mouse-1>.

   -- MJF





  reply	other threads:[~2020-10-02 19:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-02  5:56 bug#43756: Fix for TTY menus mouse interaction Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-02 14:37 ` Lars Ingebrigtsen
2020-10-02 16:45   ` Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-02 19:35     ` Eli Zaretskii
2020-10-02 19:54       ` Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2020-10-03  7:23         ` Eli Zaretskii
2020-10-03 17:44           ` Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-05  8:24             ` Lars Ingebrigtsen
2020-10-05 14:53               ` Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-05 15:03                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=094def0cf664c29c513b0686929eb808@finder.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=43756@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=jared@finder.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).