From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: lekktu@gmail.com, 37415@debbugs.gnu.org
Subject: bug#37415: Asserting failure setting frame parameters to non-fixnum values in early-init.el
Date: Fri, 20 Sep 2019 10:13:03 +0200 [thread overview]
Message-ID: <0936d492-c2bc-d4d3-7fcf-272d0fdbe087@gmx.at> (raw)
In-Reply-To: <83o8zgtlvq.fsf@gnu.org>
>> But even if we cannot fix the behavior we have to avoid the crash.
>
> That was my purpose when I proposed to signal an error in this case.
Should we even signal an error then? The parameter would be applied
later anyway as soon as we can parse the display geometry. At least
here the frame appears as expected if my early-init.el just contains
(setq default-frame-alist '((left . (- 100))))
and the patch below is used.
martin
diff --git a/src/w32fns.c b/src/w32fns.c
index 34abd026f9..3771d9d5f9 100644
--- a/src/w32fns.c
+++ b/src/w32fns.c
@@ -5427,14 +5427,16 @@ my_create_window (struct frame * f)
RES_TYPE_NUMBER);
top = gui_display_get_arg (dpyinfo, Qnil, Qtop, "top", "Top",
RES_TYPE_NUMBER);
- if (EQ (left, Qunbound))
- coords[0] = CW_USEDEFAULT;
- else
+
+ if (FIXNUMP (left))
coords[0] = XFIXNUM (left);
- if (EQ (top, Qunbound))
- coords[1] = CW_USEDEFAULT;
else
+ coords[0] = CW_USEDEFAULT;
+
+ if (FIXNUMP (top))
coords[1] = XFIXNUM (top);
+ else
+ coords[1] = CW_USEDEFAULT;
if (!PostThreadMessage (dwWindowsThreadId, WM_EMACS_CREATEWINDOW,
(WPARAM)f, (LPARAM)coords))
next prev parent reply other threads:[~2019-09-20 8:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-15 22:34 bug#37415: Asserting failure setting frame parameters to non-fixnum values in early-init.el Juanma Barranquero
2019-09-17 16:01 ` Eli Zaretskii
2019-09-17 17:04 ` Juanma Barranquero
2019-09-18 7:45 ` martin rudalics
2019-09-18 12:31 ` Eli Zaretskii
2019-09-19 8:17 ` martin rudalics
2019-09-19 14:13 ` Eli Zaretskii
2019-09-20 8:13 ` martin rudalics [this message]
2019-09-20 19:08 ` Eli Zaretskii
2019-09-21 8:51 ` martin rudalics
2019-09-21 9:14 ` Eli Zaretskii
2019-09-21 10:02 ` Juanma Barranquero
2019-09-21 12:27 ` Eli Zaretskii
2019-09-22 5:54 ` Juanma Barranquero
2019-09-22 8:09 ` martin rudalics
2019-09-22 16:26 ` Eli Zaretskii
2019-09-22 8:08 ` martin rudalics
2019-09-22 16:43 ` Eli Zaretskii
2019-09-22 17:54 ` martin rudalics
2019-09-22 18:19 ` Eli Zaretskii
2019-09-23 7:32 ` martin rudalics
2019-09-23 16:35 ` Eli Zaretskii
2019-09-24 6:45 ` martin rudalics
2019-09-24 7:41 ` Eli Zaretskii
2019-09-22 8:08 ` martin rudalics
2019-09-22 16:27 ` Eli Zaretskii
2019-09-22 17:53 ` martin rudalics
2019-09-22 18:16 ` Eli Zaretskii
2019-09-23 7:32 ` martin rudalics
2019-09-23 16:08 ` Eli Zaretskii
2019-09-21 4:25 ` Juanma Barranquero
2019-09-18 2:30 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0936d492-c2bc-d4d3-7fcf-272d0fdbe087@gmx.at \
--to=rudalics@gmx.at \
--cc=37415@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).