From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails Date: Sat, 8 Feb 2020 12:36:46 +0300 Message-ID: <092bcdf9-c866-9eb0-b249-60381d445731@yandex.ru> References: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> <504aedd0-54e5-aa62-b19f-41fbafa9aa17@gmx.de> <09ef5fcb-80b7-3b43-243a-2278b46281ba@yandex.ru> <5c7d9eab-59d1-21c1-c8e5-1c820cb2946b@gmx.de> <25183dd6-10b3-c3c4-0910-262c70434161@gmx.de> <0a8b11c8-1c5c-33ed-e5a1-e7ad5b090929@yandex.ru> <834kw2g1ur.fsf@gnu.org> <38ea415e-9993-806c-3006-85e6e435fbd5@yandex.ru> <83v9oiebu3.fsf@gnu.org> <83k14xec8o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="81905"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 08 10:37:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j0MY4-000LD4-M7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Feb 2020 10:37:12 +0100 Original-Received: from localhost ([::1]:39388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j0MY3-0005QN-O1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Feb 2020 04:37:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34565) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j0MXv-0005IL-NM for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2020 04:37:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j0MXu-0003Mh-IQ for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2020 04:37:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44646) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j0MXu-0003Md-FJ for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2020 04:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j0MXu-0003WI-DM for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2020 04:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Feb 2020 09:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39380 X-GNU-PR-Package: emacs Original-Received: via spool by 39380-submit@debbugs.gnu.org id=B39380.158115461613514 (code B ref 39380); Sat, 08 Feb 2020 09:37:02 +0000 Original-Received: (at 39380) by debbugs.gnu.org; 8 Feb 2020 09:36:56 +0000 Original-Received: from localhost ([127.0.0.1]:50619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0MXn-0003Vt-QS for submit@debbugs.gnu.org; Sat, 08 Feb 2020 04:36:56 -0500 Original-Received: from mail-lj1-f195.google.com ([209.85.208.195]:39309) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0MXm-0003Vh-3K for 39380@debbugs.gnu.org; Sat, 08 Feb 2020 04:36:54 -0500 Original-Received: by mail-lj1-f195.google.com with SMTP id o15so1869596ljg.6 for <39380@debbugs.gnu.org>; Sat, 08 Feb 2020 01:36:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Aya3ADhM1v9LTCrDs+baHGxdvIo1j4aI4vHLfTKcTVY=; b=BkJQGXSaytDw6xOk2Fca68NytIpinat8QMYLWg5E1/etTYX7+RHM0t1TKEJr9Yx5G4 atsmFh1A6aywUbuJjq+CzrPl6gQ2DbqR0LtpRuTtIXOr418cgCWEUqu9blqS9chU8/Wk sxz4wp+GgVOWHLOylqBymOx6aaRhmoj1T2nav0d6fimy1gsXv9Xmj58Jp5IEKxUiXRCY DyjeduWauLFY4iv1VbqXczErDpMs6hza0IfJzWRGEPJn4M/3c0z7Z42ygA3LDv+5Cl8a Gt0mi2l6xOmuafhCvstL9DE39RBkeddUM7taH/uZ+oWrozgVfWIQhtoJp1RjL86Lh+uK QWcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Aya3ADhM1v9LTCrDs+baHGxdvIo1j4aI4vHLfTKcTVY=; b=Tf0jzWz7VO4EpjtBhV2Xz3xG9SjOUJNC0ZNKXHSCRTrL4TZdXA4IvRQYbM2P7J5Q9+ 5Ndnw/0B4TAydgMNXLlwU9GNcJUlw5mLUEOyYSJJAoPKLDWpx/3dD9L0SBbNaE7hCy0e ANXyw3mzQFO6wBRiUDgwsnKd032i94r2bKVXWGxHjTCF2pE9ho2x2NSgKy2jsTwS52i1 hyTTH4fsL3a/B4Uh7z2E0e3qhuKZkT55aoGl3wsvUTc77mHMw2bEMRYzJALHrFDF3zfo JFNLBhuluJYGsCf7qgYKQmXeb1vgThLLSgV6+10lAJbgZfm7oIc//FTtNT1uYgXuR2Iq 2a9A== X-Gm-Message-State: APjAAAXUDDgIACxo77HQ+hfPywnYfF5rCe+u9sdzUZzjNt4SMjvtcAW3 Dhw3v7lm0AoNLHDwQdjJ/kE= X-Google-Smtp-Source: APXvYqzIXSAEyIp0hQdiaCY+CX6uIQfxF7rz5J5y0ZZvzSPui7nroggMFopmQg85qxOJGkdukDluAA== X-Received: by 2002:a2e:918c:: with SMTP id f12mr2099893ljg.66.1581154607996; Sat, 08 Feb 2020 01:36:47 -0800 (PST) Original-Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id t10sm2707681lji.61.2020.02.08.01.36.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 08 Feb 2020 01:36:47 -0800 (PST) In-Reply-To: <83k14xec8o.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175780 Archived-At: On 08.02.2020 11:04, Eli Zaretskii wrote: >> And people want to open vc-dir buffers in any directory, not just in >> repository roots. > > If I say "hg status" in a subdirectory, I by default get file names > relative to the root. Wouldn't Mercurial users be surprised that > Emacs produces a different display? (I understand that there's a > recent tendency to make it easier to produce relative file names, and > there's even a config option to make that the default, but I'm asking > whether we should force this behavior on users even if their > preference is not to.) VC is intended to provide a unified interface across backends, even if it's at times different from the "native" behaviors. Anyway, it's very easy to get the names against the root anyway: just open VC-Dir there. And it's the default input: M-x vc-dir RET. >> We could force the file names to be absolute, and then pipe them through >> file-relative-name, but that's just extra work. > > I'm more bothered by the user-facing changes in this respect than by > algorithmic details. Would it work to set the default-directory of > the buffer to the repository's root instead? would that solve the > original problem? Again, it's a bugfix. VC-Dir expects this, other backends work like this, and vc-hg worked like this until Emacs 24 or 25. And the present behavior makes VC-Dir have broken behavior. There are only two possible reasons the buggy behavior wasn't noticed: a) Hg users are a minority among our users, b) most people open VC-Dir in repository root anyway. IOW, the difference wasn't triggered/seen. >>> This change should be in NEWS, IMO. >> >> It's a bugfix for an older, unintended change. It's not a new behavior. > > It changes how files are presented to the user, so I think it has > user-visible effects that should be mentioned in NEWS. I don't mind adding some NEWS entry, but, like said above, the users likely didn't see the change. > What about this question: > >> you are saying that "C-x v d" in a subdirectory of the root of a >> Mercurial repository became broken in Emacs 25.1? Yes. :-(