From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#43308: 28.0.50; Improvements to Edit->Search menu Date: Tue, 22 Sep 2020 09:59:08 -0700 (PDT) Message-ID: <090c6fc6-92b9-4604-bb14-e19287dd6685@default> References: <87zh5xiuk4.fsf@localhost>> <831rj9k79b.fsf@gnu.org>> > <83sgbpiqa7.fsf@gnu.org>> <87mu1xa380.fsf@mail.linkov.net>> <83imclii71.fsf@gnu.org>> <87wo1178cn.fsf@mail.linkov.net>> <83d02tifi3.fsf@gnu.org>> <87ft7cx6kh.fsf@localhost>> <83bli027is.fsf@gnu.org>> <498f6be5-f1ab-4f82-9cf1-ed5893f10ea1@default> <87wo0nbln5.fsf@mail.linkov.net> <6e21964e-a580-45ef-943f-a8ea97e58eef@default> <87sgbadxr9.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31761"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43308@debbugs.gnu.org, Ihor Radchenko , stefankangas@gmail.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 22 19:01:52 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kKlfr-0008BO-Od for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Sep 2020 19:01:51 +0200 Original-Received: from localhost ([::1]:57448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKlfq-0007YX-Nh for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Sep 2020 13:01:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKle7-0006Q5-9y for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 13:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49903) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kKle6-0006Un-UE for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 13:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kKle6-0006CH-TU for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 13:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Sep 2020 17:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43308 X-GNU-PR-Package: emacs Original-Received: via spool by 43308-submit@debbugs.gnu.org id=B43308.160079396323730 (code B ref 43308); Tue, 22 Sep 2020 17:00:02 +0000 Original-Received: (at 43308) by debbugs.gnu.org; 22 Sep 2020 16:59:23 +0000 Original-Received: from localhost ([127.0.0.1]:33212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKldT-0006Ag-Ex for submit@debbugs.gnu.org; Tue, 22 Sep 2020 12:59:23 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:41194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKldQ-0006AQ-JW for 43308@debbugs.gnu.org; Tue, 22 Sep 2020 12:59:22 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08MGws7v087644; Tue, 22 Sep 2020 16:59:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=o2dL5yMAv7MYbKl3N+Z58PzIqBO5c3Rnet7CwBS56xM=; b=IDUXRauPSP4PTw4BzdOQAPeo71Cq2ON7U64jcKa22jnRDrafVVqgBFm1+fu4fQrfGhFh qGeUC7m5d7SJ+1qhvGfPxjgNcROCAeZ6gYhsOrtrO8/t+UtNKvimTMbtH5dmUMMY4iL1 gtUpeNIxfj/C3fU40cSG3jojxtXUst97prwUbEpweOq5SccPxG7rIrit8ZlTmXzbT1Ct Zc/0LY8BhQezHE+jN1HxtVCXHDtJIqDTNzvaxSn4JoEwsv1qhu764OLeEHXpY9HZ5faT NNeipEm7GXQ8Mhzk+qxnegvu07rBXZpFspxKEqs65l6iS5SCKO3CtrQVXa5A4MnBdGyL bA== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 33ndnue1xx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 22 Sep 2020 16:59:14 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08MGsLtf065425; Tue, 22 Sep 2020 16:59:14 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 33nujnfmtk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 Sep 2020 16:59:14 +0000 Original-Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 08MGxAPj013018; Tue, 22 Sep 2020 16:59:10 GMT In-Reply-To: <87sgbadxr9.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9752 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 adultscore=0 spamscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009220130 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9752 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 clxscore=1015 impostorscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009220131 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188724 Archived-At: > >> Why no keybindings are shown for nonincremental menu items? > >> They still have keybindings, e.g. nonincremental forward search > >> can be started with 'C-s RET', nonincremental backward search > >> with 'C-r RET', nonincremental regexp search 'C-M-s RET', etc. > > > > I suppose I could add some explicitly, with :keys. > > That makes sense. Unfortunately, none show up > > automatically. It would be good to somehow fix that. >=20 > How about the following patch? It doesn't fix the nonautomatic display of keys, does it? > BTW, why "Search Tagged Files..." and "Continue Tags Search" have > no keybindings? Because they have no keyboard key bindings. Or was that your question? Did `tags-search' ever have a default keyboard binding? For `Continue Tags Search' I think the reason was that when Emacs moved to xref it dropped the `M-,' key binding for that command (`tags-loop-continue'). (I wasn't in favor of that.) > Another problem is that selecting "Continue Tags Search" > signals the error: >=20 > emacs -Q > Select "Edit" -> "Search" -> "Continue Tags Search" >=20 > Lisp error: (wrong-type-argument commandp fileloop-continue) I don't see that with emacs -Q, loading menu-bar+.el, and using that item in the Search menu (which is not under Edit). Dunno why. I see just this error message: "No operation in progress", which makes sense. > I think "Continue Tags Search" should be disabled when it has no effect. I've done that now, in menu-bar+.el. I use this, but perhaps someone can let me know if it's not the right, or best, condition to use. (I use condition-case, not ignore-errors, for compatibility with older Emacs.) :enable (not (condition-case nil (tags-loop-eval tags-loop-scan) (error t)))