From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 13764@debbugs.gnu.org
Subject: bug#13764: 24.3.50; please do not use defsubst for `font-lock-(apply-highlight|fontify-anchored-keywords)'
Date: Fri, 29 Apr 2016 09:17:25 -0700 (PDT) [thread overview]
Message-ID: <090ab034-aeeb-432e-b597-a138c5c13efa@default> (raw)
In-Reply-To: <87lh3x2wnn.fsf@gnus.org>
> > These are not tiny, trivial functions.
> >
> > They do not fit the criteria for `defsubst' outlined in (elisp)
> > `Inline Functions'. And they introduce all of the disadvantages
> > listed there, especially this one, listed first:
>
> [...]
>
> > I see no reason why these function should not be defuns.
>
> Presumably they are that way because of efficiency concerns. Have you
> done benchmarking to compare the impact of these defsubsts turning into
> defuns?
Oh come on. Why such a presumption? Did you look at the code?
Read what you quoted above. These do not fit the clearly
documented criteria for `defsubst'.
Do you see a reason why these should be `defsubsts'?
Have you done benchmarking to support such a supposition?
As they don't fit the Emacs criteria, and there is no code
comment that calls out why they - exceptionally - should be
defsubsts in spite of not fulfilling the criteria, a priori
they should not be defsubsts. The burden of proof lies
with a claim that they - exceptionally - should be.
Not to mention that there is less and less need for using
defsubst.
next prev parent reply other threads:[~2016-04-29 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 17:24 bug#13764: 24.3.50; please do not use defsubst for `font-lock-(apply-highlight|fontify-anchored-keywords)' Drew Adams
2016-04-28 22:31 ` Lars Ingebrigtsen
2016-04-29 16:17 ` Drew Adams [this message]
2019-10-30 12:45 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=090ab034-aeeb-432e-b597-a138c5c13efa@default \
--to=drew.adams@oracle.com \
--cc=13764@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).