unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>, Eli Zaretskii <eliz@gnu.org>
Cc: "Mattias Engdegård" <mattiase@acm.org>,
	ture@turepalsson.se, 41445@debbugs.gnu.org
Subject: bug#41445: 26.3; Query-replace triggers "match data clobbered by..."
Date: Sat, 23 May 2020 08:43:33 -0700 (PDT)	[thread overview]
Message-ID: <08eb08ac-0ff0-424c-9885-271f36c6daa8@default> (raw)
In-Reply-To: <jwva71yls1p.fsf-monnier+emacs@gnu.org>

>     NOTE: The convention in Elisp is that any function, except for a
>     few exceptions like car/assoc/+/goto-char, can clobber the match
>     data, so `save-match-data' should normally be used to save *your* 
>     match data rather than your caller's match data.

+1.  I like that, especially the last phrase.
Clear; important to get across.





  reply	other threads:[~2020-05-23 15:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-22  5:07 bug#41445: 26.3; Query-replace triggers "match data clobbered by..." Ture Pålsson
2020-05-22 10:46 ` Mattias Engdegård
2020-05-22 11:11   ` Eli Zaretskii
2020-05-22 11:16     ` Mattias Engdegård
2020-05-22 12:07       ` Eli Zaretskii
2020-05-22 12:21         ` Mattias Engdegård
2020-05-22 12:35           ` Eli Zaretskii
2020-05-23 11:36         ` Mattias Engdegård
2020-05-23 12:28           ` Eli Zaretskii
2020-05-23 12:37             ` Philipp Stephani
2020-05-23 13:07               ` Eli Zaretskii
2020-05-23 13:08               ` Mattias Engdegård
2020-05-23 13:36             ` Stefan Monnier
2020-05-23 15:43               ` Drew Adams [this message]
2020-05-27 14:31               ` Mattias Engdegård
2020-05-27 15:54                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08eb08ac-0ff0-424c-9885-271f36c6daa8@default \
    --to=drew.adams@oracle.com \
    --cc=41445@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=mattiase@acm.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=ture@turepalsson.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).