unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Felix <felix.dick@web.de>, 70059@debbugs.gnu.org
Subject: bug#70059: 30.0.50; c-ts-mode crashes emacs
Date: Sun, 7 Apr 2024 23:32:01 -0700	[thread overview]
Message-ID: <08F912D5-CCC4-42C8-8C27-B1CB2085FEA0@gmail.com> (raw)
In-Reply-To: <865xwzaa1t.fsf@gnu.org>



> On Apr 2, 2024, at 11:34 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Tue, 2 Apr 2024 11:22:44 -0700
>> Cc: Eli Zaretskii <eliz@gnu.org>,
>> 70059@debbugs.gnu.org
>> 
>>> But as i wrote, it doesn't crash with tree-sitter from the official arch
>>> linux repos, and because i program in C every day, i switched to the
>>> stable tree-sitter and had no problems since.
>>> 
>>> That's why i asked if a faulty tree-sitter should be able to crash
>>> emacs. If that is acceptable, this bug report can be closed.
>> 
>> I mean tree-sitter (the library) runs in the main thread, if it triggers a segfault, AFAIK Emacs currently can’t really do anything. Is that right Eli?
> 
> You are right.  But these crashes seem to be inside GC, which
> processes our objects, so if tree-sitter somehow causes us to create
> invalid Lisp objects, it's our fault, at least to some extent.

If the crash happens in ts_node_delete, ts_parser_delete or ts_tree_delete, would the backtrace record that? (Given that the tree-sitter library probably isn’g compile with symbols.) If the crash happens in those functions I think it’s not our fault.

Yuan




  reply	other threads:[~2024-04-08  6:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28 20:36 bug#70059: 30.0.50; c-ts-mode crashes emacs Felix via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-29  5:39 ` Eli Zaretskii
2024-03-29 10:51   ` Felix via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-29 11:25     ` Eli Zaretskii
2024-03-29 11:37       ` Felix via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-29 12:08         ` Eli Zaretskii
2024-03-31  5:52           ` Yuan Fu
2024-03-31  7:43             ` Eli Zaretskii
2024-04-02 18:20               ` Yuan Fu
2024-03-31  8:09             ` Felix via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-02 18:22               ` Yuan Fu
2024-04-02 18:34                 ` Eli Zaretskii
2024-04-08  6:32                   ` Yuan Fu [this message]
2024-04-08 11:35                     ` Eli Zaretskii
2024-04-17 13:13                       ` Felix via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-17 13:18                         ` Eli Zaretskii
2024-03-30 14:29         ` Andrea Corallo
2024-03-30 11:26   ` Andrea Corallo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08F912D5-CCC4-42C8-8C27-B1CB2085FEA0@gmail.com \
    --to=casouri@gmail.com \
    --cc=70059@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=felix.dick@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).