bug#16151: margin does not respect face-remapping-alist. no margin face.

bug#16151: margin does not respect face-remapping-alist. no margin face.

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

Emacs -Q

Then:

(linum-mode 1)
(setq face-remapping-alist '((default . custom-invalid)))

Observe that the empty space in the left margin is white, rather than red.  See attached screenshot.

The left (and presumably right) margins seem to use the default face, but fail to take `face-remapping-alist' into account.

It would not hurt to have a `margins' face,  but even then, remapping should be observed.


This is an up to date build.



In GNU Emacs 24.3.50.4 (x86_64-apple-darwin13.0.0, NS apple-appkit-1265.00)
 of 2013-12-14 on momo
Windowing system distributor `Apple', version 10.3.1265
Configured using:
 `configure --with-ns'

[-- Attachment #2.1: Type: text/html, Size: 1267 bytes --]

[-- Attachment #2.2: Screen Shot 2013-12-14 at 5.09.07 PM.png --]
[-- Type: image/png, Size: 90350 bytes --]

bug#16151: margin does not respect face-remapping-alist. no margin face.

[Eli Zaretskii]

> From: David Reitter <david.reitter@gmail.com>
> Date: Sat, 14 Dec 2013 17:30:17 -0500
> 
> Emacs -Q
> 
> Then:
> 
> (linum-mode 1)
> (setq face-remapping-alist '((default . custom-invalid)))

(I'm guessing this wasn't exactly "emacs -Q", because custom-invalid
face is not known in 'emacs -Q", at least on my system.)

> Observe that the empty space in the left margin is white, rather than red.  See attached screenshot.
> 
> The left (and presumably right) margins seem to use the default face, but fail to take `face-remapping-alist' into account.

No, they do take the face remapping into account.  Otherwise, how
could you have the correct face where the line numbers _are_ written
in the margin, as clearly seen in your screenshots?

The problem was that the empty margin area was not filled with the
background of the default face, whether remapped or not, like we do
with the text area.  This was never supported in Emacs, the code to do
that was simply never written.

Now this works, starting from trunk revision 115535.

> It would not hurt to have a `margins' face

??? What is shown in the margins is display strings which have to be
hand-crafted anyway, so you can have any face you want there, just
propertize the string accordingly.  Why do we need another face?

Thanks.

bug#16151: closed (Re: bug#16151: margin does not respect face-remapping-alist. no margin face.)

[David Reitter]

On Dec 15, 2013, at 12:05 PM, GNU bug Tracking System <help-debbugs@gnu.org> wrote:
> 
> (I'm guessing this wasn't exactly "emacs -Q", because custom-invalid
> face is not known in 'emacs -Q", at least on my system.)

Yes, sorry, it seems that custom-invalid got loaded when I ran customize-face to work out the test case.
> 
> No, they do take the face remapping into account.  Otherwise, how
> could you have the correct face where the line numbers _are_ written
> in the margin, as clearly seen in your screenshots?

`linum' is a face that inherits from default, so that's where I expected this came from.

Anyway, thanks for fixing this so quickly.

> ??? What is shown in the margins is display strings which have to be
> hand-crafted anyway, so you can have any face you want there, just
> propertize the string accordingly.  Why do we need another face?

Is there another way to set the color of the background now?  We have the margin, then the fringe and then the regular window contents.  Normally, I would use the same background for fringe and margin.  

The `linum' face I mentioned just customizes actual line numbers, but not areas where there are no line numbers (e.g., wrapped lines, or beyond the end of the buffer, as in this example).

Pretty much everything else is customizable, so it would having a margin face would just be consistent.