unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: David Reitter <david.reitter@gmail.com>
To: 16151@debbugs.gnu.org
Subject: bug#16151: closed (Re: bug#16151: margin does not respect face-remapping-alist. no margin	face.)
Date: Sun, 15 Dec 2013 14:41:26 -0500	[thread overview]
Message-ID: <08ECE49D-DFD4-46D7-956D-D1A92BB18E87@gmail.com> (raw)
In-Reply-To: <handler.16151.D16151.138712707531374.notifdone@debbugs.gnu.org>

On Dec 15, 2013, at 12:05 PM, GNU bug Tracking System <help-debbugs@gnu.org> wrote:
> 
> (I'm guessing this wasn't exactly "emacs -Q", because custom-invalid
> face is not known in 'emacs -Q", at least on my system.)

Yes, sorry, it seems that custom-invalid got loaded when I ran customize-face to work out the test case.
> 
> No, they do take the face remapping into account.  Otherwise, how
> could you have the correct face where the line numbers _are_ written
> in the margin, as clearly seen in your screenshots?

`linum' is a face that inherits from default, so that's where I expected this came from.

Anyway, thanks for fixing this so quickly.

> ??? What is shown in the margins is display strings which have to be
> hand-crafted anyway, so you can have any face you want there, just
> propertize the string accordingly.  Why do we need another face?

Is there another way to set the color of the background now?  We have the margin, then the fringe and then the regular window contents.  Normally, I would use the same background for fringe and margin.  

The `linum' face I mentioned just customizes actual line numbers, but not areas where there are no line numbers (e.g., wrapped lines, or beyond the end of the buffer, as in this example).

Pretty much everything else is customizable, so it would having a margin face would just be consistent.






      parent reply	other threads:[~2013-12-15 19:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-14 22:30 bug#16151: margin does not respect face-remapping-alist. no margin face David Reitter
2013-12-15 17:03 ` Eli Zaretskii
     [not found] ` <handler.16151.D16151.138712707531374.notifdone@debbugs.gnu.org>
2013-12-15 19:41   ` David Reitter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08ECE49D-DFD4-46D7-956D-D1A92BB18E87@gmail.com \
    --to=david.reitter@gmail.com \
    --cc=16151@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).