From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#67977: 30.0.50; tree-sitter: Emacs crashes when accessing treesit-nodes in a narrowed buffer Date: Sat, 23 Dec 2023 19:00:34 -0800 Message-ID: <08D379EF-1556-4498-8E60-F7972A25752A@gmail.com> References: <87r0jdddxf.fsf@yandex.ru> <835y0pfkgr.fsf@gnu.org> <1DE32BF7-75D8-4F49-975D-53C782D26016@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29051"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Denis Zubarev , 67977@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 24 04:02:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rHEkq-0007Lt-66 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Dec 2023 04:02:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rHEkY-0004Rk-RX; Sat, 23 Dec 2023 22:01:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHEkX-0004RX-NQ for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2023 22:01:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rHEkX-0006Du-FY for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2023 22:01:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rHEkc-00037x-6D for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2023 22:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Dec 2023 03:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67977 X-GNU-PR-Package: emacs Original-Received: via spool by 67977-submit@debbugs.gnu.org id=B67977.170338687511317 (code B ref 67977); Sun, 24 Dec 2023 03:02:02 +0000 Original-Received: (at 67977) by debbugs.gnu.org; 24 Dec 2023 03:01:15 +0000 Original-Received: from localhost ([127.0.0.1]:51548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHEjq-0002vu-Td for submit@debbugs.gnu.org; Sat, 23 Dec 2023 22:01:15 -0500 Original-Received: from mail-oi1-x22a.google.com ([2607:f8b0:4864:20::22a]:57582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHEjo-0002nq-Ph for 67977@debbugs.gnu.org; Sat, 23 Dec 2023 22:01:13 -0500 Original-Received: by mail-oi1-x22a.google.com with SMTP id 5614622812f47-3bb85a202c2so1816701b6e.2 for <67977@debbugs.gnu.org>; Sat, 23 Dec 2023 19:01:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703386861; x=1703991661; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lN4iWefQjStMy7Ujmk302goZHUFh8XvOH6QuLnME52o=; b=UUaXHCKcuYWbUODJlHtBxzOkcaR2cVwRQ2ClJ83Haj/kp5PjNYsXipTHh8yzzufr4k DQam89t87Kz4P5HsUPughvEtup3riZxB0gVDbsSqAZzW0pKcCP3YS+uSjw8LgdnWb36K kWZsYAHinB/J5aqpcHm4YXb20oeNMi88PfkfERry94D9NPEbKMPy7o48C/gD/O4NlaHR LFRNMmFiSj0WlPJkt1efJNoXELYQ0QyyPk425LJcnVRukWfKe1D/utxvhen30mVAnVZj 5jSO168SaekMLnKjHfyJmSFqYqgQXYYaH6O8OSklX5zB+JeNhCRvtau/OKgpqswG6l1+ GGJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703386861; x=1703991661; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lN4iWefQjStMy7Ujmk302goZHUFh8XvOH6QuLnME52o=; b=UVAIlcgzNjgvEH93WPQf/6vpu+73r6r7B0jXqbmVHM+FEM0cqtnteqspk/NOwIe+iU LhBGEbSB2HKXH/Wa+Jv+r04UUW3OagHtv+EGJhruMAK1rmKy1TG6G6HQ0Ro7GIH5ewrq JLD09H5UL7NjM5ci3nAhqthyg0v3UGhaIpb8vojCjlvjN9fciWgCAK/lHZseQyxWkQVm YvrP2rkG+xwtRu1Iki3oVxiulKI0p+Om2qHbN1qsDUQGlKiV451VBV3ELin0/Tzd8+9o rRKord5bDtrXKaOkWP4l+RXc8X5bTEGfcLPJ2mQWtN5xJhegHE8xTGoqO0cG7w4+QztA kZHA== X-Gm-Message-State: AOJu0YxAPBGL8znkej/dk+pex+FRFFAcbJ3F6i5HOxpSjx8soQxgu5rU UaaLQRA4ZJptT8kizJ2TuAw= X-Google-Smtp-Source: AGHT+IE3koi/3Y9yMzq3D+yqyiv7V1zg7+EwysbQNQHhdjv+cZ1nLeAxSqdOTSx7zLvZYSZSeA4dgA== X-Received: by 2002:a05:6808:4447:b0:3bb:8b7e:7e52 with SMTP id ep7-20020a056808444700b003bb8b7e7e52mr4241410oib.119.1703386861445; Sat, 23 Dec 2023 19:01:01 -0800 (PST) Original-Received: from smtpclient.apple (172-117-161-177.res.spectrum.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id o6-20020a056a001b4600b006d98e42d5desm3353035pfv.193.2023.12.23.19.00.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Dec 2023 19:01:00 -0800 (PST) In-Reply-To: <1DE32BF7-75D8-4F49-975D-53C782D26016@gmail.com> X-Mailer: Apple Mail (2.3731.700.6) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276782 Archived-At: > On Dec 23, 2023, at 12:08 AM, Yuan Fu wrote: >=20 >=20 >=20 >> On Dec 22, 2023, at 11:26 PM, Eli Zaretskii wrote: >>=20 >>> From: Denis Zubarev >>> Date: Sat, 23 Dec 2023 02:18:20 +0300 >>>=20 >>> 1. emacs -Q >>> 2. M-x find-file /tmp/t.py >>> 3. paste there >>> start=3D1 >>> def _init(self, param1, param2, param3=3DFalse): >>> self._param1 =3D param2 >>> self._param2 =3D param2 >>> self._param3 =3D param3 >>> 4. python-ts-mode >>> 5. select two last lines and M-x narrow-to-region >>> 6. answer all prompts >>> 7. Put cursor on the last self >>> 8. M-x eval-expression >>> (progn >>> (setq temp-node (treesit-node-at (point))) >>> (sit-for 2) >>> (garbage-collect) >>> (message "node %s" temp-node)) >>> 9. Emacs crashes or prints node that contains garbage >>=20 >> Thanks. >>=20 >> Yuan, this also happens on the emacs-29 branch, so we should try >> fixing this crash ASAP. >=20 > Yeah. The node wants to print it=E2=80=99s type name (with = ts_node_type), which access it=E2=80=99s parse tree, but the tree is = already freed, that means the node is outdated and shouldn=E2=80=99t try = to print it=E2=80=99s type name, but should rather print =E2=80=9Coutdated= =E2=80=9D. >=20 > But simply narrowing the buffer shouldn=E2=80=99t reparse the buffer = and cause the parse tree to be freed. Anyway, let me see what=E2=80=99s = going on. I pushed a fix and now it shouldn=E2=80=99t crash anymore. However, = I=E2=80=99m yet not sure why at some point the buffer was widened. Is = there any way to track who called widen? Yuan=